1) portscout detects nonexistent version 0.9.1; the port is up-to-date and the last released version is 0.9.0: http://www.m17n.org/m17n-lib-en/download.html Added skipv accordingly. 2) Fix MASTER_SITES order (project homepage first).
Please fix Synopsis; it should be: [Maintainer] textproc/m17n-im-config: Add PORTSCOUT to prevent detection of nonexistent version; fix MASTER_SITES order
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it.
> Synopsis: [Maintainer] Add PORTSCOUT to prevent detection of nonexistent version; fix MASTER_SITES order > > http://www.freebsd.org/cgi/query-pr.cgi?pr=137519 This is incorrect. First, it defies the purpose of portscout, which is to report new distfiles - with this change, even if 0.9.1 is released, it won't be reported. False positives should be fixed either in portscount or servers hosting the distfiles. Next, this is also incorrect +MASTER_SITES= http://www.m17n.org/common/im-config/ \ +MASTER_SITES= http://anthesphoria.net/FreeBSD/ports/distfiles/ as MASTER_SITES will contain `MASTER_SITES=' as well as normal urls. Here's fixed version that I propose: --- m17n-im-config.patch begins here --- Index: Makefile =================================================================== RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/textproc/m17n-im-config/Makefile,v retrieving revision 1.2 diff -u -r1.2 Makefile --- Makefile 23 Jun 2009 04:46:05 -0000 1.2 +++ Makefile 7 Aug 2009 16:04:31 -0000 @@ -8,8 +8,8 @@ PORTNAME= m17n-im-config PORTVERSION= 0.9.0 CATEGORIES= textproc -MASTER_SITES= http://anthesphoria.net/FreeBSD/ports/distfiles/ \ - http://www.m17n.org/common/im-config/ +MASTER_SITES= http://www.m17n.org/common/im-config/ \ + http://anthesphoria.net/FreeBSD/ports/distfiles/ MAINTAINER= nikola.lecic@anthesphoria.net COMMENT= A GUI for per-user configuration of m17n-lib input methods --- m17n-im-config.patch ends here --- -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
State Changed From-To: open->feedback Awaiting submitters feedback
Hi Dmitry, On Fri, 7 Aug 2009 20:25:54 +0400 Dmitry Marakasov <amdmi3@amdmi3.ru> wrote: > > Synopsis: [Maintainer] Add PORTSCOUT to prevent detection of > > nonexistent version; fix MASTER_SITES order > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=137519 > > This is incorrect. First, it defies the purpose of portscout, which > is to report new distfiles - with this change, even if 0.9.1 is > released, it won't be reported. False positives should be fixed > either in portscount or servers hosting the distfiles. Well, I proposed this according to a private mail from miwi@ (I understood he suggested patching the port): --------------------------------- >8 ----------------------------------- On Mon, 6 Jul 2009 23:12:32 +0200 Martin Wilke <miwi@FreeBSD.org> wrote: | The version 0.9.1 indicated by Portscout doesn't exist. Can this be | fixed? I can skip this version you want, but this need a commit the portstree. - - Martin --------------------------------- >8 ----------------------------------- So, no solution other than skipv? > Next, this is also incorrect > > +MASTER_SITES= http://www.m17n.org/common/im-config/ \ > +MASTER_SITES= http://anthesphoria.net/FreeBSD/ports/distfiles/ > > as MASTER_SITES will contain `MASTER_SITES=' as well as normal urls. You are right, sorry, rashly swapped lines. :-) > Here's fixed version that I propose: ... so, yes, this is correct. Thank you! -- Nikola Lecic fingerprint : FEF3 66AF C90E EDC3 D878 7CDC 956D F4AB A377 1C9B ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
* Nikola Lecic (nikola.lecic@anthesphoria.net) wrote: > Well, I proposed this according to a private mail from miwi@ (I > understood he suggested patching the port): Yes, it's done like that, but I'd not recommend to do it against false positive next versions due to stated reasons. I also have a port with such problem (games/neverball), but I prefer a false positive that makes me periodically check it's website for an actul update to being forgotten of it. Also, skipv doesn't seem to work, at least for portscout.org :) See games/brainworkshop and games/ivan. These have skipv, but still reported. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
On Fri, 7 Aug 2009 21:19:40 +0400 Dmitry Marakasov <amdmi3@amdmi3.ru> wrote: > * Nikola Lecic (nikola.lecic@anthesphoria.net) wrote: > > > Well, I proposed this according to a private mail from miwi@ (I > > understood he suggested patching the port): > > Yes, it's done like that, but I'd not recommend to do it against > false positive next versions due to stated reasons. I also have a > port with such problem (games/neverball), but I prefer a false > positive that makes me periodically check it's website for an actul > update to being forgotten of it. > > Also, skipv doesn't seem to work, at least for portscout.org :) > See games/brainworkshop and games/ivan. These have skipv, but still > reported. Heh, true :-) I understand. So, please go ahead with your modified patch. Thank you very much! -- Nikola Lecic fingerprint : FEF3 66AF C90E EDC3 D878 7CDC 956D F4AB A377 1C9B ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
State Changed From-To: feedback->open Feedback received
State Changed From-To: open->closed Committed. Thanks!
amdmi3 2009-08-07 18:12:44 UTC FreeBSD ports repository Modified files: textproc/m17n-im-config Makefile Log: - Reorder MASTER_SITES (project homepage first) PR: 137519 Submitted by: Nikola Lecic <nikola.lecic@anthesphoria.net> (maintainer) Revision Changes Path 1.5 +2 -2 ports/textproc/m17n-im-config/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"