Bug 137621 - [PATCH] multimedia/avidemux2: unbreak build with cmake
Summary: [PATCH] multimedia/avidemux2: unbreak build with cmake
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Max Brazhnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-10 09:00 UTC by Ulrich Spoerlein
Modified: 2009-08-23 11:44 UTC (History)
1 user (show)

See Also:


Attachments
avidemux2-2.4.4_2.patch (1.51 KB, patch)
2009-08-10 09:00 UTC, Ulrich Spoerlein
no flags Details | Diff
avidemux2.diff (3.61 KB, patch)
2009-08-11 07:34 UTC, Max Brazhnikov
no flags Details | Diff
avidemux2.diff (3.23 KB, patch)
2009-08-21 12:05 UTC, Ulrich Spoerlein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Spoerlein 2009-08-10 09:00:13 UTC
- Unbreak build with cmake
- fix taken from http://trac.macports.org/ticket/19859

Added file(s):
- files/patch-avidemux__CMakeLists

Port maintainer (amistry@am-productions.biz) is cc'd.
Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-08-10 09:00:36 UTC
Maintainer of multimedia/avidemux2,

Please note that PR ports/137621 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/137621

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-08-10 09:00:41 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Max Brazhnikov freebsd_committer freebsd_triage 2009-08-10 18:47:28 UTC
Responsible Changed
From-To: freebsd-ports-bugs->makc

I'll take it.
Comment 4 Max Brazhnikov 2009-08-11 07:34:12 UTC
here is updated patch, which fixes build with QT4 enabled.

Max
Comment 5 Ulrich Spoerlein 2009-08-11 09:03:27 UTC
On Tue, 11.08.2009 at 10:34:12 +0400, Max Brazhnikov wrote:
> here is updated patch, which fixes build with QT4 enabled.

Hmm, this is odd as I did not have the need for any additional patches
to compile the QT4 frontend. I will give the patch a spin tomorrow or
the day after.
Comment 6 Max Brazhnikov 2009-08-11 10:47:50 UTC
On Tue, 11 Aug 2009 10:03:27 +0200, Ulrich Sp=F6rlein wrote:
> On Tue, 11.08.2009 at 10:34:12 +0400, Max Brazhnikov wrote:
> > here is updated patch, which fixes build with QT4 enabled.
>
> Hmm, this is odd as I did not have the need for any additional patches
> to compile the QT4 frontend. I will give the patch a spin tomorrow or
> the day after.

It compiles well with qt4, but fails to make package.

Max
Comment 7 Ulrich Spoerlein 2009-08-21 12:05:49 UTC
On Tue, 11.08.2009 at 13:47:50 +0400, Max Brazhnikov wrote:
> It compiles well with qt4, but fails to make package.

Indeed, thanks for the testing. I had to use a slightly different patch
than you, though.

I tested all four combinations of WITH/OUT GTK/QT4 and everything seems
fine. There are some bugs with the QT4 frontend, but that's for the
upstream vendor and it's not the port default anyway.

Please see the attached patch and commit before ports freeze. Thanks!

Regards,
Uli
Comment 8 amistry 2009-08-21 18:44:50 UTC
Ulrich Spoerlein wrote:
> On Tue, 11.08.2009 at 13:47:50 +0400, Max Brazhnikov wrote:
>   
>> It compiles well with qt4, but fails to make package.
>>     
>
> Indeed, thanks for the testing. I had to use a slightly different patch
> than you, though.
>
> I tested all four combinations of WITH/OUT GTK/QT4 and everything seems
> fine. There are some bugs with the QT4 frontend, but that's for the
> upstream vendor and it's not the port default anyway.
>
> Please see the attached patch and commit before ports freeze. Thanks!
>
> Regards,
> Uli
>   
I don't have time to test this before going out of town, but if the 
testing works, go ahead and commit it so we have a wokring version for 
the freeze.
Comment 9 dfilter service freebsd_committer freebsd_triage 2009-08-23 11:37:04 UTC
makc        2009-08-23 10:36:55 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/avidemux2 Makefile pkg-plist 
    multimedia/avidemux2/files patch-cmake__Ts.cmake 
  Added files:
    multimedia/avidemux2/files patch-avidemux__CMakeLists.txt 
  Log:
  Unbreak [1]
  Fix plist when building with QT4 support
  
  PR:             ports/137621 [1]
  Submitted by:   Ulrich Spoerlein <uspoerlein at gmail.com>
  Approved by:    Anish Mistry (maintainer)
  
  Revision  Changes    Path
  1.62      +1 -4      ports/multimedia/avidemux2/Makefile
  1.1       +35 -0     ports/multimedia/avidemux2/files/patch-avidemux__CMakeLists.txt (new)
  1.2       +3 -3      ports/multimedia/avidemux2/files/patch-cmake__Ts.cmake
  1.10      +1 -0      ports/multimedia/avidemux2/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 10 Max Brazhnikov freebsd_committer freebsd_triage 2009-08-23 11:44:15 UTC
State Changed
From-To: feedback->open

maintainer approved
Comment 11 Max Brazhnikov freebsd_committer freebsd_triage 2009-08-23 11:44:23 UTC
State Changed
From-To: open->closed

Committed. Thanks!