Bug 137992 - [PATCH] The startup script of mail/spamd has several bugs
Summary: [PATCH] The startup script of mail/spamd has several bugs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-20 14:00 UTC by Denny Lin
Modified: 2009-09-17 13:41 UTC (History)
0 users

See Also:

Attachments
file.diff (946 bytes, patch)
2009-08-20 14:00 UTC, Denny Lin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Denny Lin 2009-08-20 14:00:09 UTC 
1. Originally, the -b flag required a space before it in case of a misread such as 'IP-based'. This can be worked around by using "(^\-b| \-b)", so now the script functions normally even when no space it added.

2. When spamd is started in blacklist mode, the -b flag for  is appended by obspamd_flags. However, spamd-setup in the startup script doesn't use this setting. As a result, the blacklists fail to load in blacklist mode. By adding if and else conditions, this can be fixed as well.

Fix: See patch.

Patch attached with submission follows:
How-To-Repeat: Simply use blacklist mode with a normal installation of mail/spamd.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-08-20 14:00:17 UTC 
Maintainer of mail/spamd,

Please note that PR ports/137992 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/137992

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-08-20 14:00:19 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Olli Hauer 2009-08-20 15:51:43 UTC 
Hi Denny Lin,

thanks for the patch.

Patch approved, please commit.

Regards,
olli
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2009-09-16 23:39:20 UTC 
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2009-09-17 13:37:18 UTC 
State Changed
From-To: open->closed

Committed, thanks!