Bug 138410 - finance/gnucash quote price editor adds price data as wrong date.
Summary: finance/gnucash quote price editor adds price data as wrong date.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-31 19:30 UTC by Takanori Watanabe
Modified: 2010-10-03 18:10 UTC (History)
0 users

See Also:

Attachments
file.diff (290 bytes, patch)
2009-08-31 19:30 UTC, Takanori Watanabe 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Takanori Watanabe 2009-08-31 19:30:08 UTC 
gnucash quote price editor consume date string and convert the string by strptime(3) then get time_t by mktime(3). And struct tm,  a mktime argument
is not initialized and mktime detects insane structure and returns -1. So the entry is always added as epoch -1 date.

Fix: Add following patch as
files/patch-src-app-utils-guile-util.c 
And rebuild.
How-To-Repeat: Use Price Editor and try to get quotes of your portfolio. Note that it is not always occur because it is caued by wild structure.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-09-01 04:15:40 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ahze

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2010-07-26 00:05:44 UTC 
Responsible Changed
From-To: ahze->gnome

Over to new maintainer.
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-10-03 18:04:12 UTC 
mezz        2010-10-03 17:04:08 UTC

  FreeBSD ports repository

  Modified files:
    finance/gnucash      Makefile 
  Added files:
    finance/gnucash/files patch-src_app-utils_guile-util.c 
  Log:
  Fix the quote price editor adds price data as wrong date. Bump the
  PORTREVISION. More details by the submitter:
  
  "gnucash quote price editor consume date string and convert the string by
  strptime(3) then get time_t by mktime(3). And struct tm, a mktime argument
  is not initialized and mktime detects insane structure and returns -1. So
  the entry is always added as epoch -1 date."
  
  PR:             ports/138410
  Submitted by:   Takanori Watanabe <takawata@init-main.com>
  
  Revision  Changes    Path
  1.148     +1 -1      ports/finance/gnucash/Makefile
  1.1       +11 -0     ports/finance/gnucash/files/patch-src_app-utils_guile-util.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Jeremy Messenger freebsd_committer freebsd_triage 2010-10-03 18:04:21 UTC 
State Changed
From-To: open->closed

Committed, thanks! It will be great if you can submit this patch to its bug 
tracker.