Bug 138943 - security/openssh-portable version 5.2p1_2,1 broke WITH_OVERWRITE_BASE
Summary: security/openssh-portable version 5.2p1_2,1 broke WITH_OVERWRITE_BASE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-18 19:10 UTC by Alson van der Meulen
Modified: 2009-09-23 19:50 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alson van der Meulen 2009-09-18 19:10:01 UTC
Installation of security/openssh-portable version 5.2p1_2,1 breaks if WITH_OVERWRITE_BASE is defined:
echo "===> Installing rc.d startup script(s)"
===> Installing rc.d startup script(s)
echo "@cwd /usr" >> /usr/ports/security/openssh-portable/work/.PLIST.mktmp
for i in openssh; do  install  -o root -g wheel -m 555 /usr/ports/security/opens
sh-portable/work/${i} /usr/etc/rc.d/${i%.sh};  echo "etc/rc.d/${i%.sh}" >> /usr/
ports/security/openssh-portable/work/.PLIST.mktmp;  done
install: /usr/etc/rc.d/openssh: No such file or directory
*** Error code 71

This is caused by this change:
@@ -182,8 +187,7 @@ CONFIGURE_ARGS+=	--localstatedir=/var
 EMPTYDIR=		/var/empty
 PREFIX=			/usr
 ETCSSH=			/etc/ssh
-USE_RC_SUBR=		yes
-SUB_FILES+=		openssh
+USE_RC_SUBR=		openssh
 PLIST_SUB+=		NOTBASE="@comment "
 PLIST_SUB+=		BASE=""
 PLIST_SUB+=		BASEPREFIX="${PREFIX}"
(this is within a .if defined(WITH_OVERWRITE_BASE))

Fix: 

Reverting the above part of the diff allows me to install
openssh-portable. Not sure about the original purpose of the change,
but it's at least a work-around.
How-To-Repeat: Enable WITH_OVERWRITE_BASE and attempt to install the port.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-09-18 19:10:09 UTC
Maintainer of security/openssh-portable,

Please note that PR ports/138943 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/138943

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-09-18 19:10:11 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Denis Barov 2009-09-18 23:25:45 UTC
Ar-r, those sad FATALs in portlint's output.

 - returned back good old USE_RC_SUBR and SUB_FILES values
 - added some recomendation for simultaneous running openssh-portable and
   base sshd into pkg-message


diff -urN openssh-portable/Makefile.orig openssh-portable/Makefile
--- openssh-portable/Makefile.orig	2009-09-19 01:46:52.000000000 +0400
+++ openssh-portable/Makefile	2009-09-19 02:02:20.000000000 +0400
@@ -187,7 +187,8 @@
 EMPTYDIR=		/var/empty
 PREFIX=			/usr
 ETCSSH=			/etc/ssh
-USE_RC_SUBR=		openssh
+USE_RC_SUBR=	yes
+SUB_FILES+=		openssh
 PLIST_SUB+=		NOTBASE="@comment "
 PLIST_SUB+=		BASE=""
 PLIST_SUB+=		BASEPREFIX="${PREFIX}"
diff -urN openssh-portable/pkg-message.orig openssh-portable/pkg-message
--- openssh-portable/pkg-message.orig	2009-09-19 01:46:52.000000000 +0400
+++ openssh-portable/pkg-message	2009-09-19 02:08:16.000000000 +0400
@@ -1,6 +1,8 @@
 To enable this port, add openssh_enable="YES" in your rc.conf. To
 prevent conflict with openssh in the base system add sshd_enable="NO"
-in your rc.conf.
+in your rc.conf. Also you can configure openssh at another TCP port (via
+sshd_config 'Port' and 'Listen' options or via 'openssh_flags'
+variable in rc.conf) and run it in same time with base sshd.
 
 'PermitRootLogin no' is the default for the OpenSSH port.
 This now matches the PermitRootLogin configuration of OpenSSH in



-- 
Cheers
Denis Barov
Comment 4 Denis Barov 2009-09-22 19:16:08 UTC
sorry, previous message was sent from wrong address. Patch approved by me
(maintainer).

-- 
Cheers
Denis Barov
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2009-09-22 23:30:10 UTC
State Changed
From-To: feedback->open

Maintainer has supplied a patch.
Comment 6 Pav Lucistnik freebsd_committer freebsd_triage 2009-09-23 19:43:44 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2009-09-23 19:44:57 UTC
pav         2009-09-23 18:44:47 UTC

  FreeBSD ports repository

  Modified files:
    security/openssh-portable Makefile pkg-message 
  Log:
  - Revert USE_RC_SUBR change from last commit, it breaks OVERWRITE_BASE
  - Add a hint to pkg-message about running this together with base sshd
  
  PR:             ports/138943
  Submitted by:   Denis Barov <dindin@yandex-team.ru> (maintainer)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.141     +2 -1      ports/security/openssh-portable/Makefile
  1.4       +3 -1      ports/security/openssh-portable/pkg-message
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"