Bug 139361 - [FIX] net/ntop 3.3.10 don`t install needed file
Summary: [FIX] net/ntop 3.3.10 don`t install needed file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sylvio Cesar Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-05 07:10 UTC by viper
Modified: 2010-01-19 22:00 UTC (History)
0 users

See Also:


Attachments
file.diff (4.13 KB, patch)
2009-10-05 07:10 UTC, viper
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description viper 2009-10-05 07:10:01 UTC
ntop don`t install needed files.
1. Directory l7-patterns/
2. file etter.finger.os

ntop[79048]:   Initializing ntop
ntop[79048]:   Unable to read directory 'l7-patterns/'
....
ntop[79048]:   Fingerprint: Checking for Fingerprint file... file
ntop[79048]:   **WARNING** Fingerprint: Unable to open file 'etter.finger.os'

Fix: apply patch


Patch attached with submission follows:
How-To-Repeat: Install and run.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-10-05 07:10:10 UTC
Maintainer of net/ntop,

Please note that PR ports/139361 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/139361

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-10-05 07:10:12 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Sylvio César Teixeira Amorim 2009-10-06 14:50:10 UTC
Hi,

     I don't agree, fault with depends. I'll soon to send a patch.

Regards,

Sylvio Cesar



2009/10/5 Edwin Groothuis <edwin@freebsd.org>:
> Maintainer of net/ntop,
>
> Please note that PR ports/139361 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
> =A0 =A0http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/139361
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
>
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2009-10-06 18:45:09 UTC
State Changed
From-To: feedback->suspended

Maintainer will submit a different patch.
Comment 5 Sylvio César Teixeira Amorim 2009-10-07 14:42:11 UTC
>Submitter-Id:	current-users
>Originator:	Sylvio Cesar
>Organization:	
>Confidential:	no 
>Synopsis:	[PATCH] net/ntop: Re: ports/139361: [FIX] net/ntop 3.3.10 don`t install needed file 
>Severity:	non-critical
>Priority:	low
>Category:	ports 
>Class:		change-request
>Release:	FreeBSD 9.0-CURRENT i386
>Environment:
System: FreeBSD fbsd9i386.scjamorim.org 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Fri Oct  2 01:38:34 BRT
>Description:
- Added depends of wget
- Bump portrevision
- Changed pkg-plist

You can see the log in my tinderbox:

AMD64:
http://www.scjamorim.org/Home/ntop-3.3.10_1-6amd64.log
http://www.scjamorim.org/Home/ntop-3.3.10_1-7amd64.log
http://www.scjamorim.org/Home/ntop-3.3.10_1-8amd64.log
http://www.scjamorim.org/Home/ntop-3.3.10_1-9amd64.log

i386
http://www.scjamorim.org/Home/ntop-3.3.10_1-6i386.log
http://www.scjamorim.org/Home/ntop-3.3.10_1-7i386.log
http://www.scjamorim.org/Home/ntop-3.3.10_1-8i386.log
http://www.scjamorim.org/Home/ntop-3.3.10_1-9i386.log

Port maintainer (scjamorim@bsd.com.br) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- ntop-3.3.10_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/net/ntop/Makefile,v
retrieving revision 1.79
diff -u -u -r1.79 Makefile
--- Makefile	19 Sep 2009 16:48:26 -0000	1.79
+++ Makefile	7 Oct 2009 13:36:06 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	ntop
 PORTVERSION=	3.3.10
+PORTREVISION=	1
 CATEGORIES=	net
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTNAME}-${PORTVERSION}
 
@@ -14,10 +15,12 @@
 COMMENT=	Network monitoring tool with command line and web interfaces
 
 BUILD_DEPENDS=	rrdtool>=1.2:${PORTSDIR}/databases/rrdtool \
+		${LOCALBASE}/bin/wget:${PORTSDIR}/ftp/wget \
 		geoiplookup:${PORTSDIR}/net/GeoIP
 LIB_DEPENDS=	gdbm.3:${PORTSDIR}/databases/gdbm \
 		event-1.4:${PORTSDIR}/devel/libevent
 RUN_DEPENDS=	dot:${PORTSDIR}/graphics/graphviz \
+		${LOCALBASE}/bin/wget:${PORTSDIR}/ftp/wget \
 		${LOCALBASE}/lib/X11/fonts/URW/a010013l.afm:${PORTSDIR}/x11-fonts/urwfonts
 
 DBDIR?=		/var/db
@@ -92,8 +95,13 @@
 pre-configure:
 	@cd ${WRKSRC} && ${SETENV} ${SCRIPTS_ENV} ${SH} autogen.sh --noconfig
 
+pre-install:
+	@cd ${WRKSRC} && ${GMAKE} dnetter
+
 post-install:
 	@${MKDIR} ${DBDIR}/ntop
 	@${CHOWN} -R nobody:nobody ${DBDIR}/ntop
+	@${INSTALL} -d ${ETCDIR}/l7-patterns
+	@cd ${WRKSRC}/l7-patterns/&&${COPYTREE_SHARE} . ${ETCDIR}/l7-patterns
 
 .include <bsd.port.post.mk>
Index: pkg-plist
===================================================================
RCS file: /home/ncvs/ports/net/ntop/pkg-plist,v
retrieving revision 1.16
diff -u -u -r1.16 pkg-plist
--- pkg-plist	19 Sep 2009 16:48:26 -0000	1.16
+++ pkg-plist	7 Oct 2009 13:36:07 -0000
@@ -1,7 +1,96 @@
 bin/ntop
 etc/ntop/ntop-cert.pem
+etc/ntop/etter.finger.os.gz
 etc/ntop/oui.txt.gz
 etc/ntop/specialMAC.txt.gz
+etc/ntop/l7-patterns/100bao.pat
+etc/ntop/l7-patterns/aim.pat
+etc/ntop/l7-patterns/aimwebcontent.pat
+etc/ntop/l7-patterns/applejuice.pat
+etc/ntop/l7-patterns/ares.pat
+etc/ntop/l7-patterns/battlefield1942.pat
+etc/ntop/l7-patterns/battlefield2.pat
+etc/ntop/l7-patterns/bgp.pat
+etc/ntop/l7-patterns/biff.pat
+etc/ntop/l7-patterns/bittorrent.pat
+etc/ntop/l7-patterns/ciscovpn.pat
+etc/ntop/l7-patterns/citrix.pat
+etc/ntop/l7-patterns/counterstrike-source.pat
+etc/ntop/l7-patterns/cvs.pat
+etc/ntop/l7-patterns/dayofdefeat-source.pat
+etc/ntop/l7-patterns/dhcp.pat
+etc/ntop/l7-patterns/directconnect.pat
+etc/ntop/l7-patterns/dns.pat
+etc/ntop/l7-patterns/doom3.pat
+etc/ntop/l7-patterns/edonkey.pat
+etc/ntop/l7-patterns/fasttrack.pat
+etc/ntop/l7-patterns/finger.pat
+etc/ntop/l7-patterns/freenet.pat
+etc/ntop/l7-patterns/ftp.pat
+etc/ntop/l7-patterns/gkrellm.pat
+etc/ntop/l7-patterns/gnucleuslan.pat
+etc/ntop/l7-patterns/gnutella.pat
+etc/ntop/l7-patterns/goboogy.pat
+etc/ntop/l7-patterns/gopher.pat
+etc/ntop/l7-patterns/h323.pat
+etc/ntop/l7-patterns/halflife2-deathmatch.pat
+etc/ntop/l7-patterns/hddtemp.pat
+etc/ntop/l7-patterns/hotline.pat
+etc/ntop/l7-patterns/http.pat
+etc/ntop/l7-patterns/ident.pat
+etc/ntop/l7-patterns/imap.pat
+etc/ntop/l7-patterns/ipp.pat
+etc/ntop/l7-patterns/irc.pat
+etc/ntop/l7-patterns/jabber.pat
+etc/ntop/l7-patterns/kugoo.pat
+etc/ntop/l7-patterns/live365.pat
+etc/ntop/l7-patterns/lpd.pat
+etc/ntop/l7-patterns/msn-filetransfer.pat
+etc/ntop/l7-patterns/msnmessenger.pat
+etc/ntop/l7-patterns/mute.pat
+etc/ntop/l7-patterns/napster.pat
+etc/ntop/l7-patterns/nbns.pat
+etc/ntop/l7-patterns/ncp.pat
+etc/ntop/l7-patterns/netbios.pat
+etc/ntop/l7-patterns/nntp.pat
+etc/ntop/l7-patterns/ntp.pat
+etc/ntop/l7-patterns/openft.pat
+etc/ntop/l7-patterns/poco.pat
+etc/ntop/l7-patterns/pop3.pat
+etc/ntop/l7-patterns/pressplay.pat
+etc/ntop/l7-patterns/qq.pat
+etc/ntop/l7-patterns/quake-halflife.pat
+etc/ntop/l7-patterns/quake1.pat
+etc/ntop/l7-patterns/rdp.pat
+etc/ntop/l7-patterns/rlogin.pat
+etc/ntop/l7-patterns/rtsp.pat
+etc/ntop/l7-patterns/shoutcast.pat
+etc/ntop/l7-patterns/sip.pat
+etc/ntop/l7-patterns/skypeout.pat
+etc/ntop/l7-patterns/skypetoskype.pat
+etc/ntop/l7-patterns/smb.pat
+etc/ntop/l7-patterns/smtp.pat
+etc/ntop/l7-patterns/snmp.pat
+etc/ntop/l7-patterns/socks.pat
+etc/ntop/l7-patterns/soribada.pat
+etc/ntop/l7-patterns/soulseek.pat
+etc/ntop/l7-patterns/ssdp.pat
+etc/ntop/l7-patterns/ssh.pat
+etc/ntop/l7-patterns/ssl.pat
+etc/ntop/l7-patterns/subspace.pat
+etc/ntop/l7-patterns/telnet.pat
+etc/ntop/l7-patterns/tesla.pat
+etc/ntop/l7-patterns/tftp.pat
+etc/ntop/l7-patterns/tls.pat
+etc/ntop/l7-patterns/tsp.pat
+etc/ntop/l7-patterns/validcertssl.pat
+etc/ntop/l7-patterns/vnc.pat
+etc/ntop/l7-patterns/whois.pat
+etc/ntop/l7-patterns/x11.pat
+etc/ntop/l7-patterns/xboxlive.pat
+etc/ntop/l7-patterns/xunlei.pat
+etc/ntop/l7-patterns/yahoo.pat
+etc/ntop/l7-patterns/zmaap.pat
 lib/libcpacketPlugin-%%PORTVERSION%%.so
 lib/libcpacketPlugin.so
 lib/libicmpPlugin-%%PORTVERSION%%.so
@@ -419,6 +508,7 @@
 @dirrm %%DATADIR%%/html/statsicons
 @dirrm %%DATADIR%%/html
 @dirrm %%DATADIR%%
+@dirrm etc/ntop/l7-patterns
 @dirrm etc/ntop
 @dirrm lib/ntop/plugins
 @dirrm lib/ntop
--- ntop-3.3.10_1.patch ends here ---
Comment 6 Martin Wilke freebsd_committer freebsd_triage 2009-11-20 21:20:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sylvio

Over to maintainer.
Comment 7 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-01-15 23:14:05 UTC
State Changed
From-To: suspended->analyzed

I'll see this problem.
Comment 8 dfilter service freebsd_committer freebsd_triage 2010-01-19 21:57:57 UTC
sylvio      2010-01-19 21:57:44 UTC

  FreeBSD ports repository

  Modified files:
    net/ntop             Makefile pkg-plist 
  Added files:
    net/ntop/files       patch-ntop.c 
  Log:
  - Fix to install file etter.finger.os
  - Fix to problem with kevent
  
  PR:             ports/139361
  Submitted by:   Vladimir Korkodinov <viper@perm.raid.ru>
  Approved by:    itetcu (mentor)
  
  Revision  Changes    Path
  1.81      +8 -0      ports/net/ntop/Makefile
  1.1       +11 -0     ports/net/ntop/files/patch-ntop.c (new)
  1.17      +90 -0     ports/net/ntop/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-01-19 21:58:34 UTC
State Changed
From-To: analyzed->closed

Committed, with minor changes. Thanks!