On machine with private network IP address (192.168.1.xx) without DNS or entry in /etc/hosts mytop command shows following error message for each line containing hosts connected from unresolvable IP: Use of uninitialized value in substitution (s///) at /usr/local/bin/mytop line 998. It is old known problem. The fix can be found on other systems: http://groups.google.com/group/linux.debian.bugs.dist/browse_thread/thread/7ac750bd208e819a?pli=1 Fix: @@ -952,8 +955,11 @@ { $thread->{Host} =~ s/:\d+$//; my $host = gethostbyaddr(inet_aton($thread->{Host}), AF_INET); - $host =~ s/^([^.]+).*/$1/; - $thread->{Host} = $host; + if ($host) + { + $host =~ s/^([^.]+).*/$1/; + $thread->{Host} = $host; + } } Attached patch is reorganized original patch-mytop including fix above. Patch attached with submission follows: How-To-Repeat: Install and use mytop on machine with LAN clients without IP to hostname entry in DNS or /etc/hosts. For example machine with 192.168.1.2, run mytop, connect to configurred mysql server from client with IP 192.168.1.3 and mytop show: Use of uninitialized value in substitution (s///) at /usr/local/bin/mytop line 998.
Maintainer of databases/mytop, Please note that PR ports/139615 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/139615 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Edwin Groothuis wrote: > Maintainer of databases/mytop, > > Please note that PR ports/139615 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/139615 > Approved, and thanks. Cheers, Matthew -- Dr Matthew J Seaman MA, D.Phil. 7 Priory Courtyard Flat 3 PGP: http://www.infracaninophile.co.uk/pgpkey Ramsgate Kent, CT11 9PW
State Changed From-To: feedback->open Maintainer approved.
State Changed From-To: open->closed Committed, thanks!
pav 2009-10-26 15:56:07 UTC FreeBSD ports repository Modified files: databases/mytop Makefile databases/mytop/files patch-mytop Log: - Squelch perl warning triggered when a client is connected to the server and his IP cannot be resolved into a hostname PR: ports/139615 Submitted by: Miroslav Lachman <000.fbsd@quip.cz> Approved by: Matthew Seaman <m.seaman@infracaninophile.co.uk> (maintainer) Revision Changes Path 1.22 +1 -1 ports/databases/mytop/Makefile 1.8 +44 -32 ports/databases/mytop/files/patch-mytop _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"