Bug 140662 - audio/squeezeboxserver: Changes in p5-Class-XSAccessor-1.05,1 break squeezeboxserver
Summary: audio/squeezeboxserver: Changes in p5-Class-XSAccessor-1.05,1 break squeezebo...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Brooks Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-18 13:30 UTC by Christopher Key
Modified: 2009-12-03 02:58 UTC (History)
0 users

See Also:


Attachments
patch-class-xsaccessor-1.05 (1.14 KB, text/plain)
2009-11-18 13:30 UTC, Christopher Key
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Key 2009-11-18 13:30:01 UTC
	SqueezeboxServer server makes use of Class::XSAccessor::Array if version >= 1.04 is found.  Recently, p5-Class-XSAccessor was updated to 1.05,1, meaning that SqueezeboxServer now attempts to use it.  However, the internals have changed between versions 1.04 and 1.05, which breaks squeezeboxserver.  The attached patch detects which version of Class::XSAccessor is used, and proceeds appropriately.  It is possibly overkill, as version 1.04 has never been available via the ports tree, and thus assuming 1.05 semantics would probably be safe.  However, some people may have version 1.04 installed from somewhere else, e.g. direct from CPAN, so probably best to be safe.

How-To-Repeat: 	Update to p5-Class-XSAccessor-1.05,1, then attempt to start squeezeboxserver
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2009-11-18 18:45:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->brooks

Over to maintainer of audio/squeezeboxserver.
Comment 2 dfilter service freebsd_committer freebsd_triage 2009-12-03 01:28:19 UTC
brooks      2009-12-03 01:28:10 UTC

  FreeBSD ports repository

  Modified files:
    audio/squeezeboxserver Makefile 
  Added files:
    audio/squeezeboxserver/files patch-Slim_Utils_Accessor.pm 
  Log:
  p5-Class-XSAccessor-Array has been merged into p5-Class-XSAccessor.
  Remove a dependency on the former package so it can be removed and patch
  the use of an internal function which broke in the latest version.
  
  PR:             ports/140662, ports/141106
  Submitted by:   Cezary Morga <cm at therek net>
                  Christopher Key <cjk32 at cam ac uk>
  Prodded by:     many :)
  Pointy hat to:  brooks
  
  Revision  Changes    Path
  1.65      +2 -2      ports/audio/squeezeboxserver/Makefile
  1.1       +43 -0     ports/audio/squeezeboxserver/files/patch-Slim_Utils_Accessor.pm (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Brooks Davis freebsd_committer freebsd_triage 2009-12-03 02:57:51 UTC
State Changed
From-To: open->closed

Committed.  Thanks for the submittion!