Bug 140829 - www/tomcat55 rc.d script is broken and will not stop tomcat process
Summary: www/tomcat55 rc.d script is broken and will not stop tomcat process
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stefan Walter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-24 13:50 UTC by ruben
Modified: 2010-08-21 15:40 UTC (History)
1 user (show)

See Also:


Attachments
tomcat55.diff (860 bytes, patch)
2009-11-24 13:50 UTC, ruben
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ruben 2009-11-24 13:50:00 UTC
	Due to various jvms in FreeBSD /usr/local/bin/java is a symlink to the configured one. tomcat55's rc.d script does not take that into account for the stop action and thus will not terminate/restart tomcat55.
	The attached patch corrects this misbehaviour

How-To-Repeat: 	/usr/local/etc/rc.d/tomcat55 stop will complain the process is not running, even if it is.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-11-24 13:50:14 UTC
Maintainer of www/tomcat55,

Please note that PR ports/140829 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/140829

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-11-24 13:50:15 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Philip M. Gollucci freebsd_committer freebsd_triage 2010-01-18 07:26:49 UTC
ping....
Comment 4 Stefan Walter freebsd_committer freebsd_triage 2010-05-06 21:07:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->stefan

Take.
Comment 5 Stefan Walter freebsd_committer freebsd_triage 2010-05-06 21:11:42 UTC
State Changed
From-To: feedback->closed

Committed, thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2010-05-06 21:11:50 UTC
stefan      2010-05-06 20:11:33 UTC

  FreeBSD ports repository

  Modified files:
    www/tomcat55         Makefile 
    www/tomcat55/files   tomcat55.sh.in 
  Log:
  Fix stopping the server process via the port's rc.d script.
  
  PR:             ports/140829
  Submitted by:   Ruben van Staveren <ruben@verweg.com>
  Approved by:    maintainer timeout (>5 months)
  
  Revision  Changes    Path
  1.49      +1 -0      ports/www/tomcat55/Makefile
  1.9       +2 -2      ports/www/tomcat55/files/tomcat55.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Kazuo Dohzono 2010-08-21 15:37:45 UTC
I'm running www/tomcat55 on java/jdk16, FreeBSD 8.1-RELEASE.

> -    procname=`ps -o ucomm= -p $rc_pid`
> +    procname=`ps -o command= -p $rc_pid | cut -f 1 -d ' '`

This change doesn't fit in my environment ("ucomm=" works fine).

"ps -o ucomm=" provides "java"
"ps -o command=" provides "[java]"