Bug 141002 - [PATCH] games/bsdgames: Convert pre-install to pre-su-install
Summary: [PATCH] games/bsdgames: Convert pre-install to pre-su-install
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Greg Lewis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-29 20:40 UTC by Greg Lewis
Modified: 2009-11-30 14:10 UTC (History)
1 user (show)

See Also:


Attachments
bsdgames-2.4_1,1.patch (493 bytes, patch)
2009-11-29 20:40 UTC, Greg Lewis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Lewis 2009-11-29 20:40:02 UTC
The pre-install target creates directories under /var/games (by default).
Doing so requires root privileges, so the pre-install target should be
pre-su-install instead to ensure these privileges are available.

Port maintainer (uqs@spoerlein.net) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-11-29 20:40:09 UTC
Maintainer of games/bsdgames,

Please note that PR ports/141002 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/141002

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-11-29 20:40:13 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Greg Lewis freebsd_committer freebsd_triage 2009-11-29 20:44:41 UTC
Responsible Changed
From-To: freebsd-ports-bugs->glewis

I'll take it.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2009-11-30 08:26:27 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Mark Linimon 2009-11-30 08:27:04 UTC
----- Forwarded message from Ulrich Spörlein <uqs@spoerlein.net> -----

From: Ulrich Spörlein <uqs@spoerlein.net>
To: glewis@FreeBSD.org
Mail-Followup-To: Ulrich Spörlein <uqs@spoerlein.net>, glewis@FreeBSD.org,
	freebsd-ports-bugs@FreeBSD.org
Cc: freebsd-ports-bugs@FreeBSD.org
Subject: Re: ports/141002: [PATCH] games/bsdgames: Convert pre-install to
	pre-su-install

Thanks Greg!

Patch is approved, I didn't even know pre-install was running non-su :(

Cheers,
Uli
_______________________________________________
freebsd-ports-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"


----- End forwarded message -----
Comment 6 Greg Lewis freebsd_committer freebsd_triage 2009-11-30 14:01:50 UTC
State Changed
From-To: open->closed

Thanks Ulrich!  I've committed the change.
Comment 7 dfilter service freebsd_committer freebsd_triage 2009-11-30 14:05:39 UTC
glewis      2009-11-30 14:01:04 UTC

  FreeBSD ports repository

  Modified files:
    games/bsdgames       Makefile 
  Log:
  . pre-install -> pre-su-install since it creates directories in /var/games.
  
  PR:             141002
  Approved by:    Ulrich Spoerlein (maintainer)
  
  Revision  Changes    Path
  1.25      +1 -1      ports/games/bsdgames/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"