Bug 141170 - Add more configuration options to audio/audacity-devel and clean up patches
Summary: Add more configuration options to audio/audacity-devel and clean up patches
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-04 16:40 UTC by xxjack12xx
Modified: 2009-12-17 06:10 UTC (History)
0 users

See Also:

Attachments
file.diff (3.62 KB, patch)
2009-12-04 16:40 UTC, xxjack12xx 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description xxjack12xx 2009-12-04 16:40:01 UTC 
- Add new configuration options for audacity
- Alphabetize option listing
- Fix unicode support
- Cleanup "trailing garbage" and typos in patches
- Add debug option

Fix: Apply attached patch

Patch attached with submission follows:
How-To-Repeat: Apply attached patch
Comment 1 Jack 2009-12-04 16:44:57 UTC 
Made a typo, my email is actually xxjack12xx@gmail.com

I also forgot to add the PORTREVISION=3D1

On Fri, Dec 4, 2009 at 8:33 AM, Jack Low <xxjack12xx@gmai..com> wrote:
>
>>Number: =C2=A0 =C2=A0 =C2=A0 =C2=A0 141170
>>Category: =C2=A0 =C2=A0 =C2=A0 ports
>>Synopsis: =C2=A0 =C2=A0 =C2=A0 Add more configuration options to audacity=
-devel and clean up patches
>>Confidential: =C2=A0 no
>>Severity: =C2=A0 =C2=A0 =C2=A0 non-critical
>>Priority: =C2=A0 =C2=A0 =C2=A0 low
>>Responsible: =C2=A0 =C2=A0freebsd-ports-bugs
>>State: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0open
>>Quarter:
>>Keywords:
>>Date-Required:
>>Class: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0maintainer-update
>>Submitter-Id: =C2=A0 current-users
>>Arrival-Date: =C2=A0 Fri Dec 04 16:40:01 UTC 2009
>>Closed-Date:
>>Last-Modified:
>>Originator: =C2=A0 =C2=A0 Jack Low
>>Release: =C2=A0 =C2=A0 =C2=A0 =C2=A08.0
>>Organization:
> PRDHost
>>Environment:
> FreeBSD upstairs.jack.com 8.0-STABLE FreeBSD 8.0-STABLE #0 r199898: Sun N=
ov 29 03:43:47 PST 2009 =C2=A0 =C2=A0 jack@upstairs.jack.com:/usr/obj/usr/s=
rc/sys/UPSTAIRS =C2=A0amd64
>
>>Description:
> - Add new configuration options for audacity
> - Alphabetize option listing
> - Fix unicode support
> - Cleanup "trailing garbage" and typos in patches
> - Add debug option
>>How-To-Repeat:
> Apply attached patch
>>Fix:
> Apply attached patch
>
> >
> diff -ur audacity-devel/Makefile audacity-new/Makefile
> --- audacity-devel/Makefile =C2=A0 =C2=A0 2009-12-04 02:00:11.000000000 -=
0800
> +++ audacity-new/Makefile =C2=A0 =C2=A0 =C2=A0 2009-12-04 08:17:18.000000=
000 -0800
> @@ -29,23 +29,29 @@
> =C2=A0USE_GETTEXT=3D =C2=A0 yes
> =C2=A0USE_BZIP2=3D =C2=A0 =C2=A0 yes
> =C2=A0USE_WX=3D =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A02.=
8
> -MAKE_JOBS_SAFE=3D =C2=A0 =C2=A0 =C2=A0 =C2=A0yes
> =C2=A0WX_COMPS=3D =C2=A0 =C2=A0 =C2=A0wx
> +MAKE_JOBS_SAFE=3D =C2=A0 =C2=A0 =C2=A0 =C2=A0yes
> =C2=A0PORTDOCS=3D =C2=A0 =C2=A0 =C2=A0README.txt LICENSE.txt
> -
> =C2=A0MAN1=3D =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0audacity.1
> =C2=A0MANCOMPRESSED=3D yes
>
> -OPTIONS=3D =C2=A0 =C2=A0 =C2=A0 VORBIS =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0"Use libvorbis for Ogg Vorbis support" =C2=A0on \
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 MAD =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 "Use libmad for mp2/3 decoding support" on \
> +OPTIONS=3D =C2=A0 =C2=A0 =C2=A0 DEBUG =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 "enable debug support" off \
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 FFMPEG =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0"Use ffmpeg for import and export support" on \
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0FLAC =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0"Use libFLAC for FLAC support" on \
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ID3TAG =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0"Use libid3tag for mp3 id3 tag support" on \
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 LADSPA =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0"enable LADSPA plug-in support" on \
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 MAD =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 "Use libmad for mp2/3 decoding support" on \
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 MIDI =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0"Use portSMF for Midi support" on \
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 NYQUIST =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 "enable Nyquist plug-in support" on \
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 PORTMIXER =C2=A0 =C2=
=A0 =C2=A0 "compile with PortMixer" on \
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0SAMPLERATE =C2=A0 =
=C2=A0 =C2=A0"Use libresample for sample rate conversion" on \
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0SBSMS =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 "Use libsbsms for pitch and tempo changing" on \
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0SOUNDTOUCH =C2=A0 =
=C2=A0 =C2=A0"Use libSoundTouch for pitch and tempo changing" on\
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 TAGLIB =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0"use TagLib for metadata support" on \
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0TWOLAME =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 "Use libtwolame for MP2 export support" on \
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 FFMPEG =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0"Use ffmpeg for import and export support" on \
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 MIDI =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0"Use portSMF for Midi support" on
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 UNICODE =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 "enable unicode support" on \
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 VORBIS =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0"Use libvorbis for Ogg Vorbis support" =C2=A0on \
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 VAMP =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0"use libvamp for Vamp plug-in support" on
>
> =C2=A0.include <bsd.port.pre.mk>
>
> @@ -63,14 +69,12 @@
> =C2=A0MAKE_ENV=3D =C2=A0 =C2=A0 =C2=A0DOC=3Dyes
> =C2=A0.endif
>
> -CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --enable-unicode=3Dno
> -
> -.if defined(WITH_VORBIS)
> -CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-libvorbis
> +.if defined(WITH_DEBUG)
> +CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-debug
> =C2=A0.endif
>
> -.if defined(WITH_MAD)
> -CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-libmad
> +.if defined(WITH_FFMPEG)
> +CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-ffmpeg
> =C2=A0.endif
>
> =C2=A0.if defined(WITH_FLAC)
> @@ -81,6 +85,26 @@
> =C2=A0CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-libid3tag
> =C2=A0.endif
>
> +.if defined(WITH_LADSPA)
> +CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-ladspa
> +.endif
> +
> +.if defined(WITH_MAD)
> +CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-libmad
> +.endif
> +
> +.if defined(WITH_MIDI)
> +CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-midi
> +.endif
> +
> +.if defined(WITH_NYQUIST)
> +CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-nyquist
> +.endif
> +
> +.if defined(WITH_PORTMIXER)
> +CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-portmixer
> +.endif
> +
> =C2=A0.if defined(WITH_SAMPLERATE)
> =C2=A0CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-libresample
> =C2=A0.endif
> @@ -97,12 +121,21 @@
> =C2=A0CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-libtwolame
> =C2=A0.endif
>
> -.if defined(WITH_FFMPEG)
> -CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-ffmpeg
> +.if defined(WITH_TAGLIB)
> +CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-taglib
> =C2=A0.endif
>
> -.if defined(WITH_MIDI)
> -CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-midi
> +.if defined(WITH_UNICODE)
> +WX_UNICODE=3D =C2=A0 =C2=A0yes
> +CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --enable-unicode
> +.endif
> +
> +.if defined(WITH_VAMP)
> +CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-libvamp
> +.endif
> +
> +.if defined(WITH_VORBIS)
> +CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-libvorbis
> =C2=A0.endif
>
> =C2=A0.include <bsd.port.post.mk>
> diff -ur audacity-devel/files/patch-cext.h audacity-new/files/patch-cext.=
h
> --- audacity-devel/files/patch-cext.h =C2=A0 2009-10-16 05:11:24.00000000=
0 -0700
> +++ audacity-new/files/patch-cext.h =C2=A0 =C2=A0 2009-12-04 07:20:02.000=
000000 -0800
> @@ -1,5 +1,5 @@
> =C2=A0--- lib-src/libnyquist/nyquist/cmt/cext.h =C2=A0 =C2=A0 =C2=A0 2009=
-07-15 20:27:36.000000000 -0700
> -+++ lib-src/libnyquist/nyquist/cmt/cext.hcext.h 2009-07-19 00:37:45.0000=
00000 -0700
> ++++ lib-src/libnyquist/nyquist/cmt/cext.h =C2=A0 =C2=A0 =C2=A0 2009-07-1=
9 00:37:45.000000000 -0700
>
> =C2=A0@@ -58,7 +58,7 @@
> =C2=A0#include <malloc.h>
> diff -ur audacity-devel/files/patch-xlisp.h audacity-new/files/patch-xlis=
p.h
> --- audacity-devel/files/patch-xlisp.h =C2=A02009-10-16 05:11:24.00000000=
0 -0700
> +++ audacity-new/files/patch-xlisp.h =C2=A0 =C2=A02009-12-04 08:23:52.000=
000000 -0800
> @@ -16,4 +16,3 @@
> =C2=A0/* Apple CC */
> =C2=A0#ifdef __APPLE__
> =C2=A0#define NNODES 2000
> -
>
>
>>Release-Note:
>>Audit-Trail:
>>Unformatted:
> _______________________________________________
> freebsd-ports-bugs@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
> To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.=
org"
>
Comment 2 Wen Heping freebsd_committer freebsd_triage 2009-12-05 04:41:47 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wen

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2009-12-17 06:09:13 UTC 
wen         2009-12-17 06:09:04 UTC

  FreeBSD ports repository

  Modified files:
    audio/audacity-devel Makefile 
    audio/audacity-devel/files patch-cext.h patch-xlisp.h 
  Log:
  - Add more configuration options
  - Clean up patches
  
  PR:             ports/141170
  Submitted by:   Jack Low <xxjack12xx@gmai..com> (maintainer)
  
  Revision  Changes    Path
  1.40      +50 -16    ports/audio/audacity-devel/Makefile
  1.2       +1 -1      ports/audio/audacity-devel/files/patch-cext.h
  1.2       +0 -1      ports/audio/audacity-devel/files/patch-xlisp.h
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Wen Heping freebsd_committer freebsd_triage 2009-12-17 06:10:25 UTC 
State Changed
From-To: open->closed

Committed. Thanks!