Bug 141347 - graphics/poppler: Fix of usage USE_QT= macro
Summary: graphics/poppler: Fix of usage USE_QT= macro
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-10 15:50 UTC by Dima Panov
Modified: 2009-12-20 10:50 UTC (History)
0 users

See Also:


Attachments
poppler.diff (733 bytes, patch)
2009-12-10 15:50 UTC, Dima Panov
no flags Details | Diff
poppler.diff (546 bytes, patch)
2009-12-19 20:34 UTC, Max Brazhnikov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Panov freebsd_committer freebsd_triage 2009-12-10 15:50:05 UTC

graphics/poppler: Fix of usage USE_QT= macro.

Current state of port is incorrect. 
Optional USE_QT should be decrared before including of bsd.port.pre.mk but after bsd.port.options.mk
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-12-10 15:50:22 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2009-12-19 14:57:02 UTC
State Changed
From-To: open->feedback

What is the problem here? First, the port doesn't use USE_QT, but USE_QT_VER. 
Second, slave ports have no OPTIONS. Does this port needs any of the variables 
defined in PRE-section of bsd.qt.mk? 


Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2009-12-19 14:57:02 UTC
Responsible Changed
From-To: gnome->pav

What is the problem here? First, the port doesn't use USE_QT, but USE_QT_VER. 
Second, slave ports have no OPTIONS. Does this port needs any of the variables 
defined in PRE-section of bsd.qt.mk?
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2009-12-19 20:27:16 UTC
State Changed
From-To: feedback->open

Simpler patch from makc@
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2009-12-19 20:27:16 UTC
Responsible Changed
From-To: pav->gnome

Simpler patch from makc@ 

http://makc.homeunix.net/kde4/patches/poppler.diff
Comment 6 Max Brazhnikov freebsd_committer freebsd_triage 2009-12-19 20:34:52 UTC
This patch resolves the issue.
Comment 7 Koop Mast freebsd_committer freebsd_triage 2009-12-20 00:58:35 UTC
This patch got another issue, with it. It resets CPPFLAGS. Working on a
patch to fix this.

-Koop
Comment 8 dfilter service freebsd_committer freebsd_triage 2009-12-20 10:43:28 UTC
kwm         2009-12-20 10:43:14 UTC

  FreeBSD ports repository

  Modified files:
    graphics/poppler     Makefile 
  Log:
  Fix usage of USE_QT* macros. So depends are detected correctly.
  
  PR:             ports/141347
  Submitted by:   Dima Panov <fluffy@FreeBSD.org> (based on patch by makc@)
  
  Revision  Changes    Path
  1.54      +5 -2      ports/graphics/poppler/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Koop Mast freebsd_committer freebsd_triage 2009-12-20 10:43:36 UTC
State Changed
From-To: open->closed

Committed, with a build fix. Thanks!