emulators/virtualbox(3.0.51.r22902_3) has an option called "PULSEAUDIO". I validate it and did build, but pulseaudio support does not become effective. I can choose only OSS or Null by the Audio setting of the virtual machine even if I start GUI of VirtualBox. It is similar in VBoxManage. Only in the case of Linux, it seems to become effective. Fix: attach a patch. Patch attached with submission follows: How-To-Repeat: 1. install emulators/virtualbox with "PULSEAUDIO=on" 2. run VirutalBox 3. create VM 4. open audio setting screen
Responsible Changed From-To: freebsd-ports-bugs->vbox Fix synopsis and assign.
Thanks for the patch! I've modified it a little bit so that it applies on virtualbox 3.1.2 and commited it to our testing repository. [1] Nightly packages of the port are also available if you want to try it and we will do a call for testers with the new vbox 3.1.2 port very soon. [2] I will submit the patches upstream to the virtualbox developers to get them included if you agree to that. But they only can include patches that are under the MIT License or if you sign a Sun Contributors Agreement as stated in their wiki [3]. So could you please reply if you agree that your patches are under the MIT License or if you want to sign a Sun Contributors Agreement so that i can send your patches upstream? Thanks! -- Bernhard Fröhlich http://www.bluelife.at/ [1] https://svn.bluelife.at/index.cgi/blueports/revision/?rev=595 [2] http://svn.bluelife.at/nightlies/virtualbox-port.tar.gz [3] http://www.virtualbox.org/wiki/Contributor_information#Howtosubmityourcontributions
Thank you Bernhard. I will try your port of test repository. Of course I agree that they include it under MIT License. Regards. Noriyoshi Kawano At Mon, 21 Dec 2009 16:57:20 +0100 (CET), Bernhard Froehlich wrote: > > Thanks for the patch! I've modified it a little bit so that it applies on > virtualbox 3.1.2 and commited it to our testing repository. [1] Nightly > packages of the port are also available if you want to try it and we will > do a call for testers with the new vbox 3.1.2 port very soon. [2] > > I will submit the patches upstream to the virtualbox developers to get > them included if you agree to that. But they only can include patches that > are under the MIT License or if you sign a Sun Contributors Agreement as > stated in their wiki [3]. So could you please reply if you agree that your > patches are under the MIT License or if you want to sign a Sun > Contributors Agreement so that i can send your patches upstream? > > Thanks! > > -- > Bernhard Fr$(D+S(Bhlich > http://www.bluelife.at/ > > [1] https://svn.bluelife.at/index.cgi/blueports/revision/?rev=595 > [2] http://svn.bluelife.at/nightlies/virtualbox-port.tar.gz > [3] > http://www.virtualbox.org/wiki/Contributor_information#Howtosubmityourcontributions >
Hi, Bernhard. I tried rev.595 and rev.599, but I got build failure. files/patch-src-VBox-Devices-Makefile.kmk is incomplete.
On Tue, December 22, 2009 6:15 am, Noriyoshi Kawano wrote: > Hi, Bernhard. > > I tried rev.595 and rev.599, but I got build failure. > files/patch-src-VBox-Devices-Makefile.kmk is incomplete. > > --- patch-src-VBox-Devices-Makefile.kmk.orig 2009-12-22 14:00:46.000000000 > +0900 > +++ patch-src-VBox-Devices-Makefile.kmk 2009-12-22 14:02:18.000000000 > +0900 > @@ -1,10 +1,11 @@ > --- src/VBox/Devices/Makefile.kmk.orig 2009-12-17 15:27:43.000000000 > +0100 > +++ src/VBox/Devices/Makefile.kmk 2009-12-21 14:29:56.000000000 +0100 > -@@ -970,6 +970,9 @@ > +@@ -970,6 +970,10 @@ > Drivers_SOURCES.linux+= \ > Audio/pulseaudio.c \ > Audio/pulse_stubs.c > + Drivers_DEFS.freebsd += VBOX_WITH_PULSE > ++ Drivers_SOURCES.freebsd+= \ > + Audio/pulseaudio.c \ > + Audio/pulse_stubs.c > endif > Thanks for the hint. It should be fixed now but strange that it has build fine in my tinderbox. >> >> Thank you Bernhard. >> >> I will try your port of test repository. >> Of course I agree that they include it under MIT License. >> Thanks. I will send the patches as soon as we get some feedback from users. -- Bernhard Fröhlich http://www.bluelife.at/
beat 2010-01-13 08:03:17 UTC FreeBSD ports repository Modified files: . UPDATING MOVED emulators Makefile emulators/virtualbox-ose Makefile distinfo pkg-message pkg-plist emulators/virtualbox-ose/files patch-configure patch-src-VBox-Devices-Makefile.kmk emulators/virtualbox-ose-kmod Makefile distinfo pkg-plist emulators/virtualbox-ose-kmod/files patch-src-VBox-HostDrivers-VBoxNetFlt-freebsd-VBoxNetFlt-freebsd.c Added files: emulators/virtualbox-ose/files patch-src-VBox-Additions-x11-VBoxClient-Makefile.kmk patch-src-VBox-Devices-Audio-audio.c patch-src-VBox-Frontends-VBoxManage-VBoxManageHelp.cpp patch-src-VBox-Frontends-VBoxManage-VBoxManageModifyVM.cpp patch-src-VBox-HostDrivers-Makefile.kmk patch-src-VBox-HostDrivers-Support-SUPR3HardenedMain.cpp patch-src-VBox-Installer-Makefile.kmk patch-src-VBox-Main-AudioAdapterImpl.cpp patch-src-VBox-Main-ConsoleImpl.cpp patch-src-VBox-Main-ConsoleImpl2.cpp patch-src-VBox-Main-include-ConsoleImpl.h patch-src-VBox-Runtime-VBox-log-vbox.cpp patch-src-VBox-Runtime-r3-freebsd-rtProcInitExePath-freebsd.cpp patch-src-settings-vm-VBoxVMSettingsAudio.cpp emulators/virtualbox-ose-kmod/files vboxnet.in Removed files: emulators/virtualbox Makefile distinfo pkg-descr pkg-message pkg-plist emulators/virtualbox/files patch-Config.kmk patch-configure patch-src-VBox-Devices-Makefile.kmk patch-src-VBox-Frontends-VBoxManage-VBoxInternalManage.cpp patch-src-VBox-HostDrivers-VBoxNetAdp-freebsd-VBoxNetAdp-freebsd.c patch-src-VBox-HostDrivers-VBoxNetFlt-VBoxNetFltInternal.h patch-src-VBox-HostDrivers-VBoxNetFlt-freebsd-VBoxNetFlt-freebsd.c patch-src-VBox-Runtime-r0drv-freebsd-spinlock-r0drv-freebsd.c patch-src-VBox-Runtime-r0drv-freebsd-the-freebsd-kernel.h patch-src-VBox-apps-adpctl_VBoxNetAdpCtl.cpp pkg-install.in emulators/virtualbox-ose/files patch-src-VBox-HostDrivers-VBoxNetAdp-freebsd-VBoxNetAdp-freebsd.c patch-src-VBox-HostDrivers-VBoxNetFlt-VBoxNetFltInternal.h patch-src-VBox-HostDrivers-VBoxNetFlt-freebsd-VBoxNetFlt-freebsd.c patch-src-VBox-Runtime-r0drv-freebsd-spinlock-r0drv-freebsd.c patch-src-VBox-Runtime-r0drv-freebsd-the-freebsd-kernel.h patch-src-VBox-apps-adpctl_VBoxNetAdpCtl.cpp emulators/virtualbox-ose-kmod pkg-message emulators/virtualbox-ose-kmod/files patch-Config.kmk patch-configure patch-src-VBox-Devices-Makefile.kmk patch-src-VBox-Frontends-VBoxManage-VBoxInternalManage.cpp patch-src-VBox-HostDrivers-VBoxNetFlt-VBoxNetFltInternal.h patch-src-VBox-Runtime-r0drv-freebsd-the-freebsd-kernel.h patch-src-VBox-apps-adpctl_VBoxNetAdpCtl.cpp pkg-install.in Log: emulators/virtualbox: - Remove emulators/virtualbox port. Renamed to emulators/virtualbox-ose and seperate port for the kernel modules created: emulators/virtualbox-ose-kmod. emulators/virtualbox-ose: - Update to 3.1.2 - Update guest additions to 3.1.2 - Port has been renamed to virtualbox-ose to reflect that we are using the OSE version. [1] - Added proper PulseAudio support for FreeBSD [2] - procfs is not required anymore because vbox uses sysctl(3) now [3] - Update pkg-message to reflect recent changes - Add nox's FreeBSD host networking patches that are now also in the upstream vbox svn (modulo vbox variable naming style adjustments:) http://lists.freebsd.org/pipermail/freebsd-emulation/2010-January/007260.html http://www.virtualbox.org/changeset/25698 1. Allow direct tap networking again (for users that need the best network performance and/or need more complex network setups, like when they want to use routing instead of bridging to e.g. protect from guests messing with the lan's arp tables; a tap + routing + proxy arp example is in the above freebsd-emulation posting.) 2. Enable vbox' shared mac feature when using bridged mode on a wifi interface, together with the virtualbox-ose-kmod change this should fix bridged mode for wifi users. [4] emulators/virtualbox-ose-kmod: - Update to 3.1.2 - Add rc.d script to load kernel modules - Fix build with a non-standard location for the system source [5] - Merge aeichner's vboxnetflt fix committed to upstream vbox svn (thanks!) that makes the shared mac feature enabled above actually work on FreeBSD hosts. [6] Please see http://wiki.freebsd.org/VirtualBox for update instructions. Many thanks to the VirtualBox developers, all tester, patch submitter and the whole vbox@ team. PR: ports/141630 [2] Noticed by: mm@ [1] Submitted by: Noriyoshi Kawano <bowie AT nrik.jp> [2], Baptiste Daroussin <baptiste.daroussin AT gmail.com> [3] and Bernhard Froehlich <decke AT bluelife.at> [3], nox@ [4], scf@ [5] Obtained from: http://www.virtualbox.org/changeset/25699 [6] On behalf of: vbox@ (decke, dhn, itetcu, miwi, nox) Revision Changes Path 1.2073 +2 -1 ports/MOVED 1.882 +11 -1 ports/UPDATING 1.281 +2 -1 ports/emulators/Makefile 1.15 +35 -197 ports/emulators/virtualbox-ose-kmod/Makefile 1.7 +3 -6 ports/emulators/virtualbox-ose-kmod/distinfo 1.5 +0 -10 ports/emulators/virtualbox-ose-kmod/files/patch-Config.kmk (dead) 1.4 +0 -20 ports/emulators/virtualbox-ose-kmod/files/patch-configure (dead) 1.3 +0 -15 ports/emulators/virtualbox-ose-kmod/files/patch-src-VBox-Devices-Makefile.kmk (dead) 1.3 +0 -50 ports/emulators/virtualbox-ose-kmod/files/patch-src-VBox-Frontends-VBoxManage-VBoxInternalManage.cpp (dead) 1.4 +0 -28 ports/emulators/virtualbox-ose-kmod/files/patch-src-VBox-HostDrivers-VBoxNetFlt-VBoxNetFltInternal.h (dead) 1.4 +9 -371 ports/emulators/virtualbox-ose-kmod/files/patch-src-VBox-HostDrivers-VBoxNetFlt-freebsd-VBoxNetFlt-freebsd.c 1.3 +0 -11 ports/emulators/virtualbox-ose-kmod/files/patch-src-VBox-Runtime-r0drv-freebsd-the-freebsd-kernel.h (dead) 1.3 +0 -207 ports/emulators/virtualbox-ose-kmod/files/patch-src-VBox-apps-adpctl_VBoxNetAdpCtl.cpp (dead) 1.3 +0 -22 ports/emulators/virtualbox-ose-kmod/files/pkg-install.in (dead) 1.1 +71 -0 ports/emulators/virtualbox-ose-kmod/files/vboxnet.in (new) 1.5 +0 -26 ports/emulators/virtualbox-ose-kmod/pkg-message (dead) 1.10 +1 -595 ports/emulators/virtualbox-ose-kmod/pkg-plist 1.15 +15 -22 ports/emulators/virtualbox-ose/Makefile 1.7 +6 -6 ports/emulators/virtualbox-ose/distinfo 1.4 +51 -5 ports/emulators/virtualbox-ose/files/patch-configure 1.1 +20 -0 ports/emulators/virtualbox-ose/files/patch-src-VBox-Additions-x11-VBoxClient-Makefile.kmk (new) 1.1 +14 -0 ports/emulators/virtualbox-ose/files/patch-src-VBox-Devices-Audio-audio.c (new) 1.3 +12 -14 ports/emulators/virtualbox-ose/files/patch-src-VBox-Devices-Makefile.kmk 1.1 +37 -0 ports/emulators/virtualbox-ose/files/patch-src-VBox-Frontends-VBoxManage-VBoxManageHelp.cpp (new) 1.1 +23 -0 ports/emulators/virtualbox-ose/files/patch-src-VBox-Frontends-VBoxManage-VBoxManageModifyVM.cpp (new) 1.1 +27 -0 ports/emulators/virtualbox-ose/files/patch-src-VBox-HostDrivers-Makefile.kmk (new) 1.1 +33 -0 ports/emulators/virtualbox-ose/files/patch-src-VBox-HostDrivers-Support-SUPR3HardenedMain.cpp (new) 1.3 +0 -11 ports/emulators/virtualbox-ose/files/patch-src-VBox-HostDrivers-VBoxNetAdp-freebsd-VBoxNetAdp-freebsd.c (dead) 1.4 +0 -28 ports/emulators/virtualbox-ose/files/patch-src-VBox-HostDrivers-VBoxNetFlt-VBoxNetFltInternal.h (dead) 1.4 +0 -384 ports/emulators/virtualbox-ose/files/patch-src-VBox-HostDrivers-VBoxNetFlt-freebsd-VBoxNetFlt-freebsd.c (dead) 1.1 +15 -0 ports/emulators/virtualbox-ose/files/patch-src-VBox-Installer-Makefile.kmk (new) 1.1 +14 -0 ports/emulators/virtualbox-ose/files/patch-src-VBox-Main-AudioAdapterImpl.cpp (new) 1.1 +11 -0 ports/emulators/virtualbox-ose/files/patch-src-VBox-Main-ConsoleImpl.cpp (new) 1.1 +103 -0 ports/emulators/virtualbox-ose/files/patch-src-VBox-Main-ConsoleImpl2.cpp (new) 1.1 +20 -0 ports/emulators/virtualbox-ose/files/patch-src-VBox-Main-include-ConsoleImpl.h (new) 1.1 +82 -0 ports/emulators/virtualbox-ose/files/patch-src-VBox-Runtime-VBox-log-vbox.cpp (new) 1.3 +0 -14 ports/emulators/virtualbox-ose/files/patch-src-VBox-Runtime-r0drv-freebsd-spinlock-r0drv-freebsd.c (dead) 1.3 +0 -11 ports/emulators/virtualbox-ose/files/patch-src-VBox-Runtime-r0drv-freebsd-the-freebsd-kernel.h (dead) 1.1 +81 -0 ports/emulators/virtualbox-ose/files/patch-src-VBox-Runtime-r3-freebsd-rtProcInitExePath-freebsd.cpp (new) 1.3 +0 -207 ports/emulators/virtualbox-ose/files/patch-src-VBox-apps-adpctl_VBoxNetAdpCtl.cpp (dead) 1.1 +12 -0 ports/emulators/virtualbox-ose/files/patch-src-settings-vm-VBoxVMSettingsAudio.cpp (new) 1.5 +6 -5 ports/emulators/virtualbox-ose/pkg-message 1.10 +7 -4 ports/emulators/virtualbox-ose/pkg-plist 1.14 +0 -259 ports/emulators/virtualbox/Makefile (dead) 1.6 +0 -6 ports/emulators/virtualbox/distinfo (dead) 1.4 +0 -10 ports/emulators/virtualbox/files/patch-Config.kmk (dead) 1.3 +0 -20 ports/emulators/virtualbox/files/patch-configure (dead) 1.2 +0 -15 ports/emulators/virtualbox/files/patch-src-VBox-Devices-Makefile.kmk (dead) 1.2 +0 -50 ports/emulators/virtualbox/files/patch-src-VBox-Frontends-VBoxManage-VBoxInternalManage.cpp (dead) 1.2 +0 -11 ports/emulators/virtualbox/files/patch-src-VBox-HostDrivers-VBoxNetAdp-freebsd-VBoxNetAdp-freebsd.c (dead) 1.3 +0 -28 ports/emulators/virtualbox/files/patch-src-VBox-HostDrivers-VBoxNetFlt-VBoxNetFltInternal.h (dead) 1.3 +0 -384 ports/emulators/virtualbox/files/patch-src-VBox-HostDrivers-VBoxNetFlt-freebsd-VBoxNetFlt-freebsd.c (dead) 1.2 +0 -14 ports/emulators/virtualbox/files/patch-src-VBox-Runtime-r0drv-freebsd-spinlock-r0drv-freebsd.c (dead) 1.2 +0 -11 ports/emulators/virtualbox/files/patch-src-VBox-Runtime-r0drv-freebsd-the-freebsd-kernel.h (dead) 1.2 +0 -207 ports/emulators/virtualbox/files/patch-src-VBox-apps-adpctl_VBoxNetAdpCtl.cpp (dead) 1.2 +0 -22 ports/emulators/virtualbox/files/pkg-install.in (dead) 1.2 +0 -7 ports/emulators/virtualbox/pkg-descr (dead) 1.4 +0 -26 ports/emulators/virtualbox/pkg-message (dead) 1.9 +0 -599 ports/emulators/virtualbox/pkg-plist (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks! decke will send the patch upstream soon.
Thanks, patch was finally send upstream. Also thanks to beat@ and Marius Nuennerich <marius at nuenneri.ch> for testing and confirming that the patch works. http://vbox.innotek.de/pipermail/vbox-dev/2010-January/002231.html -- Bernhard Fröhlich http://www.bluelife.at/