Bug 141670 - comms/lrzsz doesn't check filename when Xmodem receive
Summary: comms/lrzsz doesn't check filename when Xmodem receive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-16 05:50 UTC by maya
Modified: 2010-01-15 06:13 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description maya 2009-12-16 05:50:01 UTC 
lrz.c seems not check filename from commandline arguments when command is rx.

When receive a file with xmodem, rx requires a filename for save. It is written in man.
> rx [- abceqRtuUv] file

I guess it is a problem of original release.

Fix: 

http://ttssh2.sourceforge.jp/patch/lrzsz-rxfliename.patch
How-To-Repeat: lrx
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2009-12-16 07:26:30 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

Fix synopsis and assign.
Comment 2 takefu 2010-01-14 06:37:38 UTC 
diff -rubN /usr/ports/comms/lrzsz/Makefile ./Makefile
--- /usr/ports/comms/lrzsz/Makefile	2006-08-08 20:36:11.000000000 +0900
+++ ./Makefile	2010-01-14 15:27:22.000000000 +0900
@@ -12,6 +12,9 @@
 MASTER_SITES=	http://www.netsw.org/net/modem/protocols/zmodem/lrzsz/ \
 		http://www.ohse.de/uwe/releases/

+PATCH_SITES=	http://ttssh2.sourceforge.jp/patch/
+PATCHFILES=	${PORTNAME}-rxfliename.patch
+
 MAINTAINER=	dinoex@FreeBSD.org
 COMMENT=	Receive/Send files via X/Y/ZMODEM protocol.  (unrestrictive)

diff -rubN /usr/ports/comms/lrzsz/distinfo ./distinfo
--- /usr/ports/comms/lrzsz/distinfo	2005-11-13 18:26:33.000000000 +0900
+++ ./distinfo	2010-01-14 15:23:29.000000000 +0900
@@ -1,3 +1,6 @@
 MD5 (lrzsz-0.12.20.tar.gz) = b5ce6a74abc9b9eb2af94dffdfd372a4
 SHA256 (lrzsz-0.12.20.tar.gz) = c28b36b14bddb014d9e9c97c52459852f97bd405f89113f30bee45ed92728ff1
 SIZE (lrzsz-0.12.20.tar.gz) = 280938
+MD5 (lrzsz-rxfliename.patch) = 135aa82bae35109b325a90b105d3bca6
+SHA256 (lrzsz-rxfliename.patch) = 60db0620fb294a58913f7266c09ec27fde4560c74ad9782f1213f49cf19c7b72
+SIZE (lrzsz-rxfliename.patch) = 409
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-01-14 08:37:27 UTC 
dinoex      2010-01-14 08:37:19 UTC

  FreeBSD ports repository

  Modified files:
    comms/lrzsz          Makefile 
  Added files:
    comms/lrzsz/files    patch-lrz.c 
  Removed files:
    comms/lrzsz/files    patch-src::lrz.c 
  Log:
  - fix rx filename
  PR:             141670
  Obtained from:  http://ttssh2.sourceforge.jp/patch/lrzsz-rxfliename.patch
  
  Revision  Changes    Path
  1.27      +1 -1      ports/comms/lrzsz/Makefile
  1.1       +24 -0     ports/comms/lrzsz/files/patch-lrz.c (new)
  1.2       +0 -15     ports/comms/lrzsz/files/patch-src::lrz.c (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Dirk Meyer freebsd_committer freebsd_triage 2010-01-14 22:35:55 UTC 
State Changed
From-To: open->closed

committed, thanks.
Comment 5 maya 2010-01-15 00:29:11 UTC 
Thank you for handle this PR.

I created a patch for only this issue.
The patch for PR49999 (removed patch-src::lrz.c)
is still needed.

I'm not understanding file naming rule of patch in `files' dir,
please include both fixes.

Thanks,
Comment 6 Dirk Meyer freebsd_committer freebsd_triage 2010-01-15 06:11:00 UTC 
State Changed
From-To: closed->open

- feedback received
Comment 7 Dirk Meyer freebsd_committer freebsd_triage 2010-01-15 06:11:23 UTC 
State Changed
From-To: open->closed

Thanks, files/patch-lrz.c already contains both patches.