Bug 142110 - [PATCH] lang/perl5.10 / BSDPAN-5.10.1_20090303: P5PORTER mode update
Summary: [PATCH] lang/perl5.10 / BSDPAN-5.10.1_20090303: P5PORTER mode update
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: skv
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-28 21:20 UTC by alex.deiter
Modified: 2010-05-06 18:10 UTC (History)
0 users

See Also:

Attachments
file.diff (2.18 KB, patch)
2009-12-28 21:20 UTC, alex.deiter 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description alex.deiter 2009-12-28 21:20:02 UTC 
Please review patch for lang/perl5.10 and BSDPAN-5.10.1_20090303: P5PORTER mode update:

1. handling man1 and man3 correctly
2. cut $PREFIX from bin files
3. creates a list of dependencies, using the names and versions of packages:

BUILD_DEPENDS=  p5-Algorithm-Diff>=1.1901:${PORTSDIR}/devel/p5-Algorithm-Diff \
                p5-Algorithm-Merge>=0:${PORTSDIR}/devel/p5-Algorithm-Merge

instead of:

BUILD_DEPENDS=  {SITE_PERL}/IO/String.pm:${PORTSDIR}/devel/p5-IO-String \
                ${SITE_PERL}/Text/EtText.pm:${PORTSDIR}/textproc/p5-Text-EtText


Example Makefile.skeleton:

# New ports collection makefile for:	XXX/p5-[% portname %]
# Date created:				[% today %]
# Whom:					Alex Deiter <Alex.Deiter@Gmail.COM>
#
# $FreeBSD$
#
 
PORTNAME=	[% portname %]
PORTVERSION=	[% portversion %]
CATEGORIES=	XXX perl5
MASTER_SITES=	${MASTER_SITE_PERL_CPAN}
MASTER_SITE_SUBDIR=	[% subdir %]
PKGNAMEPREFIX=	p5-
 
MAINTAINER=	Alex.Deiter@Gmail.COM
COMMENT=	[% comment %]
 
[% IF has_dependencies %]BUILD_DEPENDS=	[% freebsd_dependencies %]
RUN_DEPENDS=	${BUILD_DEPENDS}
[% END %]

PERL_CONFIGURE=	yes
 
[% IF has_man1 %]MAN1=	[% man1 %]
[% END %]

[% IF has_man3 %]MAN3=	[% man3 %]
[% END %]
 
.include <bsd.port.mk>

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-12-28 21:20:17 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->skv

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2010-05-06 18:06:00 UTC 
skv         2010-05-06 17:05:45 UTC

  FreeBSD ports repository

  Modified files:
    lang/perl5.10        Makefile distinfo 
  Added files:
    lang/perl5.10/files  patch-bug69973 patch-bug71952 
  Log:
  - Add patches for RT 69973 [1], RT 71952 [2]
  - Update P5PORTER mode [3]
  - Update CONFLICTS for Perl 5.12
  
  Pointed by:     a.smith xx ukgrid.net [1]
  PR:             ports/144717 [2], ports/142110 [3]
  Submitted by:   Bryan Fullerton <bryanf@samuraiconsulting.ca> [2],
                  Alex Deiter <alex.deiter xx gmail.com> [3]
  
  Revision  Changes    Path
  1.117     +2 -1      ports/lang/perl5.10/Makefile
  1.30      +3 -3      ports/lang/perl5.10/distinfo
  1.1       +95 -0     ports/lang/perl5.10/files/patch-bug69973 (new)
  1.1       +46 -0     ports/lang/perl5.10/files/patch-bug71952 (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 skv freebsd_committer freebsd_triage 2010-05-06 18:06:26 UTC 
State Changed
From-To: open->closed

Fixed, thanks.