Bug 142193 - sysutils/system-tools-backends: fix for creating user accounts with Gnome
Summary: sysutils/system-tools-backends: fix for creating user accounts with Gnome
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-31 02:40 UTC by Larry P. Maloney
Modified: 2010-01-11 00:10 UTC (History)
0 users

See Also:


Attachments
file.txt (23.81 KB, text/plain)
2009-12-31 02:40 UTC, Larry P. Maloney
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Larry P. Maloney 2009-12-31 02:40:01 UTC
Up until now, system-tools-backends couldn't create user accounts on
FreeBSD.  STB is used by the tool "Users and Groups" within gnome.

I have updated the file in STB called Users.pm to enable user account
creation.

I've tested it for several months, and it works fine for me.

(Additional testing would be nice)

Fix: Had to write several fixes, the comments are in the file Users.pm

One of the keys, is that in FreeBSD there are nulls in some of the fields
for the user accounts in /etc/passwd.

Those nulls had to be replaced with something, such as "nologin"

Users.PM adds that.

Note:  The submitted file is named Users.pm.txt (my browser wouldn't
submit the filename correctly)  Users.pm.txt needs to be renamed to
Users.pm and it should go into:

 /usr/local/share/system-tools-backends-2.0/scripts/Users/Users.pm

Patch attached with submission follows:
How-To-Repeat: 1.) Launch gnome in FreeBSD
2.) Login with a privileged user, such as root.
3.) Once gnome is launched, select the top menu item "System"
4.) Then select the menu item "Administration"
5.) Then "Users and Groups"
6.) Try to create a user
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-12-31 06:41:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome-ports-bugs

Over to people who can made a wise descission about this PR.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2009-12-31 16:55:08 UTC
Responsible Changed
From-To: gnome-ports-bugs->gnome

Fix synopsis and assignment.
Comment 3 Jeremy Messenger 2009-12-31 21:43:34 UTC
Awsome, finally, someone did it! :-) You can see here:  
http://www.freebsd.org/gnome/docs/volunteer.html .. If you want to do more  
stuff in the system-tools-backends will be cool and very welcome. This  
weekend, I (or one of us) am going to check your file and create a patch  
for I can put it in system-tools-backends/files/, then bump and commit it.  
Thanks!


Next time, when you submit patch. It's best to send a patch that was  
created by diff(1). In case if you don't know how to do, here's example:

# cd /usr/ports/sysutils/system-tools-backends
# make extract
# cd work/system-tools-backends-2.8.3
# cp Users/Users.pm Users/Users.pm.orig
<edit the Users/Users.pm and save it>
# diff -ur Users/Users.pm.orig Users/Users.pm > patch-Users_Users.pm

Then attach the patch-Users_Users.pm to PR.

Cheers,
Mezz


-- 
mezz7@cox.net  -  mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/  -  gnome@FreeBSD.org
Comment 4 Joe Marcus Clarke freebsd_committer freebsd_triage 2010-01-11 00:06:13 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-01-11 00:06:20 UTC
marcus      2010-01-11 00:06:06 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/system-tools-backends Makefile 
    sysutils/system-tools-backends/files patch-Users_Users.pm 
  Log:
  Revamp the Users module to make it work on FreeBSD.  A big thanks to
  Larry for taking up this TODO item.
  
  PR:             142193
  Submitted by:   "Larry P. Maloney" <larry@kiputers.com>
  
  Revision  Changes    Path
  1.26      +1 -0      ports/sysutils/system-tools-backends/Makefile
  1.3       +333 -14   ports/sysutils/system-tools-backends/files/patch-Users_Users.pm
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"