Bug 143787 - Please add 3th party module to www/nginx
Summary: Please add 3th party module to www/nginx
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sergey A. Osokin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-11 06:30 UTC by landy2005
Modified: 2010-02-27 22:20 UTC (History)
0 users

See Also:


Attachments
nginx_accept_language.patch (1.75 KB, patch)
2010-02-11 10:20 UTC, landy2005
no flags Details | Diff
nginx-devel_accept_language.patch (1.75 KB, patch)
2010-02-11 10:20 UTC, landy2005
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description landy2005 2010-02-11 06:30:01 UTC
Please add 3th party module: http://wiki.nginx.org/NginxAcceptLanguageModule
to nginx (and nginx-devel)
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2010-02-11 06:32:53 UTC
Responsible Changed
From-To: freebsd-ports-bugs->osa

Fix synopsis and assign.
Comment 2 Sergey A. Osokin freebsd_committer freebsd_triage 2010-02-11 07:53:17 UTC
State Changed
From-To: open->analyzed

Could you please provide patches. 
Thank you.
Comment 3 landy2005 2010-02-11 10:20:39 UTC
See patches here: ftp://inside01.p8.ru/nginx/
or in attachment.

May be placed file qq somewhere else?

-- 
Mike Stupalov
Comment 4 landy2005 2010-02-11 12:49:23 UTC
One more patch, for module "Headers more" v0.07:
http://wiki.nginx.org/NginxHttpHeadersMoreModule

Link to patch: ftp://inside01.p8.ru/nginx/nginx_headers_more.patch

-- 
Mike Stupalov
Comment 5 Sergey A. Osokin freebsd_committer freebsd_triage 2010-02-18 19:16:50 UTC
State Changed
From-To: analyzed->closed

I'll committed your changes for accept_language module. 
Thank you for report. 

About another headers_mode module: 
could you please: 
1. repack original tarball with removing uppercase; 
2. put it on your side; 
3. create new patch; 
4. submit new PR. 

Thank you.
Comment 6 dfilter service freebsd_committer freebsd_triage 2010-02-18 19:16:59 UTC
osa         2010-02-18 19:16:13 UTC

  FreeBSD ports repository

  Modified files:
    www/nginx            Makefile distinfo 
    www/nginx-devel      Makefile distinfo 
  Log:
  Accordingly add third party module accept language.
  
  Do not bump PORTREVISIONs.
  
  Feature safe:   yes
  
  Submitted by:   Mike Stupalov aka landy2005 at gmail dot com
  PR:             ports/143787
  
  Revision  Changes    Path
  1.290     +7 -0      ports/www/nginx-devel/Makefile
  1.253     +3 -0      ports/www/nginx-devel/distinfo
  1.194     +7 -0      ports/www/nginx/Makefile
  1.167     +3 -0      ports/www/nginx/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 mauzo 2010-02-25 22:52:00 UTC
>Submitter-Id:	current-users
>Originator:	Ben Morrow
>Confidential:	no 
>Synopsis:	Re: ports/143787, specifically headers_more
>Severity:	non-critical
>Priority:	low
>Category:	ports
>Class:		change-request
>Release:	FreeBSD 7.1-RELEASE-p8 i386
>Environment:
System: FreeBSD osiris.mauzo.dyndns.org 7.1-RELEASE-p8 FreeBSD 7.1-RELEASE-p8 #8: Sat Oct 3 16:52:10 BST 2009 root@osiris.mauzo.dyndns.org:/usr/obj/usr/src/sys/OSIRIS i386
>Description:
I was about to submit a PR asking for the headers_more module, but then
I found ports/143787. 

What is the problem with the tarball? Is it the Perl modules in the
test/ directory with uppercase names? I don't see how they can be a
problem, given that they aren't used at all during build, but if
necessary I could easily put up a tarball somewhere else without them.

Is a github tarball, with that rather strange name, considered OK? (It
would be easiest for me to clone the repo on github and send a patch
with a tarball from the new repo.)

Ben
Comment 8 Sergey A. Osokin freebsd_committer freebsd_triage 2010-02-26 13:31:12 UTC
On Thu, Feb 25, 2010 at 11:30:03PM +0000, Ben Morrow wrote:
> The following reply was made to PR ports/143787; it has been noted by GNATS.
> 
> From: Ben Morrow <mauzo@osiris.mauzo.dyndns.org>
> To: FreeBSD-gnats-submit@freebsd.org
> Cc: Mike Stupalov <landy2005@gmail.com>
> Subject: Re: ports/143787, specifically headers_more
> Date: 25 Feb 2010 22:52:00 -0000
> 
>  >Submitter-Id:	current-users
>  >Originator:	Ben Morrow
>  >Confidential:	no 
>  >Synopsis:	Re: ports/143787, specifically headers_more
>  >Severity:	non-critical
>  >Priority:	low
>  >Category:	ports
>  >Class:		change-request
>  >Release:	FreeBSD 7.1-RELEASE-p8 i386
>  >Environment:
>  System: FreeBSD osiris.mauzo.dyndns.org 7.1-RELEASE-p8 FreeBSD 7.1-RELEASE-p8 #8: Sat Oct 3 16:52:10 BST 2009 root@osiris.mauzo.dyndns.org:/usr/obj/usr/src/sys/OSIRIS i386
>  >Description:
>  I was about to submit a PR asking for the headers_more module, but then
>  I found ports/143787. 
>  
>  What is the problem with the tarball?

The problem is the "wrong" name of tarball:
agentzh-headers-more-nginx-module-db9913e.tar.gz

Best name for tarball is ngx_headers_more_module-0.07.tar.gz.

>  Is it the Perl modules in the test/ directory with uppercase names?

No.

>  I don't see how they can be a
>  problem, given that they aren't used at all during build, but if
>  necessary I could easily put up a tarball somewhere else without them.

Just do it.

>  Is a github tarball, with that rather strange name, considered OK? (It
>  would be easiest for me to clone the repo on github and send a patch
>  with a tarball from the new repo.)

You can find solution in my answer in ports/143787.
Comment 9 Ben Morrow 2010-02-27 21:46:28 UTC
I see you've already done it. Thank you.

Ben