Bug 144066 - Upgrade net/asterisk16-addons to 1.6.2.0
Summary: Upgrade net/asterisk16-addons to 1.6.2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: TAKATSU Tomonari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-18 16:40 UTC by Tom Judge
Modified: 2010-09-29 16:14 UTC (History)
0 users

See Also:


Attachments
file.diff (1.54 KB, patch)
2010-02-18 16:40 UTC, Tom Judge
no flags Details | Diff
asterisk16-addons-1.6.2.1.diff (3.89 KB, patch)
2010-09-21 19:52 UTC, Florian Smeets
no flags Details | Diff
asterisk16-addons-1.6.2.2.diff (3.89 KB, patch)
2010-09-24 23:21 UTC, Florian Smeets
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Judge 2010-02-18 16:40:01 UTC
Upgrade asterisk16-addons to 1.6.2.0

Fix: Patch attached

Patch attached with submission follows:
How-To-Repeat: NA
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-02-18 16:41:22 UTC
Maintainer of net/asterisk16-addons,

Please note that PR ports/144066 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/144066

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-02-18 16:41:24 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Florian Smeets 2010-02-18 17:27:51 UTC
Hi,

AFAIK asterisk-addons and asterisk versions need to match except for the 
digit(s) after the last dot of the version string.

e.g. asterisk-addons-1.6.0.x needs asterisk 1.6.0.x , 
asterisk-addons-1.6.2.x needs asterisk-1.6.2.x.

Therefor this patch has to wait at least till Maxim commits asterisk 
1.6.2.x to the ports tree. But i do not know how his plans are.

I had a version of the addons for 1.6.1.x ready (ports/134112), but it's 
still suspended as we are still using asterisk 1.6.0.x, which is 
absolutely no problem for me!

Nevertheless i tried your patch on a box with asterisk16-1.6.0.21 
installed and it did not compile.

So right now i cannot approve this request. Thanks for your interest, 
though!

Cheers,
Florian
Comment 4 Tom Judge 2010-02-18 20:13:41 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Please see ports/144065 asterisk16 1.6.2.2

TJ

Florian Smeets wrote:
> Hi,
> 
> AFAIK asterisk-addons and asterisk versions need to match except for the
> digit(s) after the last dot of the version string.
> 
> e.g. asterisk-addons-1.6.0.x needs asterisk 1.6.0.x ,
> asterisk-addons-1.6.2.x needs asterisk-1.6.2.x.
> 
> Therefor this patch has to wait at least till Maxim commits asterisk
> 1.6.2.x to the ports tree. But i do not know how his plans are.
> 
> I had a version of the addons for 1.6.1.x ready (ports/134112), but it's
> still suspended as we are still using asterisk 1.6.0.x, which is
> absolutely no problem for me!
> 
> Nevertheless i tried your patch on a box with asterisk16-1.6.0.21
> installed and it did not compile.
> 
> So right now i cannot approve this request. Thanks for your interest,
> though!
> 
> Cheers,
> Florian


- --
Senior Network Architect
Mintel International Ltd.
DDI: +1 312 450 6245
TJU13-ARIN
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJLfZ91AAoJEKU1sSj5I0+TgYgH+gJKnxzARex0kgZL22Cw1v5v
8x/ZjQarZ2x3dIpFHgC32gAPTqvrOSZQicOWkcA1nVKQ78K7efi8B23WIUx3fu+l
4HlpceH3corOmoy+ReHVw4SFxiSjIj3BPZTSzJk6AhK/qBtpbSrZ1NiQIhYyoggC
phqbQRHFHIUzlqKX4ncg27T/5jn6yqWf6dsm4ASPO50RTKJuNfO6eeTci06WXbIR
Mq8YhKEkyiNE1OWYyj8Y8+p7va+VCod1e34Wc4I4+h+/+b2o2dEYSOl7EVunSQpU
7y/OkoQsoeY71B04g0xUE22s02Q/eJQlvp3ZBDJhogqNBxNGSDpg1opFaF1U8F0=
=fPmn
-----END PGP SIGNATURE-----
http://www.mintel.com
providing insight + impact

Follow Mintel on Twitter: http://twitter.com/mintelnews

Please consider the environment before printing this email.

Mintel International
London Office:
------------------
Mintel International Group Ltd (Mintel)
18-19 Long Lane
London EC1A 9PL
UK
Registered in England: Number 1475918.
VAT Number: GB 232 9342 72
Tel: +44 (0) 20 7606 4533
Fax: +44 (o) 20 7606 5932
E-mail: info@mintel.com

London - Chicago - Sydney - Shanghai - Tokyo - Belfast -- More contact details at http://www.mintel.com/contactus.htm.

Notice
------------------
This email may contain information that is privileged, confidential or otherwise protected from disclosure. It must not be used by, or its contents copied or disclosed to, persons other than the addressee. If you have received this email in error please notify the sender immediately and delete the email. Any views or opinions expressed in this message are solely those of the author, and do not necessarily reflect those of Mintel.

No Mintel staff are authorised to make purchases using email or over the internet, and any contracts so performed are invalid.

Warning
------------------
It is the responsibility of the recipient to ensure that the onward transmission, opening or use of this message and any attachments will not adversely affect their systems or data. Please carry out such virus and other checks, as you consider appropriate.
Comment 5 Florian Smeets 2010-02-19 09:23:43 UTC
On 2/18/10 9:13 PM, Tom Judge wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Please see ports/144065 asterisk16 1.6.2.2
>
> TJ

Hi,

oh sorry i did not see that. I tested the patch from ports/144065 + this 
one. It seems to work fine, so when asterisk is updated to 1.6.2.x this 
patch can also be committed.

Thanks,
Florian

>
> Florian Smeets wrote:
>> Hi,
>>
>> AFAIK asterisk-addons and asterisk versions need to match except for the
>> digit(s) after the last dot of the version string.
>>
>> e.g. asterisk-addons-1.6.0.x needs asterisk 1.6.0.x ,
>> asterisk-addons-1.6.2.x needs asterisk-1.6.2.x.
>>
>> Therefor this patch has to wait at least till Maxim commits asterisk
>> 1.6.2.x to the ports tree. But i do not know how his plans are.
>>
>> I had a version of the addons for 1.6.1.x ready (ports/134112), but it's
>> still suspended as we are still using asterisk 1.6.0.x, which is
>> absolutely no problem for me!
>>
>> Nevertheless i tried your patch on a box with asterisk16-1.6.0.21
>> installed and it did not compile.
>>
>> So right now i cannot approve this request. Thanks for your interest,
>> though!
>>
>> Cheers,
>> Florian
>
Comment 6 Philip M. Gollucci freebsd_committer freebsd_triage 2010-09-09 06:28:47 UTC
State Changed
From-To: feedback->open

Feedback received
Comment 7 Florian Smeets 2010-09-21 19:52:33 UTC
Hi,

here is an updated patch for 1.6.2.1

Cheers,
Florian
Comment 8 Florian Smeets 2010-09-24 23:21:56 UTC
Here is the update to 1.6.2.2.

Cheers,
Florian
Comment 9 TAKATSU Tomonari freebsd_committer freebsd_triage 2010-09-29 15:23:40 UTC
Responsible Changed
From-To: freebsd-ports-bugs->tota

I'll take it.
Comment 10 dfilter service freebsd_committer freebsd_triage 2010-09-29 15:39:38 UTC
tota        2010-09-29 14:39:32 UTC

  FreeBSD ports repository

  Modified files:
    net/asterisk16-addons Makefile distinfo pkg-plist 
    net/asterisk16-addons/files patch-Makefile 
  Log:
  - Upgrade to 1.6.2.2, partially based on [2]
  - Make portlint happier
  
  PR:     ports/144066 [1]
  Submitted by:   Tom Judge <tjudge_AT_mintel_DOT_com> [1]
  Patched by:     Florian Smeets (maintainer) [2]
  
  Revision  Changes    Path
  1.24      +4 -4      ports/net/asterisk16-addons/Makefile
  1.10      +3 -3      ports/net/asterisk16-addons/distinfo
  1.6       +26 -3     ports/net/asterisk16-addons/files/patch-Makefile
  1.3       +6 -2      ports/net/asterisk16-addons/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 11 TAKATSU Tomonari freebsd_committer freebsd_triage 2010-09-29 16:07:39 UTC
State Changed
From-To: open->closed

Committed. Thanks!