New port for picsnvideos, which is a plugin for palm/jpilot to download photos and videos from Palm smartphones. Note: I'm not sure about the naming; portlint warns about using a hyphen in PORTNAME, but port should probably be named jpilot-picsnvideos (like jpilot-db). Please advise.
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it.
* Sascha Klauder (sklauder@trimind.de) wrote: > New port for picsnvideos, which is a plugin for palm/jpilot > to download photos and videos from Palm smartphones. > > Note: I'm not sure about the naming; portlint warns about > using a hyphen in PORTNAME, but port should probably be > named jpilot-picsnvideos (like jpilot-db). Please advise. The port directory should be named jpilot-picsnvideos, PORTNAME and PKGNAMEPREFIX should be left as is. Also, > XCATEGORIES= palm may also add comms and/or graphics. > XMASTER_SITES= SF/project/picsnvideos/source%20code/${PORTVERSION}/ should be SF/${PORTNAME}/source%20code/${PORTVERSION} > XBUILD_DEPENDS= jpilot:${PORTSDIR}/palm/jpilot since this port is a plugin, there should also be a run dependency on host > X.include <bsd.port.pre.mk> not really needed, last line should be .include <bsd.port.mk> > XPlugin for JPilot (jpilot.org) to download pictures, photos and videos from > XPalm smartphones. Supports: Centro, Treo 600, Treo 650, Treo 680, Treo 700p, > XTreo 755p & xplor m68. no WWW: ? -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
State Changed From-To: open->feedback Awaiting submitters feedback
Hello Dmitry, I have incorporated all your suggested changes. Revised port is attached. Thank you for your time and advice. Cheers, -sascha
* Sascha Klauder (sklauder@trimind.de) wrote: > I have incorporated all your suggested changes. Revised port is > attached. Thank you for your time and advice. This looks fine. The only change I'll add if you don't mind: +post-patch: + @${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' \ + ${WRKSRC}/configure Without it, it fails with custom LOCALBASE: http://people.freebsd.org/~amdmi3/jpilot-picsnvideos-0.2.log -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
On Thu, Mar 18, 2010 at 04:38:25AM +0300, Dmitry Marakasov wrote: > This looks fine. The only change I'll add if you don't mind: > > +post-patch: > + @${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' \ > + ${WRKSRC}/configure Alright with me. I'll have to remember checking for this. Cheers, -sascha
State Changed From-To: feedback->closed New port added, with minor changes. Thanks!
amdmi3 2010-03-18 18:03:13 UTC FreeBSD ports repository Modified files: palm Makefile Added files: palm/jpilot-picsnvideos Makefile distinfo pkg-descr Log: Plugin for JPilot (jpilot.org) to download pictures, photos and videos from Palm smartphones. Supports: Centro, Treo 600, Treo 650, Treo 680, Treo 700p, Treo 755p & xplor m68. WWW: http://sourceforge.net/projects/picsnvideos/ PR: 144083 Submitted by: Sascha Klauder <sklauder@trimind.de> Revision Changes Path 1.79 +1 -0 ports/palm/Makefile 1.1 +41 -0 ports/palm/jpilot-picsnvideos/Makefile (new) 1.1 +3 -0 ports/palm/jpilot-picsnvideos/distinfo (new) 1.1 +5 -0 ports/palm/jpilot-picsnvideos/pkg-descr (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"