Bug 144208 - [PATCH] misc/help2man Fix plist
Summary: [PATCH] misc/help2man Fix plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sylvio Cesar Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-22 12:00 UTC by Robert Farmer
Modified: 2010-03-08 22:20 UTC (History)
0 users

See Also:


Attachments
file.diff (471 bytes, patch)
2010-02-22 12:00 UTC, Robert Farmer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Farmer 2010-02-22 12:00:13 UTC
In my tinderbox I get a leftover file from this port:

=== Checking filesystem state after all packages deleted
================================================================
list of extra files and directories in / (not present on clean system but present after everything was deinstalled)
 17077        8 -r-xr-xr-x    1 root             wheel                4004 Feb 22 11:20 usr/local/lib/bindtextdomain.so
================================================================
build of /usr/ports/misc/help2man ended at Mon Feb 22 11:20:28 UTC 2010

Fix: Edit plist (attached)

Patch attached with submission follows:
Comment 1 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-02-22 23:40:06 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sylvio

I'll take it.
Comment 2 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-02-24 23:19:10 UTC
Hi,

I not found this error in my tinderbox (6,7,8 and 9), both arch (i386 =
and=20
amd64). The port , to be installed, have not dependencies of lib =
bindtextdomain.=20
Not errors installing with and without NOPORTS*.

Regards,

Sylvio Cesar=
Comment 3 Robert Farmer 2010-02-25 16:14:09 UTC
On Wed, Feb 24, 2010 at 3:19 PM, Sylvio Cesar Teixeira
<sylvio@freebsd.org> wrote:
> Hi,
>
> I not found this error in my tinderbox (6,7,8 and 9), both arch (i386 and
> amd64). The port , to be installed, have not dependencies of lib bindtextdomain.
> Not errors installing with and without NOPORTS*.

The only non-standard thing I am doing is using GCC 4.4. However, I
don't think that should make a difference in what is/isn't built and
installed. Makefile.in installs bindtextdomain on line 57. I don't
know why you are not seeing this in your setup... Here's a complete
log from my tinderbox:
http://www.predatorlabs.net/dl/help2man-1.37.1.log

>
> Regards,
>
> Sylvio Cesar



-- 
Rob Farmer
Comment 4 Sylvio César Teixeira Amorim 2010-02-26 12:15:27 UTC
Part of your log with "gcc44"

checking whether gcc44 accepts -g... yes
checking for gcc44 option to accept ISO C89... none needed
checking for library containing dlsym... none required
checking for library containing bindtextdomain... -lintl
checking for a BSD-compatible install... /usr/bin/install -c -o root -g whe=
el

My log with "gcc42"

checking whether cc accepts -g... yes
checking for cc option to accept ISO C89... none needed
checking for library containing dlsym... none required
checking for library containing bindtextdomain... no
checking for a BSD-compatible install... /usr/bin/install -c -o root -g whe=
el

Seems that the "checking for library containing bindtextdomain...
-lintl" is present when build with gcc44, because all my jails has
gcc42, end have not "bindtextdomain... lintl".

The port build and work well with gcc42 and I can not force it to
gcc44 only to add bindtextdomain in plist.

Regards,

Sylvio Cesar.



2010/2/25 Rob Farmer <rfarmer@predatorlabs.net>:
> On Wed, Feb 24, 2010 at 3:19 PM, Sylvio Cesar Teixeira
> <sylvio@freebsd.org> wrote:
>> Hi,
>>
>> I not found this error in my tinderbox (6,7,8 and 9), both arch (i386 an=
d
>> amd64). The port , to be installed, have not dependencies of lib bindtex=
tdomain.
>> Not errors installing with and without NOPORTS*.
>
> The only non-standard thing I am doing is using GCC 4.4. However, I
> don't think that should make a difference in what is/isn't built and
> installed. Makefile.in installs bindtextdomain on line 57. I don't
> know why you are not seeing this in your setup... Here's a complete
> log from my tinderbox:
> http://www.predatorlabs.net/dl/help2man-1.37.1.log
>
>>
>> Regards,
>>
>> Sylvio Cesar
>
>
>
> --
> Rob Farmer
>



--=20

Regards,

Sylvio Cesar                || FreeBSD Committer
sylvio@FreeBSD.org  || http://people.freebsd.org/~sylvio ||
http://www.scjamorim.org

"Tenho posto o Senhor continuamente diante de mim; porque Ele est=E1 =E0
minha m=E3o direita, n=E3o vacilarei. Portanto, alegre est=E1 o meu
cora=E7=E3o". (Salmos 16:8)

"Os olhos do SENHOR est=E3o sobre os justos, e os seus ouvidos atentos
ao seu clamor". (Salmos 34:15)
Comment 5 Robert Farmer 2010-02-26 15:27:05 UTC
On Fri, Feb 26, 2010 at 4:15 AM, Sylvio C=E9sar <scjamorim@bsd.com.br> wrot=
e:
> Part of your log with "gcc44"
>
> checking whether gcc44 accepts -g... yes
> checking for gcc44 option to accept ISO C89... none needed
> checking for library containing dlsym... none required
> checking for library containing bindtextdomain... -lintl
> checking for a BSD-compatible install... /usr/bin/install -c -o root -g w=
heel
>
> My log with "gcc42"
>
> checking whether cc accepts -g... yes
> checking for cc option to accept ISO C89... none needed
> checking for library containing dlsym... none required
> checking for library containing bindtextdomain... no
> checking for a BSD-compatible install... /usr/bin/install -c -o root -g w=
heel
>
> Seems that the "checking for library containing bindtextdomain...
> -lintl" is present when build with gcc44, because all my jails has
> gcc42, end have not "bindtextdomain... lintl".
>
> The port build and work well with gcc42 and I can not force it to
> gcc44 only to add bindtextdomain in plist.

Okay - I'll just keep this as a local patch in my tree then. Thanks
for looking at this and sorry about the gcc issue, I should have
tested it with gcc42 before submitting.

--=20
Rob Farmer

>
> Regards,
>
> Sylvio Cesar.
>
>
>
> 2010/2/25 Rob Farmer <rfarmer@predatorlabs.net>:
>> On Wed, Feb 24, 2010 at 3:19 PM, Sylvio Cesar Teixeira
>> <sylvio@freebsd.org> wrote:
>>> Hi,
>>>
>>> I not found this error in my tinderbox (6,7,8 and 9), both arch (i386 a=
nd
>>> amd64). The port , to be installed, have not dependencies of lib bindte=
xtdomain.
>>> Not errors installing with and without NOPORTS*.
>>
>> The only non-standard thing I am doing is using GCC 4.4. However, I
>> don't think that should make a difference in what is/isn't built and
>> installed. Makefile.in installs bindtextdomain on line 57. I don't
>> know why you are not seeing this in your setup... Here's a complete
>> log from my tinderbox:
>> http://www.predatorlabs.net/dl/help2man-1.37.1.log
>>
>>>
>>> Regards,
>>>
>>> Sylvio Cesar
>>
>>
>>
>> --
>> Rob Farmer
>>
>
>
>
> --
>
> Regards,
>
> Sylvio Cesar =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0|| FreeBSD Committer
> sylvio@FreeBSD.org =A0|| http://people.freebsd.org/~sylvio ||
> http://www.scjamorim.org
>
> "Tenho posto o Senhor continuamente diante de mim; porque Ele est=E1 =E0
> minha m=E3o direita, n=E3o vacilarei. Portanto, alegre est=E1 o meu
> cora=E7=E3o". (Salmos 16:8)
>
> "Os olhos do SENHOR est=E3o sobre os justos, e os seus ouvidos atentos
> ao seu clamor". (Salmos 34:15)
>
Comment 6 Robert Farmer 2010-03-01 04:18:02 UTC
How about patching the Makefile so that bindtextdomain is never
installed? Would that be acceptable?

http://www.predatorlabs.net/dl/patches/help2man.diff

--
Rob Farmer
Comment 7 Sylvio César Teixeira Amorim 2010-03-01 13:07:17 UTC
Well, the right would be to check if the module appears with gcc> = 4.4,
if so, would draw something like "@comment " for versions> = 4.4 of gcc.
Comment 8 dfilter service freebsd_committer freebsd_triage 2010-03-08 22:14:09 UTC
sylvio      2010-03-08 22:13:56 UTC

  FreeBSD ports repository

  Modified files:
    misc/help2man        Makefile pkg-plist 
  Log:
  - Add CFLAGS to build port with "-lintl", because this port when
  build with GCC > 4.4 the port enable bindtextdomain.so
  - Add bindtextdomain.so for plist.
  - BUMP PORTREVISION
  
  PR:             ports/144208
  Submitted by:   Rob Farmer <rfarmer@predatorlabs.net>
  Approved by:    itetcu (mentor)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.22      +2 -0      ports/misc/help2man/Makefile
  1.11      +1 -0      ports/misc/help2man/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-03-08 22:14:31 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!