Bug 144570 - [patch] devel/p5-Gearman-Server fix overlap in startup script
Summary: [patch] devel/p5-Gearman-Server fix overlap in startup script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-09 06:50 UTC by Andrej Zverev
Modified: 2010-04-02 15:00 UTC (History)
0 users

See Also:

Attachments
p5-Gearmand-Server.diff (3.21 KB, patch)
2010-03-09 06:50 UTC, Andrej Zverev 		no flags Details | Diff
gm.patch (1.95 KB, patch)
2010-03-24 15:12 UTC, Vick Khera 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrej Zverev 2010-03-09 06:50:01 UTC 
	Since devel/gearmand and devel/p5-Gearman-Server have startup script
	with same name we need to resolve this conflict.

	It was discussed with maintainer some time ago.

Fix: 1. Rename gearmand.in to gearmand-perl.in
	2. add note into UPDATING to inform users about changes
	3. BUMP portrevision
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-03-09 06:50:10 UTC 
Maintainer of devel/p5-Gearman-Server,

Please note that PR ports/144570 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/144570

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-03-09 06:50:13 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Vick Khera 2010-03-24 15:12:54 UTC 
I prefer the following patch which just simply renames the gearmand.in
file to gearmand-perl.in and adjust Makefile to use that instead.  I
disagree that the rc.conf variable name should be changed.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2010-03-24 17:58:31 UTC 
State Changed
From-To: feedback->open

Maintainer has offered a different patch.
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2010-04-02 14:25:07 UTC 
But Vivek, wouldn't then the single rc.conf entry activate both scripts?

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

It whines, glows and fades...
Comment 6 Pav Lucistnik freebsd_committer freebsd_triage 2010-04-02 14:25:19 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pav

Take
Comment 7 Vick Khera 2010-04-02 14:31:15 UTC 
Yes.  This makes migration very trivial.

2010/4/2 Pav Lucistnik <pav@freebsd.org>:
> But Vivek, wouldn't then the single rc.conf entry activate both scripts?
>
Comment 8 Pav Lucistnik freebsd_committer freebsd_triage 2010-04-02 14:44:34 UTC 
State Changed
From-To: open->closed

Maintainer's patch committed, thanks!
Comment 9 dfilter service freebsd_committer freebsd_triage 2010-04-02 14:54:06 UTC 
pav         2010-04-02 13:53:57 UTC

  FreeBSD ports repository

  Modified files:
    devel/p5-Gearman-Server Makefile 
  Added files:
    devel/p5-Gearman-Server/files gearmand-perl.in 
  Removed files:
    devel/p5-Gearman-Server/files gearmand.in 
  Log:
  - Change rc script name to avoid conflict with devel/gearmand
  
  PR:             ports/144570
  Submitted by:   Vick Khera <vivek@khera.org> (maintainer)
  
  Revision  Changes    Path
  1.5       +2 -1      ports/devel/p5-Gearman-Server/Makefile
  1.1       +26 -0     ports/devel/p5-Gearman-Server/files/gearmand-perl.in (new)
  1.3       +0 -26     ports/devel/p5-Gearman-Server/files/gearmand.in (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"