Bug 145099 - [UPDATE] devel/ioncube - new version 3.3.12_1 (added IGNOREFILES and FreeBSD 8 i386)
Summary: [UPDATE] devel/ioncube - new version 3.3.12_1 (added IGNOREFILES and FreeBSD ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-28 07:00 UTC by Svyatoslav Lempert
Modified: 2010-04-08 23:53 UTC (History)
0 users

See Also:


Attachments
file.shar (4.32 KB, text/plain)
2010-03-28 07:00 UTC, Svyatoslav Lempert
no flags Details
ioncube-3.3.12_1.patch (3.98 KB, patch)
2010-04-01 00:10 UTC, Svyatoslav Lempert
no flags Details | Diff
ioncube-3.3.12_1.patch (4.65 KB, patch)
2010-04-08 16:53 UTC, Svyatoslav Lempert
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Svyatoslav Lempert 2010-03-28 07:00:16 UTC
Hello!

ionCube's developers is often (every 2-3 weeks) change checksums for distribution files without notify of changes about it on a official web-site http://www.ioncube.com/loaders.php or other ways.

Distribution files ioncube*.tar.gz have the same names for all versions and often to change port distinfo and to watch it is difficult.

In this reason I have added ioncube dist files as IGNOREFILES in the port Makefile.

Also because ionCube released distribution optimised for FreeBSD 8 i386 (but version for FreeBSD 7 works too and it used for amd64 arch) I have added additional checks for support this.

Now I will send port update only at real change of the version ionCube (that there is 1 time in 2-3 months) and I will not disturb FreeBSD community peoples "superfluous" frequent commits.

Thanks for attention and your work, the new .shar file in the attachment.

Fix: Patch attached with submission follows:
Comment 1 Erwin Lansing 2010-03-31 10:03:37 UTC
Hi Svyatoslav,

Could you provide the patch as a unified diff instead of a shar file?  =
Shar is easy for completely new ports, for later changes unified diffs =
ease the work of the committer.

Thanks!
-erwin
Comment 2 Svyatoslav Lempert 2010-04-01 00:10:17 UTC
2010/3/31 Erwin Lansing <erwin@lansing.dk>:
> Could you provide the patch as a unified diff instead of a shar file?  Shar is easy for completely new ports, for later changes unified diffs ease the work of the committer.
>


Ok, in the attachment final variant diff file for port 3.3.12 to 3.3.12_1

-- 
Svyatoslav
Comment 3 Svyatoslav Lempert 2010-04-05 04:48:58 UTC
Please, look it, because as now the port does not work.
Henceforth I will be more attentive and I will "not get" excessive letters.

-- 
Svyatoslav
Comment 4 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2010-04-08 10:04:53 UTC
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

I'll take it.
Comment 5 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2010-04-08 11:40:46 UTC
On Sun, 28 Mar 2010 05:57:40 GMT
Svyatoslav Lempert <svyatoslav.lempert@gmail.com> wrote:

> Distribution files ioncube*.tar.gz have the same names for all
> versions and often to change port distinfo and to watch it is
> difficult.
> 
> In this reason I have added ioncube dist files as IGNOREFILES in the
> port Makefile.


This is not the best solution, because you can't know what they change
in the tarball, with all breakage potential that can result from this.
What I suggest we do instead is either:
- provide a copy of the tarball on a back-up master site and update the
  port from time to time.
- provide the tarball on a master site under the name
  ${PORTNAME}-${PORTVERSION}-${DATE}.tar.bz and update the port from
  time to time.

I would favor the former.

A simple cron script could check weekly if they have a new tarball.

I'm willing to commit fast the updates to the distinfo file, provided I
get them in diff -u format and with a list of changes.

-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"
FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B
Comment 6 Svyatoslav Lempert 2010-04-08 16:53:40 UTC
2010/4/8 Ion-Mihai Tetcu <itetcu@freebsd.org>:
> - provide a copy of the tarball on a back-up master site and update the
>  port from time to time.


I think that the "dropbox" which is hosted at Amazon S3 is a reliable
(in terms of uptime and availability) is a good place to put files and
posted as MASTER_SITES on it with distfiles copy.

diff for 3.3.12_1 in the attachment

Thank you for your attention, everything was harder than I thought
initially when I did the first version:) I put the files in the my
account and made a script on my computer in the crontab - that checks
once a day checksum with ioncube official site and notify me.

Changes:
- Added FreeBSD 8.0 i386 native binary
- Added back-up master site
- Distfiles checksums changed to 20100405 date

-- 
Svyatoslav
Comment 7 dfilter service freebsd_committer freebsd_triage 2010-04-08 17:39:16 UTC
itetcu      2010-04-08 16:39:02 UTC

  FreeBSD ports repository

  Modified files:
    devel/ioncube        Makefile distinfo 
    devel/ioncube/files  pkg-message.in 
  Log:
  - Added FreeBSD 8.0 i386 native binary
  - Added back-up master site
  - Distfiles checksums changed to 20100405 date
  - bump PORTREVISION
  
  PR:             145099
  Submitted by:   Svyatoslav Lempert (maintainer)
  
  Revision  Changes    Path
  1.3       +15 -8     ports/devel/ioncube/Makefile
  1.3       +15 -14    ports/devel/ioncube/distinfo
  1.2       +6 -3      ports/devel/ioncube/files/pkg-message.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2010-04-08 23:53:05 UTC
State Changed
From-To: open->closed

Committed. Thanks!