Bug 145112 - png update breaks print/dvipdfmx
Summary: png update breaks print/dvipdfmx
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-28 17:40 UTC by Pascal Stumpf
Modified: 2010-03-28 19:50 UTC (History)
0 users

See Also:


Attachments
patch-pngimage.c.diff (388 bytes, patch)
2010-03-28 17:56 UTC, Andrei V. Lavreniyuk
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Stumpf 2010-03-28 17:40:05 UTC
Another port that has been broken by the png update:

cc  -O2 -pipe -fno-strict-aliasing   -L/usr/local/lib -o dvipdfmx dvipdfmx-agl.o
  dvipdfmx-bmpimage.o dvipdfmx-cff.o  dvipdfmx-cff_dict.o dvipdfmx-cid.o  dvipdf
mx-cidtype0.o dvipdfmx-cidtype2.o  dvipdfmx-cmap.o dvipdfmx-cmap_read.o  dvipdfm
x-cmap_write.o dvipdfmx-cs_type2.o  dvipdfmx-dpxconf.o dvipdfmx-dpxcrypt.o  dvip
dfmx-dpxfile.o dvipdfmx-dpxutil.o  dvipdfmx-dvi.o dvipdfmx-dvipdfmx.o  dvipdfmx-
epdf.o dvipdfmx-error.o  dvipdfmx-fontmap.o dvipdfmx-jpegimage.o  dvipdfmx-mem.o
 dvipdfmx-mfileio.o  dvipdfmx-mpost.o dvipdfmx-numbers.o  dvipdfmx-otl_conf.o dv
ipdfmx-otl_opt.o  dvipdfmx-pdfcolor.o dvipdfmx-pdfdev.o  dvipdfmx-pdfdoc.o dvipd
fmx-pdfdraw.o  dvipdfmx-pdfencoding.o dvipdfmx-pdfencrypt.o  dvipdfmx-pdffont.o
dvipdfmx-pdfnames.o  dvipdfmx-pdfobj.o dvipdfmx-pdfparse.o  dvipdfmx-pdfresource
.o dvipdfmx-pdfximage.o  dvipdfmx-pkfont.o dvipdfmx-pngimage.o  dvipdfmx-pst.o d
vipdfmx-pst_obj.o  dvipdfmx-sfnt.o dvipdfmx-spc_color.o  dvipdfmx-spc_dvips.o dv
ipdfmx-spc_html.o  dvipdfmx-spc_misc.o dvipdfmx-spc_pdfm.o  dvipdfmx-spc_tpic.o
dvipdfmx-spc_util.o  dvipdfmx-specials.o dvipdfmx-subfont.o  dvipdfmx-tfm.o dvip
dfmx-tt_aux.o  dvipdfmx-tt_cmap.o dvipdfmx-tt_glyf.o  dvipdfmx-tt_gsub.o dvipdfm
x-tt_post.o  dvipdfmx-tt_table.o dvipdfmx-truetype.o  dvipdfmx-type0.o dvipdfmx-
t1_char.o  dvipdfmx-t1_load.o dvipdfmx-type1.o  dvipdfmx-type1c.o dvipdfmx-unico
de.o  dvipdfmx-vf.o dvipdfmx-xbb.o    -lpng -lm -lz -lpaper -lkpathsea -lkpathse
a
dvipdfmx-pngimage.o(.text+0x222f): In function `check_for_png':
: undefined reference to `png_check_sig'
*** Error code 1

Stop in /usr/ports/print/dvipdfmx/work/dvipdfmx-20090522/src.
*** Error code 1

Stop in /usr/ports/print/dvipdfmx/work/dvipdfmx-20090522.
*** Error code 1

Stop in /usr/ports/print/dvipdfmx/work/dvipdfmx-20090522.
*** Error code 1

Stop in /usr/ports/print/dvipdfmx.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-03-28 17:40:34 UTC
Responsible Changed
From-To: freebsd-ports-bugs->matusita

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Andrei V. Lavreniyuk 2010-03-28 17:56:50 UTC
28.03.2010 19:37, Pascal Stumpf ÐÉÛÅÔ:

> dvipdfmx-pngimage.o(.text+0x222f): In function `check_for_png':
> : undefined reference to `png_check_sig'
> *** Error code 1



--- src/pngimage.c.orig 2009-05-11 05:15:26.000000000 +0300
+++ src/pngimage.c      2010-03-28 19:14:53.218820917 +0300
@@ -148,7 +148,7 @@
    rewind (png_file);
    if (fread (sigbytes, 1, sizeof(sigbytes), png_file) !=
        sizeof(sigbytes) ||
-      (!png_check_sig (sigbytes, sizeof(sigbytes))))
+      (!png_sig_cmp (sigbytes, 0, sizeof(sigbytes))))
      return 0;
    else
      return 1;





-- 
  Best regards, Andrei V. Lavreniyuk.
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2010-03-28 18:14:45 UTC
Responsible Changed
From-To: matusita->dinoex

I will take care of it.
Comment 4 Dirk Meyer freebsd_committer freebsd_triage 2010-03-28 19:48:10 UTC
State Changed
From-To: open->closed

committed a modified patch, the return value has chaned too, thanks.
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-03-28 19:49:55 UTC
dinoex      2010-03-28 18:49:42 UTC

  FreeBSD ports repository

  Added files:
    print/dvipdfmx/files patch-src-pngimage.c 
  Log:
  - fix build for png-1.4.1
  PR:             145112
  
  Revision  Changes    Path
  1.1       +11 -0     ports/print/dvipdfmx/files/patch-src-pngimage.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"