Bug 145201 - update audio/libmusicbrainz3 to compile with www/neon29
Summary: update audio/libmusicbrainz3 to compile with www/neon29
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-30 14:00 UTC by loader
Modified: 2010-04-13 00:10 UTC (History)
0 users

See Also:


Attachments
file.diff (666 bytes, patch)
2010-03-30 14:00 UTC, loader
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description loader 2010-03-30 14:00:15 UTC
update audio/libmusicbrainz3 to compile with www/neon29

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-03-30 14:00:24 UTC
Maintainer of audio/libmusicbrainz3,

Please note that PR ports/145201 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/145201

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-03-30 14:00:26 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Dima Panov freebsd_committer freebsd_triage 2010-03-30 14:42:40 UTC
Responsible Changed
From-To: freebsd-ports-bugs->fluffy

I'll take it.
Comment 4 Jason E. Hale 2010-04-12 23:36:49 UTC
Go ahead with the patch.  If it's good enough for subversion, it will probably work here too.
Use this one attached, though.  The original used spaces instead of tabs.

--- 2010-04-12-libmusicbrainz3.diff begins here ---
diff -ruN libmusicbrainz3.orig/Makefile libmusicbrainz3/Makefile
--- libmusicbrainz3.orig/Makefile	2010-04-12 18:05:41.000000000 -0400
+++ libmusicbrainz3/Makefile	2010-04-12 18:10:51.000000000 -0400
@@ -17,8 +17,15 @@
 MAINTAINER=	bsdkaffee@gmail.com
 COMMENT=	MusicBrainz client library for audio metadata lookup
 
-LIB_DEPENDS=	discid:${PORTSDIR}/audio/libdiscid \
-		neon.28:${PORTSDIR}/www/neon28
+LIB_DEPENDS=	discid:${PORTSDIR}/audio/libdiscid
+
+.if exists(${LOCALBASE}/bin/neon-config)
+NEON_VER!=	${LOCALBASE}/bin/neon-config --version | \
+		${SED} -n -E  's/^neon [0-9]+\.([0-9]+)\..*$$/\1/p'
+.else
+NEON_VER=	29
+.endif
+LIB_DEPENDS+=	neon.${NEON_VER}:${PORTSDIR}/www/neon${NEON_VER}
 
 USE_CMAKE=	yes
 USE_GNOME=	pkgconfig
--- 2010-04-12-libmusicbrainz3.diff ends here ---
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-04-13 00:02:02 UTC
fluffy      2010-04-12 23:01:44 UTC

  FreeBSD ports repository

  Modified files:
    audio/libmusicbrainz3 Makefile 
  Log:
  - Update audio/libmusicbrainz3 to compile with www/neon29
  
  PR:             145201
  Submitted by:   loader <loader@freebsdmall.com
  Approved by:    Jason E. Hale (maintainer, with minor changes)
  
  Revision  Changes    Path
  1.42      +11 -4     ports/audio/libmusicbrainz3/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Dima Panov freebsd_committer freebsd_triage 2010-04-13 00:02:06 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!