Bug 145515 - [update] lang/nbc to 1.0.1.b36
Summary: [update] lang/nbc to 1.0.1.b36
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-08 15:00 UTC by Christopher Key
Modified: 2010-04-26 20:10 UTC (History)
0 users

See Also:


Attachments
lang-nbc-1.0.1.b36 (2.12 KB, text/plain)
2010-04-08 15:00 UTC, Christopher Key
no flags Details
lang-nbc-1.0.1.b36.patch (2.17 KB, patch)
2010-04-08 18:54 UTC, Christopher Key
no flags Details | Diff
nbc-Makefile.diff (1.62 KB, patch)
2010-04-16 16:57 UTC, Rene Ladan
no flags Details | Diff
lang-nbc-1.0.1.b36.patch (2.90 KB, patch)
2010-04-21 14:16 UTC, Christopher Key
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Key 2010-04-08 15:00:13 UTC
NBC 1.0.1.b36 has been released.  The attached patch has only been tested with fpc-2.4.0.x86_64-freebsd, not with fpc-2.2.4.i386-freebsd as is currently in the ports tree.
Comment 1 Christopher Key 2010-04-08 18:54:02 UTC
Updated patch: Additional dependency on fcl-image.
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2010-04-16 07:42:54 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rene

Grab
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2010-04-16 15:34:26 UTC
It doesn't compile inside a 6-STABLE/i386 tinderbox with fpc 2.2.4
which is currently in the Ports Tree, the log is at
http://rene-ladan.nl/tb/errors/6-FreeBSD/nbc-1.0.1.b36.log

If you have patches to upgrade fpc to 2.4.0, can you send-pr them?
Comment 4 Rene Ladan freebsd_committer freebsd_triage 2010-04-16 16:57:12 UTC
Here is a new diff for the Makefile which also works on FreeBSD/i386 < 8.

No update of fpc is required.
Comment 5 Rene Ladan freebsd_committer freebsd_triage 2010-04-21 12:00:04 UTC
2010/4/21 Christopher Key <cjk32@cam.ac.uk>:
> Rene Ladan wrote:
>> Here is a new diff for the Makefile which also works on FreeBSD/i386 < 8=
.
>>
>>
>
> Hello Rene,
>
> Attached is an updated diff that encporates the libusb fixes, and
> additionally installs the missing documentation from a previous
> distfile. =A0It builds on 6.4/7.4/8.0-amd64/i386 without problems.
>
(keeping current maintainer involved)

The new patch looks great, but somehow downloading the previous distfiles
for "just" the feels a bit overdone. The b36 distfile also has some
documentation
(like a manual page), maybe it is better to install that?

Rene
>
> Index: lang/nbc/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/ncvs/ports/lang/nbc/Makefile,v
> retrieving revision 1.7
> diff -u -r1.7 Makefile
> --- lang/nbc/Makefile =A0 28 Mar 2010 06:38:55 -0000 =A0 =A0 =A01.7
> +++ lang/nbc/Makefile =A0 21 Apr 2010 08:35:39 -0000
> @@ -6,25 +6,35 @@
> =A0#
>
> =A0PORTNAME=3D =A0 =A0 =A0 =A0 =A0 =A0 =A0nbc
> -PORTVERSION=3D =A0 =A0 =A0 =A0 =A0 1.0.1.b34
> -PORTREVISION=3D =A01
> +PORTVERSION=3D =A0 =A0 =A0 =A0 =A0 1.0.1.b36
> =A0CATEGORIES=3D =A0 =A0 =A0 =A0 =A0 =A0lang
> -MASTER_SITES=3D =A0 =A0 =A0 =A0 =A0SF/bricxcc/NBC_NXC/NBC%20beta%2034
> -DISTNAME=3D =A0 =A0 =A0 =A0 =A0 =A0 =A0${PORTNAME}-${PORTVERSION}.src
> +MASTER_SITES=3D =A0 =A0 =A0 =A0 =A0http://bricxcc.sourceforge.net/nbc/be=
ta/:src \
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 SF/bricxcc/NBC_NXC/NBC_NXC%=
20beta%2035:doc
> +DISTNAME=3D =A0 =A0 =A0 =A0 =A0 =A0 =A0${PORTNAME}-${PORTVERSION}.unix-s=
rc
> +DOCDISTNAME=3D =A0 =A0 =A0 =A0 =A0 ${PORTNAME}-1.0.1.b35.src
> =A0EXTRACT_SUFX=3D =A0 =A0 =A0 =A0 =A0.tgz
>
> +DISTFILES=3D =A0 =A0 =A0 =A0 =A0 =A0 ${DISTNAME}${EXTRACT_SUFX}:src \
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ${DOCDISTNAME}${EXTRACT_SUF=
X}:doc
> +
> =A0MAINTAINER=3D =A0 =A0 =A0 =A0 =A0 =A0rambiusparkisanius@gmail.com
> =A0COMMENT=3D =A0 =A0 =A0 =A0 =A0 =A0 =A0 NBC is a programming language f=
or the LEGO MINDSTORMS NXT product
>
> =A0RUN_DEPENDS=3D =A0 =A0 =A0 =A0 =A0 legoctl:${PORTSDIR}/devel/roboctl
>
> +.include <bsd.port.pre.mk>
> +
> +.if ${OSVERSION} < 800069
> +LIB_DEPENDS=3D =A0 =A0 =A0 =A0 =A0 usb:${PORTSDIR}/devel/libusb
> +.endif
> +
> =A0USE_GMAKE=3D =A0 =A0 =A0 =A0 =A0 =A0 yes
> =A0USE_DOS2UNIX=3D =A0 =A0 =A0 =A0 =A0yes
> -USE_FPC=3D =A0 =A0 =A0 =A0 =A0 =A0 =A0 fcl-base
> +USE_FPC=3D =A0 =A0 =A0 =A0 =A0 =A0 =A0 fcl-base fcl-image
>
> -MAKEFILE=3D =A0 =A0 =A0 =A0 =A0 =A0 =A0nbcfreebsd.mak
> =A0SUB_FILES=3D =A0 =A0 =A0 =A0 =A0 =A0 pkg-message
> -WRKSRC=3D =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0${WRKDIR}/nxt
> +WRKSRC=3D =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0${WRKDIR}/src/N=
XT
> +DOCWRKSRC=3D =A0 =A0 =A0 =A0 =A0 =A0 ${WRKDIR}/doc/nxt
>
> =A0PLIST_FILES=3D =A0 =A0 =A0 =A0 =A0 bin/nbc \
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0share/nbc/history.txt \
> @@ -35,13 +45,25 @@
> =A0PLIST_DIRS=3D =A0 =A0 =A0 =A0 =A0 =A0share/nbc \
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0include/nbc
>
> +post-patch:
> + =A0 =A0 =A0 @${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|' ${WRKSRC}=
/Makefile
> + =A0 =A0 =A0 @${REINPLACE_CMD} -e 's|/usr/bin|${LOCALBASE}/bin|' ${WRKSR=
C}/Makefile
> +
> +do-extract:
> + =A0 =A0 =A0 @${RM} -rf ${WRKDIR}
> + =A0 =A0 =A0 @${MKDIR} ${WRKDIR}/src
> + =A0 =A0 =A0 @${MKDIR} ${WRKDIR}/doc
> + =A0 =A0 =A0 @cd ${WRKDIR}/src && ${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} =
${_DISTDIR}/${DISTNAME}${EXTRACT_SUFX} ${EXTRACT_AFTER_ARGS}
> + =A0 =A0 =A0 @cd ${WRKDIR}/doc && ${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} =
${_DISTDIR}/${DOCDISTNAME}${EXTRACT_SUFX} ${EXTRACT_AFTER_ARGS} \
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 nxt
> +
> =A0do-install:
> =A0 =A0 =A0 =A0${MKDIR} ${PREFIX}/include/nbc ${PREFIX}/share/nbc
> =A0 =A0 =A0 =A0${INSTALL_PROGRAM} ${WRKSRC}/nbc ${PREFIX}/bin
> =A0 =A0 =A0 =A0${INSTALL_DATA} ${WRKSRC}/*.h ${PREFIX}/include/nbc
> - =A0 =A0 =A0 ${INSTALL_DATA} ${WRKSRC}/*.txt ${PREFIX}/share/nbc
> + =A0 =A0 =A0 ${INSTALL_DATA} ${DOCWRKSRC}/*.txt ${PREFIX}/share/nbc
>
> =A0post-install:
> =A0 =A0 =A0 =A0@${CAT} ${PKGMESSAGE}
>
> -.include <bsd.port.mk>
> +.include <bsd.port.post.mk>
> Index: lang/nbc/distinfo
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/ncvs/ports/lang/nbc/distinfo,v
> retrieving revision 1.2
> diff -u -r1.2 distinfo
> --- lang/nbc/distinfo =A0 8 Mar 2010 20:27:23 -0000 =A0 =A0 =A0 1.2
> +++ lang/nbc/distinfo =A0 21 Apr 2010 08:35:39 -0000
> @@ -1,3 +1,6 @@
> -MD5 (nbc-1.0.1.b34.src.tgz) =3D 0886e4f420fe1e6b23e4ec5a92dc9a9f
> -SHA256 (nbc-1.0.1.b34.src.tgz) =3D 072e43b6ec064ecc2dee79ddcd867368e84a3=
c76a13f5bff6119499b971d2062
> -SIZE (nbc-1.0.1.b34.src.tgz) =3D 363302
> +MD5 (nbc-1.0.1.b36.unix-src.tgz) =3D 16c63352b6d05aec4ab619b88649b978
> +SHA256 (nbc-1.0.1.b36.unix-src.tgz) =3D ea3f47de9be7fdb317a2363250e2f5a6=
3d1a58ca67e06f13766ef808324e4e34
> +SIZE (nbc-1.0.1.b36.unix-src.tgz) =3D 361112
> +MD5 (nbc-1.0.1.b35.src.tgz) =3D 2a85611dbefc240013708ed740c80de4
> +SHA256 (nbc-1.0.1.b35.src.tgz) =3D e14df80fa13c11f46428403e8851fdb5ee636=
cb9ca41a3f1206782ba8981b301
> +SIZE (nbc-1.0.1.b35.src.tgz) =3D 547651
>
>
Comment 6 Christopher Key 2010-04-21 14:16:18 UTC
Rene Ladan wrote:
> 2010/4/21 Christopher Key <cjk32@cam.ac.uk>:
>   
>> Rene Ladan wrote:
>>     
>>> Here is a new diff for the Makefile which also works on FreeBSD/i386 < 8.
>>>
>>>
>>>       
>> Hello Rene,
>>
>> Attached is an updated diff that encporates the libusb fixes, and
>> additionally installs the missing documentation from a previous
>> distfile.  It builds on 6.4/7.4/8.0-amd64/i386 without problems.
>>
>>     
> (keeping current maintainer involved)
>
> The new patch looks great, but somehow downloading the previous distfiles
> for "just" the feels a bit overdone. The b36 distfile also has some
> documentation
> (like a manual page), maybe it is better to install that?
>
> Rene
>   

Apologies, brain addled by configuring tinderbox for i386 on amd64!

The attached patch should be a little more sane.

Comment 7 Ivan "Rambius" Ivanov 2010-04-24 20:10:37 UTC
Hello,

The submitted patch works for me. Please apply to the ports tree.

Rene, thank you for the good job.

Regards
Rambius

-- 
Tangra Mega Rock: http://www.radiotangra.com
Comment 8 dfilter service freebsd_committer freebsd_triage 2010-04-26 19:59:43 UTC
rene        2010-04-26 18:59:34 UTC

  FreeBSD ports repository

  Modified files:
    lang/nbc             Makefile distinfo 
  Log:
  Update to 1.0.1.b36
  
  PR:             ports/145515
  Submitted by:   Christopher Key [cjk32 cam.ac.uk]
  Approved by:    maintainer, tabthorpe (mentor)
  
  Revision  Changes    Path
  1.8       +39 -14    ports/lang/nbc/Makefile
  1.3       +3 -3      ports/lang/nbc/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Rene Ladan freebsd_committer freebsd_triage 2010-04-26 19:59:48 UTC
State Changed
From-To: open->closed

Committed, thanks