on amd64 platforms the ffmpeg port incorrectly uses MACHINE_CPU and a lack of the text 'sse' or 'mmx' to DISABLE sse and mmx capability. This is completely unnecessary since ffmpeg's configuration script already works without making these additional checks. Further it does not follow the standard (which would be to use ARCH) and uses the BUILD platform to make the determination for the TARGET platform's code. The correct solution would be to either eliminate these checks or patch the Makefile using the patch submitted with this report. Alternately use ARCH to (correctly) determine whether or not these capabilities should be enabled. Fix: Patch attached with submission follows: How-To-Repeat: On an amd64 platform, clean multimedia/ffmpeg and run 'make configure' and note the text output showing mmx and sse disabled. Then apply the patch (or remove the appropriate sections from Makefile), clean, and run 'make configure' again. Note the correct enabling of mmx and sse for amd64.
Responsible Changed From-To: freebsd-ports-bugs->mm Over to maintainer (via the GNATS Auto Assign Tool)
mm 2010-04-18 12:07:45 UTC FreeBSD ports repository Modified files: multimedia/ffmpeg Makefile Log: - Fix mmx/sse support in amd64 package [1] - Add support for multimedia/x264-devel - Bump PORTREVISION PR: ports/145586 [1] Submitted by: Bob Frazier <bobf@mrp3.com> [1] Revision Changes Path 1.103 +21 -4 ports/multimedia/ffmpeg/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, with minor changes. Thanks!