Bug 145668 - net-mgmt/nagios-plugins ping6 broken
Summary: net-mgmt/nagios-plugins ping6 broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stefan Walter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-13 10:20 UTC by Charlie &
Modified: 2010-07-07 08:10 UTC (History)
1 user (show)

See Also:


Attachments
nagios-plugins-ping6.diff (683 bytes, patch)
2010-07-03 12:38 UTC, Stefan Walter
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie & 2010-04-13 10:20:02 UTC
When using nagios plugins with IPV6 enabled in a jail the check_ping command doesn't work to an IPV6 address, this is due to a failed test during the configure stage (I think it tries to ping6 ::1 which doesn't work in a jail)
I tried the configure in a non jailed environment and there everything works as expected (the ping6 command syntax is validated as working during configure stage)

How-To-Repeat: 
Within a jail execute:
/usr/local/libexec/nagios/check_ping -H {IPV6 address} -w 100,10% -c 200,20% -6

where the {IPV6 address} is replaced with a real address
Fix:

	<how to correct or work around the problem, if known (multiple lines)>

Patch attached which hardcodes the ping6 command when nagios-plugins is installed inside a jail

--- nagios-plugins.patch begins here ---
diff -ru nagios-plugins.org/Makefile nagios-plugins/Makefile
--- nagios-plugins.org/Makefile 2009-12-26 11:18:11.000000000 +0100
+++ nagios-plugins/Makefile     2010-04-13 10:40:45.000000000 +0200
@@ -136,6 +136,10 @@
 PLIST_SUB+=    NLS=""
 .endif
 
+.if defined(WITH_JAIL)
+CONFIGURE_ARGS+=        --with-ping6-command="/sbin/ping6 -n -c %d %s"
+.endif
+
 post-patch:
 .for file in check_by_ssh.c check_disk.c check_http.c check_mrtgtraf.c \
        check_nagios.c check_pgsql.c check_snmp.c check_ssh.c check_swap.c \
--- nagios-plugins.patch ends here ---

***deze e-mail is gescand door Onlinespamfilter.nl***
Comment 1 Stefan Walter freebsd_committer freebsd_triage 2010-05-20 10:05:21 UTC
Dear maintainer of net-mgmt/nagios-plugins,

a problem report has been submitted for your port for which your 
feedback might be required; its contents can be found at [1]. If it 
contains a patch or suggestions for a change, please send a followup to 
the PR explaining whether or not you approve it and want it to be 
committed.

Regards,
Stefan

[1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/145668
Comment 2 Stefan Walter freebsd_committer freebsd_triage 2010-05-20 10:05:30 UTC
State Changed
From-To: open->feedback

Awaiting maintainer's feedback. 


Comment 3 Stefan Walter freebsd_committer freebsd_triage 2010-05-20 10:05:30 UTC
Responsible Changed
From-To: freebsd-ports-bugs->stefan

Track this for now.
Comment 4 Stefan Walter freebsd_committer freebsd_triage 2010-07-03 12:38:00 UTC
Hi,

the attached patch solves the problem with ping6 in jails the same way as
the existing solution for ping. Could you try it and let me know if it
works for you?

Jarrod: Do you approve the patch?

Regards,
Stefan
Comment 5 jarrod 2010-07-06 12:33:51 UTC
On Sat, 3 Jul 2010, Stefan Walter wrote:
> Jarrod: Do you approve the patch?

Hi Stefan, approved - and thanks!

Jarrod.
Comment 6 Stefan Walter freebsd_committer freebsd_triage 2010-07-07 08:05:16 UTC
State Changed
From-To: feedback->closed

Patch committed, thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2010-07-07 08:05:17 UTC
stefan      2010-07-07 07:04:31 UTC

  FreeBSD ports repository

  Modified files:
    net-mgmt/nagios-plugins Makefile 
  Log:
  Make the IPv6 address pinged for testing ping6 configurable, too, to make it
  work in jails.
  
  PR:             145668
  Submitted by:   "Charlie &" <root@flappie.debank.tv>
  Patch by:       stefan
  Approved by:    maintainer
  Feature safe:   yes
  
  Revision  Changes    Path
  1.78      +2 -0      ports/net-mgmt/nagios-plugins/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"