Bug 145928 - [patch] fix irc/irssi-fish build problem
Summary: [patch] fix irc/irssi-fish build problem
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sylvio Cesar Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-22 00:40 UTC by Ryan Steinmetz
Modified: 2010-04-25 00:50 UTC (History)
0 users

See Also:


Attachments
file.diff (382 bytes, patch)
2010-04-22 00:40 UTC, Ryan Steinmetz
no flags Details | Diff
irssi-fish.diff (899 bytes, patch)
2010-04-22 18:55 UTC, Ashish Shukla
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Steinmetz 2010-04-22 00:40:01 UTC
===>  Extracting for irssi-fish-1.00.r5
=> MD5 Checksum OK for FiSH-irssi.v1.00-RC5-source.zip.
=> SHA256 Checksum OK for FiSH-irssi.v1.00-RC5-source.zip.
===>   irssi-fish-1.00.r5 depends on file: /usr/local/bin/unzip - found
===>  Patching for irssi-fish-1.00.r5
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
sed: first RE may not be empty
#@/usr/bin/sed -i.bak -e '/mirdef.lnx/d' /usr/ports/irc/irssi-fish/work/FiSH-irssi.v1.00-RC5-source/Makefile
===>   irssi-fish-1.00.r5 depends on file: /usr/local/include/glib-2.0/glib.h - found
===>   irssi-fish-1.00.r5 depends on file: /usr/local/lib/libmiracl.a - found
===>   irssi-fish-1.00.r5 depends on file: /usr/local/include/irssi/src/common.h - found
===>  Configuring for irssi-fish-1.00.r5
===>  Building for irssi-fish-1.00.r5

######################## FiSH for irssi COMPILING NOTES ########################
--------------------------------------------------------------------------------
You'll need MIRACL (http://www.shamus.ie/) to compile FiSH! It is suggested
to recompile /usr/local/lib/libmiracl.a on your target machine (compile instructions can be found
in miracl.zip/linux.txt). Also, make sure you are using the correct mirdef.h
(especially in case of exotic systems). On amd64 systems use 'mirdef_amd64.h'
and have a look at miracl.zip/amd64.txt, use 'mirdef_macosx.h' for MacOSX. You
can test MIRACL with pk-demo.

Using irssi source from: /usr/local/include/irssi
Using glib.h from: /usr/local/lib/glib-2.0
Using glibconfig.h from: /usr/local/include/glib-2.0
-- Please make sure you have all of them installed!
   (try 'pkg-config --cflags glib-2.0' or 'pkg-config --cflags glib'
    or 'locate glib.h' and 'locate glibconfig.h')

-- If you plan to use a custom password for your blow.ini (via /setinipw),
-- you can skip the following note!
You are adviced to change default_iniKey in FiSH.h - But remember, changing the
default blow.ini password will make your old keys in blow.ini unusable!

Fix: Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/irc/irssi-fish && make install
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-04-22 00:42:05 UTC
Maintainer of irc/irssi-fish,

Please note that PR ports/145928 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/145928

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-04-22 00:42:07 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Ashish Shukla 2010-04-22 10:43:26 UTC
Hi Ryan,

Are you using csh (C Shell) ? If yes, can you try the patch in PR
ports/145555[1] and report if that works for you.

References:
[1]  http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/145555

Thanks
-- 
Ashish SHUKLA
Comment 4 Ryan Steinmetz 2010-04-22 12:19:18 UTC
Ashish,

I am not using csh.

According to portsmon, it fails to build under all versions of i386:
http://portsmon.freebsd.org/portoverview.py?category=irc&portname=irssi-fish
Comment 5 Ashish Shukla 2010-04-22 12:30:40 UTC
Ryan Steinmetz writes:
> Ashish,


> I am not using csh.


> According to portsmon, it fails to build under all versions of i386:
> http://portsmon.freebsd.org/portoverview.py?category=irc&portname=irssi-fish


Can you try the patch and see if that works for you, while I investigate the
i386 issue.

Thanks
-- 
Ashish SHUKLA
Comment 6 Ryan Steinmetz 2010-04-22 12:49:26 UTC
The patch in ports/145555 does not resolve this issue.  Please see the attached patch for this PR.
Comment 7 Ashish Shukla 2010-04-22 13:02:32 UTC
Ryan Steinmetz writes:
> The patch in ports/145555 does not resolve this issue.  Please see the attached patch for this PR.


Cool, thanks for testing and confirming that it doesn't work. I'll look at
your patch and then get back to you.

-- 
Ashish SHUKLA
Comment 8 Ryan Steinmetz 2010-04-23 01:44:02 UTC
Ashish,

Appears to work fine under irssi 0.8.15/7.3-RELEASE i386.

-r
Comment 9 Ashish Shukla 2010-04-23 07:35:03 UTC
Hi committer,

Ryan Steinmetz writes:
> Ashish,


> Appears to work fine under irssi 0.8.15/7.3-RELEASE i386.


Can you please commit the last diff I sent ? This diff fixes the problem
reported by Ryan and the problem mentioned in the PR: ports/145555.

Thanks
-- 
Ashish SHUKLA
Comment 10 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-04-23 12:59:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sylvio

I'll take it.
Comment 11 dfilter service freebsd_committer freebsd_triage 2010-04-25 00:44:56 UTC
sylvio      2010-04-24 23:44:48 UTC

  FreeBSD ports repository

  Modified files:
    irc/irssi-fish       Makefile 
  Log:
  - Fix problem with build in C shell.
  
  PR:             ports/145928
  Submitted by:   Ryan Steinmetz <rpsfa@rit.edu>
  Approved by:    Ashish Shukla <wahjava@gmail.com> (maintainer)
  
  Revision  Changes    Path
  1.10      +2 -1      ports/irc/irssi-fish/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 12 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-04-25 00:45:07 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!