INSTALLS_SHLIB is deprecated and no one port use it anymore. Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->portmgr bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool)
Hi Updated version.
I'm not sure we need to check if INSTALLS_SHLIB is defined just to say it's deprecated. It actually has been deprecated for a while and portlint already warns that it should be replaced by USE_LDCONFIG. The patch looks good to me otherwise. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer
On Tue, May 11, 2010 at 08:38:14PM +0100, Florent Thoumie wrote: > I'm not sure we need to check if INSTALLS_SHLIB is defined just to say > it's deprecated. It actually has been deprecated for a while and > portlint already warns that it should be replaced by USE_LDCONFIG. I can change warning to IGNORE as I done with USE_XPM or I can delete this check completely. What do You prefer? Also note that pr146365 need to resolved at least partialy (Mk/bsd.gnustep.mk part) before this pr. -- Adios
pav 2010-08-20 12:15:02 UTC FreeBSD ports repository Modified files: Mk bsd.commands.mk bsd.licenses.mk bsd.port.mk Log: - Fix plist leftovers when using LICENSE framework and having @cwd command in plist PR: ports/147296 Submitted by: beat - Provide end-user DISABLE_LICENSES knob to disable licensing framework PR: ports/149070 Submitted by: amdmi3 - Include bsd.gnome.mk when INSTALLS_ICONS is defined PR: ports/148051 Submitted by: amdmi3 - Disable xz memory limit to fix port builds on low-memory systems PR: ports/148250 Submitted by: Warren Block <wblock@wonkity.com> - Remove compatibility shim for 6.3-RELEASE and older in describe target PR: ports/146067 Submitted by: Alex Kozlov <spam@rm-rf.kiev.ua> - Remove INSTALLS_SHLIB PR: ports/146351 Submitted by: Alex Kozlov <spam@rm-rf.kiev.ua> - Remove last trace of APACHE_COMPAT PR: ports/147114 Submitted by: pgollucci - Allow ports to override _MAKE_JOBS PR: ports/148754 Submitted by: Anonymous <swell.k@gmail.com> - Fixes to comments block PR: ports/135649, ports/148190 Submitted by: pgollucci, gcooper Revision Changes Path 1.6 +4 -3 ports/Mk/bsd.commands.mk 1.3 +6 -10 ports/Mk/bsd.licenses.mk 1.644 +36 -139 ports/Mk/bsd.port.mk _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, thanks
Hi, Pav I belive that flz@ is right, just a warning about INSTALLS_SHLIB is useless. Can You please upgrade it to fatal error? Thanks. While here, also remove trailing dot from USE_XPM IGNORE. -- Adios
Why do we need this? We terminated INSTALLS_SHLIB, I'm not adding it back. Alex Kozlov pí¹e v po 23. 08. 2010 v 00:05 +0300: > Hi, Pav > > I belive that flz@ is right, just a warning about INSTALLS_SHLIB > is useless. Can You please upgrade it to fatal error? Thanks. > While here, also remove trailing dot from USE_XPM IGNORE. > > > -- > Adios -- -- Pav Lucistnik <pav@oook.cz> <pav@FreeBSD.org> The rule of software licences: If it doesn't fit on your screen, it's probably too complex to understand.
On Sun, Aug 22, 2010 at 11:08:48PM +0200, Pav Lucistnik wrote: > Alex Kozlov pÃÅ¡e v po 23. 08. 2010 v 00:05 +0300: > > I belive that flz@ is right, just a warning about INSTALLS_SHLIB > > is useless. Can You please upgrade it to fatal error? Thanks. > > While here, also remove trailing dot from USE_XPM IGNORE. > Why do we need this? We terminated INSTALLS_SHLIB, I'm not adding it > back. It's protection against accidental use INSTALLS_SHLIB in the future. If You think that this unnecessary, please remove warning completely. You may also want to remove similar protection for USE_XPM. -- Adios