Bug 146435 - [PATCH] mail/mimedefang - Update to 2.68 and a few additional port fixes
Summary: [PATCH] mail/mimedefang - Update to 2.68 and a few additional port fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wes Peters
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-09 18:50 UTC by Marko Njezic
Modified: 2010-08-13 09:50 UTC (History)
0 users

See Also:


Attachments
file.diff (8.22 KB, patch)
2010-05-09 18:50 UTC, Marko Njezic
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marko Njezic 2010-05-09 18:50:04 UTC
I'm sending a patch for mimedefang port, which does the following:

- Updates port to recently released mimedefang version 2.68.
- Fixes default clamd socket location, which was being set by previous port to the wrong location (missing ".sock" suffix).
- Renames init script from "mimedefang.sh-dist" to "mimedefang" in order to be consistent with other rc scripts.
- Fixes restart option in init script, which so far didn't work properly, because it takes some time for libmilter to remove socket after stopping, thus preventing the new socket from being created. This is fixed by adding new restart_cmd function that waits between stop / start sequence.
- Fixes wrong group ownership on mimedefang's spool and quarantine directories, which is set to mailnull:wheel if mimedefang is installed directly from port. I've modified port's makefile to properly chgrp those directories. This doesn't happen if mimedefang is installed from package, because in that case pkg-install script will set ownership to mailnull:mailnull.
- Modifies the init script, so that it's able to change mimedefangs milter's socket file mode after starting (this makes using mimedefang from postfix much easier, you only need to add postfix's user to mailnull group and set socket mode to 660). By default, mimedefang (or more precisely libmilter) will set socket mode respecting umask, which is set to 027 in mimedefang, resulting in 777-027=750 permissions on socket, which are useless because it's not group writable. Modified init script allows users to choose socket mode to their own liking (modifications are based on clamav's milter init script).

Fix: Apply the suggested patch.

Patch attached with submission follows:
How-To-Repeat: N/A
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-05-09 18:50:42 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wes

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2010-08-13 08:43:52 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-08-13 09:41:21 UTC
pav         2010-08-13 08:41:13 UTC

  FreeBSD ports repository

  Modified files:
    mail/mimedefang      Makefile distinfo pkg-plist 
    mail/mimedefang/files patch-Makefile.in 
                          patch-mimedefang-filter.5.in 
                          patch-mimedefang.pl.in 
  Added files:
    mail/mimedefang/files patch-examples__init-script.in 
  Log:
  - Update to 2.68
  - Provide rcNG script (thus add mimedefang_enable to your rc.conf)
  
  PR:             ports/146435
  Submitted by:   Marko Njezic <mrmax063@maxempire.com>
  Approved by:    maintainer timeout (wes; 3 months)
  
  Revision  Changes    Path
  1.67      +6 -8      ports/mail/mimedefang/Makefile
  1.49      +3 -3      ports/mail/mimedefang/distinfo
  1.11      +5 -5      ports/mail/mimedefang/files/patch-Makefile.in
  1.1       +89 -0     ports/mail/mimedefang/files/patch-examples__init-script.in (new)
  1.4       +4 -4      ports/mail/mimedefang/files/patch-mimedefang-filter.5.in
  1.6       +5 -5      ports/mail/mimedefang/files/patch-mimedefang.pl.in
  1.16      +1 -1      ports/mail/mimedefang/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"