Bug 146556 - [patch] ftp/vsftpd rc script doesn't support vsftpd_flags
Summary: [patch] ftp/vsftpd rc script doesn't support vsftpd_flags
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-13 23:40 UTC by Jason
Modified: 2010-08-07 09:51 UTC (History)
0 users

See Also:


Attachments
file.diff (598 bytes, patch)
2010-05-13 23:40 UTC, Jason
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason 2010-05-13 23:40:04 UTC
If vsftpd_flags is set in /etc/rc.conf to use a different configuration file, it will fail, as it is only considering the required default file in precmd.

How-To-Repeat: Add port ftp/vsftpd
cp default /usr/local/etc/vsftpd.conf to /usr/local/etc/vsftpd_test.conf
add vsftpd_enable="YES" to /etc/rc.conf
add vsftpd_flags="/usr/local/etc/vsftpd_test.conf"
run /usr/local/etc/rc.d/vsftpd start
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-05-13 23:40:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2010-05-18 05:51:09 UTC
State Changed
From-To: open->feedback


Please improve 

your patch does not anlde option set wirthout specify the config. 
e.g: 

vsftpd_flags="-oftpd_banner=blah"
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2010-07-18 12:43:02 UTC
State Changed
From-To: feedback->closed

- problem not reproduceable here 
- no feedback
Comment 4 Dirk Meyer freebsd_committer freebsd_triage 2010-07-18 12:48:08 UTC
State Changed
From-To: closed->analyzed


I think of reworking the rc.d file.
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-08-07 08:49:26 UTC
dinoex      2010-08-07 07:49:17 UTC

  FreeBSD ports repository

  Modified files:
    ftp/vsftpd           Makefile distinfo 
    ftp/vsftpd/files     vsftpd.sh.in 
  Added files:
    ftp/vsftpd/files     pidfile.patch 
  Log:
  - rc.d supports now vsftpd_config
  PR:             146556
  
  - new option WITH_PIDFILE
  Submitted by:   Eugen Zagorodniy
  
  - update to 2.3.0
  
  Revision  Changes    Path
  1.41      +7 -2      ports/ftp/vsftpd/Makefile
  1.23      +3 -3      ports/ftp/vsftpd/distinfo
  1.1       +87 -0     ports/ftp/vsftpd/files/pidfile.patch (new)
  1.12      +8 -6      ports/ftp/vsftpd/files/vsftpd.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Dirk Meyer freebsd_committer freebsd_triage 2010-08-07 09:50:30 UTC
State Changed
From-To: analyzed->closed

a fix is committed, thanks.