OPTIONS is very convenient. A recent build for us went wrong due to not remembering to set environment variables for this port. Patch was tested on an 80-column terminal, where I found that detailed descriptions don't fit. I looked at the informational messages near the end of the port, but it didn't seem necessary to change them, unless "environment variable" should be changed to "option". Fix: Patch attached with submission follows:
I found one error in the attached patch. In the section with "WITH_SENDMAIL_BASE", there are two .endif lines in a row. One of these needs to be removed.
Responsible Changed From-To: freebsd-ports-bugs->stefan Take.
Hi Marshal, mail/spamass-milter is currently without a maintainer. Since you seem to be interested in the port working well: Would you be interested in taking over maintainership of this port? Also, I noticed that you removed this part from the Makefile: .if exists(${LOCALBASE}/lib/libldap.so) WITH_LDAP=yes .endif This looks suspiciously like it was added because spamass-milter might automatically link against an existing ldap library. (It would make sure that the port also registers a dependency on the installed ldap port.) Are you sure it can be removed? Regards, Stefan
State Changed From-To: open->feedback Awaiting submitter's feedback.
Responsible Changed From-To: stefan->freebsd-ports-bugs Return this PR to the pool - I currently do not have the time to take care of it.
State Changed From-To: feedback->closed Patch committed after modification
pav 2010-08-26 11:52:12 UTC FreeBSD ports repository Modified files: mail/spamass-milter Makefile Log: - Convert to OPTIONS PR: ports/146737 Submitted by: Marshal Newrock <marshal@zordio.com Revision Changes Path 1.42 +6 -35 ports/mail/spamass-milter/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"