The port directly depends on gettext and uses version from ports rather than bundled. It shouldn't assume that LIB_DEPENDS dependencies were installed with NLS support when they have WITHOUT_NLS ifdef around USE_GETTEXT and can be disabled. How-To-Repeat: On a pristine system $ make WITHOUT_NLS=
Maintainer of devel/m17n-lib, Please note that PR ports/147123 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147123 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Thank you for looking into this and sorry for the delay in answering. You are right, WITHOUT_NLS= causes breakage. The reason why devel/gettext is listed as a direct dependency here lies in m17n-db. So I filled ports/147344 which fixes the problem there (see that PR's Description: devel/m17n-db unrightfully checks for msgfmt even with --disable-nls, so we have to patch configure script). As for this port, I can't approve the patch you proposed because it doesn't conform with the section 6.5.2 of the Porters Handbook: it's explicitly stated there that "your port should use gettext conditionally, depending on the status of WITHOUT_NLS". So it seems it's better to completely disable NLS since this software currently provides no translation. There is a lot of such examples: archivers/xz (see the comment there), cad/pcb, devel/avr-gcc-3, devel/avr-gdb, devel/cross-binutils, devel/cross-gcc, devel/cross-gdb, devel/djgpp-binutils, devel/djgpp-gcc, devel/gdb53-act, devel/libbfd, devel/libconfuse, devel/m6811-binutils, devel/mingw32-binutils, devel/mingw32-gcc, devel/msp430-binutils, devel/msp430-gcc, devel/psptoolchain-binutils, devel/psptoolchain-gcc-stage1, devel/psptoolchain-gcc-stage2, devel/psptoolchain-gdb, devel/tigcc, devel/tigcc, emulators/psim-freebsd, games/lbreakout2, games/lordsawar, games/volleyball, graphics/icoutils, graphics/libiptcdata, japanese/gicq, japanese/grep, lang/gcc34, lang/gcc42, lang/gcc43, lang/gcc44, lang/gcc45, lang/gdc, lang/gnat, lang/gpc, lang/gnat-gcc42, lang/gnat-gcc43, lang/llvm-gcc4, lang/mdk, lang/gnat-gcc44, lang/gcc46, misc/gnuls, multimedia/gmimms, net/ucarp, net-mgmt/nagios-check_bacula, net-p2p/transmission-cli, net-p2p/transmission-daemon, print/enscript-letter, print/freetype, print/freetype-tools, print/freetype2, print/rlpr, sysutils/fileschanged, sysutils/psmisc, textproc/gsed (?), textproc/gnugrep, www/w3m, x11-servers/Xfst. To the committer: please apply the patch provided below: --- m17n-lib-1.6.1_1.patch begins here --- Index: Makefile =================================================================== RCS file: /home/ncvs/ports/devel/m17n-lib/Makefile,v retrieving revision 1.31 diff -u -r1.31 Makefile --- Makefile 3 May 2010 06:39:40 -0000 1.31 +++ Makefile 2 Jun 2010 21:20:36 -0000 @@ -7,6 +7,7 @@ PORTNAME= m17n-lib PORTVERSION= 1.6.1 +PORTREVISION= 1 CATEGORIES= devel MASTER_SITES= http://www.m17n.org/m17n-lib-download/ \ http://anthesphoria.net/FreeBSD/ports/distfiles/ @@ -28,8 +29,6 @@ USE_XORG= ice sm x11 xaw xft xt USE_GNOME= gnometarget libxml2 pkgconfig USE_AUTOTOOLS= autoconf:262 libtool:22 -CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \ - LDFLAGS="-L${LOCALBASE}/lib -lintl" USE_LDCONFIG= yes OPTIONS= ANTHY "With Anthy support" off \ @@ -38,6 +37,8 @@ .include <bsd.port.pre.mk> +CONFIGURE_ARGS+= --disable-nls + .if defined(WITH_ANTHY) LIB_DEPENDS+= anthy.1:${PORTSDIR}/japanese/anthy .else --- m17n-lib-1.6.1_1.patch ends here --- -- Nikola Lecic fingerprint : FEF3 66AF C90E EDC3 D878 7CDC 956D F4AB A377 1C9B
Nikola Le=C4=8Di=C4=87 <nikola.lecic@anthesphoria.net> writes: > As for this port, I can't approve the patch you proposed because it > doesn't conform with the section 6.5.2 of the Porters Handbook: it's > explicitly stated there that "your port should use gettext > conditionally, depending on the status of WITHOUT_NLS". > > So it seems it's better to completely disable NLS since this software > currently provides no translation. [...] > To the committer: please apply the patch provided below: [...] I'm fine with it. Didn't notice that the port supported --disable-nls switch. The patch works well for dependent editors/emacs.
Responsible Changed From-To: freebsd-ports-bugs->delphij Take.
State Changed From-To: feedback->closed Maintainer patch applied, thanks for reporting the issue.
delphij 2010-06-10 18:39:51 UTC FreeBSD ports repository Modified files: devel/m17n-lib Makefile Log: Disable usage of gettext libraries. Submitted by: maintainer PR: ports/147123 Revision Changes Path 1.32 +3 -2 ports/devel/m17n-lib/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"