Bug 147429 - [PATCH] net/ekiga: Record gettext dep', minor Makefile fixes
Summary: [PATCH] net/ekiga: Record gettext dep', minor Makefile fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-03 13:30 UTC by Matthias Andree
Modified: 2010-06-04 13:00 UTC (History)
1 user (show)

See Also:


Attachments
ekiga-2.0.11_9.patch (1.06 KB, patch)
2010-06-03 13:30 UTC, Matthias Andree
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree 2010-06-03 13:30:01 UTC
mi@, please approve of the patch below.

I propose to:
- add a missing gettext dependency so that portmaster -r gettext will
  also update ekiga next time gettext needs to be updated,
  see ports/UPDATING
- replaces ALL_TARGET by MAKE_JOBS_SAFE
- moves LIB_DEPENDS up to please portlint.
- bump PORTREVISION to force a rebuild, pulling in gettext update.

Please install and use portlint when submitting port upgrades.

Port maintainer (mi@aldan.algebra.com) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-06-03 13:30:11 UTC
Maintainer of net/ekiga,

Please note that PR ports/147429 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147429

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-06-03 13:30:13 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Matthias Andree freebsd_committer freebsd_triage 2010-06-03 13:32:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mandree

I'll take it.
Comment 4 Mikhail T. 2010-06-03 21:57:14 UTC
03.06.2010 08:23, Matthias Andree ÎÁÐÉÓÁ×(ÌÁ):
> mi@, please approve of the patch below.

No problem with any of the proposed changes except for the PORTREVISION 
bump.

Doing these bumps when any of the dependencies change is asinine -- even 
if it continues to be expected by the portmgr people :-( That a 
dependency changes, is well known, when packages are (re)built -- 
PORTREVISION is not necessary for such dependency-tracking, clearly does 
not work for such tracking (otherwise it would've been caught-up 
automatically), and should not be used for anything other than signaling 
changes in the port itself.

BTW, if you'd like to take over this port's maintainership, go ahead -- 
I ended up not using ekiga myself and the port has, obviously, suffered 
because of that...

Yours,

	-mi
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-06-04 12:51:03 UTC
mandree     2010-06-04 11:50:46 UTC

  FreeBSD ports repository

  Modified files:
    net/ekiga            Makefile 
  Log:
  Add USE_GETTEXT=yes, rearrange Makefile a bit, ALL_TARGET->MAKE_JOBS_SAFE.
  
  PR:          ports/147429
  Approved by: mi@aldan.algebra.com (maintainer)
  Approved by: garga (mentor)
  
  Revision  Changes    Path
  1.84      +4 -3      ports/net/ekiga/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Matthias Andree freebsd_committer freebsd_triage 2010-06-04 12:51:27 UTC
State Changed
From-To: feedback->closed

Committed, without PORTREVISION bump per maintainer's direction.