Bug 147640 - [PATCH] multimedia/mkvtoolnix: use += for setting CPPFLAGS and LDFLAGS
Summary: [PATCH] multimedia/mkvtoolnix: use += for setting CPPFLAGS and LDFLAGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-07 09:40 UTC by Andriy Gapon
Modified: 2010-06-09 10:10 UTC (History)
1 user (show)

See Also:

Attachments
mkvtoolnix-3.3.0_2.patch (621 bytes, patch)
2010-06-07 09:40 UTC, Andriy Gapon 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Gapon 2010-06-07 09:40:01 UTC 
Right now this port simply sets CPPFLAGS and LDFLAGS thus overriding any local
tuning that a user might want to do via e.g. /etc/make.conf.
I think that in general it is recommended that CPPFLAGS, LDFLAGS, etc are
amended, not overridden, in ports Makefiles.

Port maintainer (multimedia@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-06-07 09:40:18 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-multimedia

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2010-06-07 10:10:47 UTC 
Responsible Changed
From-To: freebsd-multimedia->miwi

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-06-09 10:05:09 UTC 
miwi        2010-06-09 09:04:43 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/mkvtoolnix Makefile distinfo pkg-plist 
    multimedia/mkvtoolnix/files patch-Makefile.in 
  Added files:
    multimedia/mkvtoolnix/files patch-src_common_strings_editing.h 
  Removed files:
    multimedia/mkvtoolnix/files patch-handle_deps 
  Log:
  - Update to 3.4.0
  - Use += for setting CPPFLAGS and LDFLAGS [1]
  - Fix build with gcc44 [1]
  
  PR:             146675 147640 147643
  Submitted by:   Ports Fury
                  Andriy Gapon <avg@icyb.net.ua> [1]
  
  Revision  Changes    Path
  1.65      +3 -4      ports/multimedia/mkvtoolnix/Makefile
  1.34      +3 -3      ports/multimedia/mkvtoolnix/distinfo
  1.2       +0 -9      ports/multimedia/mkvtoolnix/files/patch-Makefile.in
  1.2       +0 -11     ports/multimedia/mkvtoolnix/files/patch-handle_deps (dead)
  1.1       +10 -0     ports/multimedia/mkvtoolnix/files/patch-src_common_strings_editing.h (new)
  1.10      +2 -0      ports/multimedia/mkvtoolnix/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Martin Wilke freebsd_committer freebsd_triage 2010-06-09 10:05:24 UTC 
State Changed
From-To: open->closed

Committed. Thanks!