Bug 147779 - [patch] port www/sbox-dtc: quotes makes crazy UID value
Summary: [patch] port www/sbox-dtc: quotes makes crazy UID value
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-10 23:50 UTC by mail_of_sergey
Modified: 2010-06-13 21:00 UTC (History)
0 users

See Also:

Attachments
file.diff (402 bytes, patch)
2010-06-10 23:50 UTC, mail_of_sergey 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mail_of_sergey 2010-06-10 23:50:01 UTC 
The quotes at -DUID_MIN and -DGID_MIN CFLAGS makes crazy UID value.
Example:
SBOX_UIDMIN?=   1000
SBOX_GIDMIN?=   1000

Try to run cgi-script:
the directory containing /home/export/web/fluffy/cgi-bin/test.cgi must not be owned by a UID less than 134523267
But minimal UID is 1000!

Ater removing the quotes at -DUID_MIN and -DGID_MIN CFLAGS the cgi-script was run.

Fix: Remove the quotes around -DUID_MIN and -DGID_MIN CFLAGS.

Patch attached with submission follows:
How-To-Repeat: Just install sbox and try to use it.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-06-10 23:50:09 UTC 
Maintainer of www/sbox-dtc,

Please note that PR ports/147779 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147779

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-06-10 23:50:10 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Aldis Berjoza 2010-06-11 10:40:19 UTC 
Basically I accept patch.


However PORTREVISION should be set to 1.
Also quotes aren't required at all around ${SBOX_UIDMIN} and
${SBOX_GIDMIN}
So I updated submitted patch:
http://pastebin.com/c4jizPzc

-- 
BSDroot.lv --> coming soon
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2010-06-11 16:36:24 UTC 
State Changed
From-To: feedback->open

Maintainer approved, with some suggested changes.
Comment 5 Rene Ladan freebsd_committer freebsd_triage 2010-06-13 14:18:11 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->rene

Grab
Comment 6 dfilter service freebsd_committer freebsd_triage 2010-06-13 20:53:41 UTC 
rene        2010-06-13 19:53:32 UTC

  FreeBSD ports repository

  Modified files:
    www/sbox-dtc         Makefile 
  Log:
  Make the script runnable again by correctly passing UID_MIN and GID_MIN during
  build.
  Bump PORTREVISION
  
  PR:             ports/147779
  Submitted by:   Serg [mail_of_sergey mail.ru]
  Approved by:    maintainer, tabthorpe (mentor)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.5       +3 -2      ports/www/sbox-dtc/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Rene Ladan freebsd_committer freebsd_triage 2010-06-13 20:53:45 UTC 
State Changed
From-To: open->closed

Committed, thanks