Bug 147794 - [PATCH] security/amavisd-new should not insist Berkeley DB 4.2
Summary: [PATCH] security/amavisd-new should not insist Berkeley DB 4.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Gabor Kovesdan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-11 20:20 UTC by Xin LI
Modified: 2010-07-12 12:14 UTC (History)
1 user (show)

See Also:


Attachments
amavisd-new.diff (485 bytes, patch)
2010-06-11 20:20 UTC, Xin LI
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xin LI freebsd_committer freebsd_triage 2010-06-11 20:20:02 UTC
	Revision 1.78 of Makefile have:

		USE_BDB=42

	Which causes Berkeley DB 4.2 be always installed regardless whether
	higher versions being installed.  This is unnecessary and undesirable.

Fix: The attached patch change the behavior to accept at least 4.2.
	(Note that 4.3 or 4.4 _may_ have some performance issues but at
	 least it worked just fine with 4.6).
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-06-11 20:20:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gabor

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Gabor Kovesdan freebsd_committer freebsd_triage 2010-06-11 20:33:17 UTC
There were some discussions between a user, the author and me, which 
version to use. First, it seemed a good idea to rely on this one because 
this one was confirmed to work properly as opposed to earlier versions 
but now there are also reported problems on this. Now we are 
reconsidering what to do, probably we will change to 4.7+ or directly to 
5.0 in the coming days.

-- 
Gabor Kovesdan
FreeBSD Volunteer

EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org
WEB:   http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org
Comment 3 Xin LI 2010-06-11 20:43:24 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2010/06/11 12:33, Gabor Kovesdan wrote:
> There were some discussions between a user, the author and me, which
> version to use. First, it seemed a good idea to rely on this one because
> this one was confirmed to work properly as opposed to earlier versions
> but now there are also reported problems on this. Now we are
> reconsidering what to do, probably we will change to 4.7+ or directly to
> 5.0 in the coming days.

Note that you can always use INVALID_BDB_VER in conjunction with
USE_BDB=yes.

By the way I fail to see how depending directly on Berkeley DB would
even work (note that amavisd is written in pure perl and the real
dependency is on p5-BerkeleyDB, which is compiled as binary).  It ONLY
work by chance that there is no pre-existing Berkeley DB installed
(well, this really depends on which version bsd.database.mk would pick,
see the .mk file for details).

The real fix seems to be teaching p5-BerkeleyDB about different
BerkeleyDB versions and just revert revision 1.78.

Cheers,
- -- 
Xin LI <delphij@delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!	       Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iQEcBAEBCAAGBQJMEpHcAAoJEATO+BI/yjfBPmQIAJJ99tY1Y9/RgbL3caCc1Xge
Gnhq+JmoeHOWtFUthQlW5b7UWXK+Zpa9C6+LUpaGaQowxnj3xge83B08LeSTF6M7
K2Poj1fEBZ6crYt2rz/A3oZn+fd7+tIdnXA9LqtGGpP+hd6jk19QTSTtQv1FBaP2
VZQBIvirYJBPVh5Ssmy3QNbZyxOyWha5M3WwRBox2kXi04H+KKPkIscZ1hqWv1Yl
hzEXVzY18EdWkmNpXsnHWYxtb6pOCn3XYTXeuxD1oLdY9znIE4LztReMwxqsS+mX
jEQnDpIzlizODBeoazF6fFyo0v8kPyt3YgcwHNkIya+laU+esDiJJ+4BieowQH8=
=58Co
-----END PGP SIGNATURE-----
Comment 4 Gabor Kovesdan freebsd_committer freebsd_triage 2010-06-13 00:37:30 UTC
El 2010. 06. 11. 21:43, Xin LI escribió:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> On 2010/06/11 12:33, Gabor Kovesdan wrote:
>    
>> There were some discussions between a user, the author and me, which
>> version to use. First, it seemed a good idea to rely on this one because
>> this one was confirmed to work properly as opposed to earlier versions
>> but now there are also reported problems on this. Now we are
>> reconsidering what to do, probably we will change to 4.7+ or directly to
>> 5.0 in the coming days.
>>      
> Note that you can always use INVALID_BDB_VER in conjunction with
> USE_BDB=yes.
>
> By the way I fail to see how depending directly on Berkeley DB would
> even work (note that amavisd is written in pure perl and the real
> dependency is on p5-BerkeleyDB, which is compiled as binary).  It ONLY
> work by chance that there is no pre-existing Berkeley DB installed
> (well, this really depends on which version bsd.database.mk would pick,
> see the .mk file for details).
>
> The real fix seems to be teaching p5-BerkeleyDB about different
> BerkeleyDB versions and just revert revision 1.78.
>
>    
Oh, yes, you're right. Somehow I didn't think of it just considered the 
case when it is not present before installing amavisd-new. I'll include 
INVALID_BDB_VER to prevent amavisd-new installing with incompatible bdb 
versions and I've also CC'd clsung@ because of p5-BerkeleyDB. If 
amavisd-new has problems with old bdb versions, probably other ports 
also have so he might make it depend on a newer version (4.7+).

-- 
Gabor Kovesdan
FreeBSD Volunteer

EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org
WEB:   http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-07-11 18:46:53 UTC
gabor       2010-07-11 17:42:37 UTC

  FreeBSD ports repository

  Modified files:
    security/amavisd-new Makefile 
    security/amavisd-new/files amavisd.sh.in pkg-message.in 
  Log:
  - Remove BDB version requirement. This doesn't fix the problem because
    amavisd-new uses BDB through databases/p5-BerkeleyDB and if that port
    is already present on the system when we install amavisd-new, this knob
    won't guarantee that we get the proper version.  The underlying port
    should be changed to use a more modern version of BDB, so instead of
    adding quirks here, a PR has been submitted for that port
    (ports/148494). [1] [2]
  - Proper handling of the WITH_RAR case [3]
  - Remove -M option from mdmfs when using ramdisk.  This reportedly
    stop crashes. [4]
  - Bump PORTREVISION
  
  PR:             ports/147794 [1], ports/147856 [2]
  Submitted by:   delphij [1], Joe Horn <joehorn@gmail.com> [2],
                  Scot Hetzel <swhetzel@gmail.com> [3],
                  Andy Dills <andy@xecu.net> (via private mail) [4]
  
  Revision  Changes    Path
  1.79      +6 -3      ports/security/amavisd-new/Makefile
  1.10      +2 -2      ports/security/amavisd-new/files/amavisd.sh.in
  1.9       +1 -1      ports/security/amavisd-new/files/pkg-message.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Gabor Kovesdan freebsd_committer freebsd_triage 2010-07-12 12:13:49 UTC
State Changed
From-To: open->closed

Fix committed, thanks.