Bug 147893 - [PATCH] net/p5-Socket-GetAddrInfo: fix build depends with perl < 5.10
Summary: [PATCH] net/p5-Socket-GetAddrInfo: fix build depends with perl < 5.10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sahil Tandon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-15 23:30 UTC by Maxim Dounin
Modified: 2010-06-20 21:44 UTC (History)
1 user (show)

See Also:


Attachments
p5-Socket-GetAddrInfo-0.15.patch (557 bytes, patch)
2010-06-15 23:30 UTC, Maxim Dounin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Dounin 2010-06-15 23:30:01 UTC
Using "BUILD_DEPENDS=" causes previously specified dependencies to be
cleared, and thus ExtUtils::CChecker isn't installed as it should.

Port maintainer (sahil@tandon.net) is cc'd.

Fix: Fix is trivial: use "BUILD_DEPENDS+=" instead of "BUILD_DEPENDS=".
How-To-Repeat: Try installing net/p5-Socket-GetAddrInfo on system with perl5.8.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-06-15 23:30:09 UTC
Maintainer of net/p5-Socket-GetAddrInfo,

Please note that PR ports/147893 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147893

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-06-15 23:30:13 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Sahil Tandon freebsd_committer freebsd_triage 2010-06-16 02:04:11 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sahil

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2010-06-20 21:01:19 UTC
sahil       2010-06-20 20:01:04 UTC

  FreeBSD ports repository

  Modified files:
    net/p5-Socket-GetAddrInfo Makefile 
  Log:
  - Change '=' to '+=' when conditionally augmenting BUILD_DEPENDS [1]
  - Update my email to @FreeBSD.org
  
  PR:             ports/147893 [1]
  Submitted by:   Maxim Dounin <mdounin@mdounin.ru>
  Approved by:    itetcu@ (mentor)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.4       +2 -2      ports/net/p5-Socket-GetAddrInfo/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Sahil Tandon freebsd_committer freebsd_triage 2010-06-20 21:44:18 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!