- respect PREFIX for location of uhidd.conf - use PTHREAD_LIBS instead of -lpthread - try to guess kernel sources based on SYSDIR (used by bsd.kmod.mk) or SRC_BASE (used by ports like virtualbox and kqemu) - use KMODDIR in plist, too - I don't think SUB_FILES needs to be *after* bsd.port.pre.mk - inherit DEBUG_FLAGS from make.conf, not only from command line - mimic bsd.kmod.mk in installing .symbols file and add entry to plist How-To-Repeat: $ uhidd -dv /dev/ugen1.2 uhidd[3559]: open /usr/local/etc/uhidd.conf failed: No such file or directory uhidd[3559]: proceed without configuration file
Maintainer of sysutils/uhidd, Please note that PR ports/147898 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147898 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Thanks. The patch looks good to me. Approved! Kai
Thanks! Approved. (Sorry wrong email address used in the last reply)
State Changed From-To: feedback->open Maintainer approved.
Oops, make SRC_BASE alone work, too. --- b.diff begins here --- --- sysutils/uhidd/Makefile~ +++ sysutils/uhidd/Makefile @@ -18,8 +18,10 @@ NO_PACKAGE= should be recompiled for a p OPTIONS= DEVD "Install devd files" on +MAKE_ENV+= SYSDIR=${SYSDIR} KMODDIR?= /boot/modules SRC_BASE?= /usr/src +SYSDIR?= ${SRC_BASE}/sys USE_RC_SUBR= uhidd SUB_FILES= pkg-message --- b.diff ends here ---
State Changed From-To: open->closed Committed, thanks
pav 2010-08-26 14:50:38 UTC FreeBSD ports repository Modified files: sysutils/uhidd Makefile pkg-plist Log: - respect PREFIX for location of uhidd.conf - use PTHREAD_LIBS instead of -lpthread - try to guess kernel sources based on SYSDIR (used by bsd.kmod.mk) or SRC_BASE (used by ports like virtualbox and kqemu) - use KMODDIR in plist, too - I don't think SUB_FILES needs to be *after* bsd.port.pre.mk - inherit DEBUG_FLAGS from make.conf, not only from command line - mimic bsd.kmod.mk in installing .symbols file and add entry to plist PR: ports/147898 Submitted by: Anonymous <swell.k@gmail.com> Approved by: Kai Wang <kaiwang27@gmail.com> (maintainer) Revision Changes Path 1.4 +17 -2 ports/sysutils/uhidd/Makefile 1.2 +2 -1 ports/sysutils/uhidd/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"