- Update to 1.8.9 Generated with FreeBSD Port Tools 0.99
Responsible Changed From-To: freebsd-ports-bugs->niels Thanks! I'll take it
State Changed From-To: open->feedback Hi Lapo, The update builds OK but there are many compiler warnings. Can you fix these ? http://freebsd.heinen.ws/tb/logs/8.0-STABLE/botan-1.8.9.log Kind regards, Niels
I asked the author (Jack Lloyd) about that, and that's what he told me: > It only shows up on 32 bit compilations. It's actually caused by a bug > in GCC, fixed in 4.5.0 (PR 13358). It seems strange to me that this > would be 'too many' warnings - it's effectively one warning. > > There is no actual functionality problem that this warning is pointing > out; GCC is still doing exactly the right thing, just printing an > obnoxious warning for every 64-bit constant it sees that is impossible > to disable via a -Wno-obnoxious-warning flag. The workaround is to > append ULL to each of the constants. I don't want to do that upstream > because every other compiler accepts them without any suffix, but some > Windows compilers will reject the suffixed version. I wonder if it's the best approach to have a hundreds' line patch adding ULLs to a DES cryptographic routine only to silence warnings that produce no problems (except spamming the console, of course!). IMHO it's probably better to avoid that, but I can put some clever inline-sed code to add them, if you think that's really necessary. PS: it would probably be nice to add LICENSE lines in the Makefile though, as in the attached patch.
State Changed From-To: feedback->open Throw back in the pool. Apologies, I don't want to delay this longer (lack of time)
Responsible Changed From-To: niels->ports
Hi Lapo, sorry for delaying this one. I lack the time to follow up and threw the PR back in the pool. Niels On 06/30/10 15:11, Lapo Luchini wrote: > I asked the author (Jack Lloyd) about that, and that's what he told me: > >> It only shows up on 32 bit compilations. It's actually caused by a bug >> in GCC, fixed in 4.5.0 (PR 13358). It seems strange to me that this >> would be 'too many' warnings - it's effectively one warning. >> >> There is no actual functionality problem that this warning is pointing >> out; GCC is still doing exactly the right thing, just printing an >> obnoxious warning for every 64-bit constant it sees that is impossible >> to disable via a -Wno-obnoxious-warning flag. The workaround is to >> append ULL to each of the constants. I don't want to do that upstream >> because every other compiler accepts them without any suffix, but some >> Windows compilers will reject the suffixed version. > > I wonder if it's the best approach to have a hundreds' line patch adding > ULLs to a DES cryptographic routine only to silence warnings that > produce no problems (except spamming the console, of course!). > > IMHO it's probably better to avoid that, but I can put some clever > inline-sed code to add them, if you think that's really necessary. > > PS: it would probably be nice to add LICENSE lines in the Makefile > though, as in the attached patch. -- Niels Heinen FreeBSD committer | www.freebsd.org PGP: 0x5FE39B80
Responsible Changed From-To: ports->freebsd-ports-bugs Canonicalize assignment.
Responsible Changed From-To: freebsd-ports-bugs->sahil I'll take it.
sahil 2010-07-24 05:55:26 UTC FreeBSD ports repository Modified files: security/botan Makefile distinfo Log: - Update to 1.8.9 - Add LICENSE PR: ports/147935 Submitted by: Lapo Luchini <lapo@lapo.it> (maintainer) Revision Changes Path 1.53 +4 -2 ports/security/botan/Makefile 1.33 +3 -3 ports/security/botan/distinfo _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!