Update to version 1.3.2 and I'd claim maintainership. Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it.
State Changed From-To: open->feedback Fails to install, as you've removed installation of PORTDOCS. http://people.freebsd.org/~amdmi3/nettoe-1.3.2.log
That should do it now. The whole port is even simpler now.
* c-s@c-s.li (c-s@c-s.li) wrote: > That should do it now. The whole port is even simpler now. Dropping all PORTDOCS in a bad idea as they contain useful info; reformatting pkg-descr is no use, and longer lines are not preferred. including post.mk and pre.mk should be merged into including just bsd.port.mk. Thus, I suggest this patch: --- nettoe.patch begins here --- Index: Makefile =================================================================== RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/games/nettoe/Makefile,v retrieving revision 1.6 diff -u -r1.6 Makefile --- Makefile 22 Aug 2009 00:22:20 -0000 1.6 +++ Makefile 27 Jul 2010 23:30:30 -0000 @@ -6,24 +6,30 @@ # PORTNAME= nettoe -PORTVERSION= 1.1.0 -PORTREVISION= 1 +PORTVERSION= 1.3.2 CATEGORIES= games -MASTER_SITES= SF +MASTER_SITES= SF \ + http://www.c-s.li/ports/ -MAINTAINER= ports@FreeBSD.org +MAINTAINER= c-s@c-s.li COMMENT= A tic-tac-toe game playable over the network +LICENSE= GPLv2 + +PLIST_FILES= bin/nettoe + MAN6= nettoe.6 USE_GMAKE= yes GNU_CONFIGURE= yes -post-install: +PORTDOCS= AUTHORS BUGS ChangeLog NEWS README TO-DO + .if !defined(NOPORTDOCS) +post-install: ${MKDIR} ${DOCSDIR} -.for I in AUTHORS BUGS COPYING ChangeLog INSTALL NEWS README TO-DO - ${INSTALL_DATA} ${WRKSRC}/$I ${DOCSDIR} +.for I in ${PORTDOCS} + ${INSTALL_DATA} ${WRKSRC}/$I ${DOCSDIR}/ .endfor .endif Index: distinfo =================================================================== RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/games/nettoe/distinfo,v retrieving revision 1.4 diff -u -r1.4 distinfo --- distinfo 24 Nov 2005 19:27:40 -0000 1.4 +++ distinfo 27 Jul 2010 17:12:17 -0000 @@ -1,3 +1,3 @@ -MD5 (nettoe-1.1.0.tar.gz) = 3227629ec7ade9495c7cc4c68243a7b0 -SHA256 (nettoe-1.1.0.tar.gz) = b9166b54a9113277444aa8cb4f4e2bba4ce5d4484f4c8cc10bbd08ab2344535f -SIZE (nettoe-1.1.0.tar.gz) = 50197 +MD5 (nettoe-1.3.2.tar.gz) = abd8037832a3d73be765154e7b27eb4d +SHA256 (nettoe-1.3.2.tar.gz) = 1aba74312e968bb84c556c12c0713128148542b8b2879c78893c47d945da0e24 +SIZE (nettoe-1.3.2.tar.gz) = 94261 Index: pkg-plist =================================================================== RCS file: pkg-plist diff -N pkg-plist --- pkg-plist 1 Jul 2001 22:42:23 -0000 1.1 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,10 +0,0 @@ -bin/nettoe -%%PORTDOCS%%share/doc/nettoe/AUTHORS -%%PORTDOCS%%share/doc/nettoe/BUGS -%%PORTDOCS%%share/doc/nettoe/COPYING -%%PORTDOCS%%share/doc/nettoe/ChangeLog -%%PORTDOCS%%share/doc/nettoe/INSTALL -%%PORTDOCS%%share/doc/nettoe/NEWS -%%PORTDOCS%%share/doc/nettoe/README -%%PORTDOCS%%share/doc/nettoe/TO-DO -%%PORTDOCS%%@dirrm share/doc/nettoe --- nettoe.patch ends here --- -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
Thank you for this nice suggestion. I think you are absolutely right.
State Changed From-To: feedback->closed Committed, with minor changes. Thanks!
amdmi3 2010-08-05 22:55:44 UTC FreeBSD ports repository Modified files: games/nettoe Makefile distinfo Removed files: games/nettoe pkg-plist Log: - Update to 1.3.2 - Pass maintainership to submitter PR: 148373 Submitted by: C-S <c-s@c-s.li> Revision Changes Path 1.7 +13 -7 ports/games/nettoe/Makefile 1.5 +3 -3 ports/games/nettoe/distinfo 1.2 +0 -10 ports/games/nettoe/pkg-plist (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"