Bug 148607 - [patch] graphics/zathura: respect STRIP, make build verbose by default
Summary: [patch] graphics/zathura: respect STRIP, make build verbose by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Max Brazhnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-14 23:00 UTC by swell.k
Modified: 2010-07-23 23:16 UTC (History)
0 users

See Also:


Attachments
a.diff (1.27 KB, patch)
2010-07-14 23:00 UTC, swell.k
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description swell.k 2010-07-14 23:00:13 UTC
- drop USE_GMAKE (adapt include config.mk and $(shell...))
- respect DEBUG_FLAGS rather than DFLAGS, currently any flag (e.g. `-ggdb3')
  in DEBUG_FLAGS or CFLAGS is being overriden by DFLAGS' `-g'
- use PTHREAD_LIBS instead of -lpthread
- no need to specify -lc when no -nostdlib is used
- make build target verbose, options target doesn't show what flags are used when linking
- make install target verbose, so the user know what's being installed
- use CFLAGS when linking, too; makes things like -flto in CFLAGS work
- add extra tab to MAN1 (cosmetic)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-07-14 23:05:56 UTC
Maintainer of graphics/zathura,

Please note that PR ports/148607 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/148607

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-07-14 23:05:57 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Quentin Stievenart 2010-07-15 08:15:29 UTC
On Wed, Jul 14, 2010 at 10:05:56PM +0000, Edwin Groothuis wrote:
> Maintainer of graphics/zathura,
> 
> Please note that PR ports/148607 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.

I approve this patch.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2010-07-15 14:26:12 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Max Brazhnikov freebsd_committer freebsd_triage 2010-07-21 19:33:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->makc

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2010-07-23 23:05:19 UTC
makc        2010-07-23 22:05:11 UTC

  FreeBSD ports repository

  Modified files:
    graphics/zathura     Makefile 
  Log:
  - drop USE_GMAKE
  - respect DEBUG_FLAGS rather than DFLAGS, currently any flag (e.g. `-ggdb3')
  in DEBUG_FLAGS or CFLAGS is being overriden by DFLAGS' `-g'
  - use PTHREAD_LIBS instead of -lpthread
  - no need to specify -lc when no -nostdlib is used
  - make build target verbose, options target doesn't show what flags are used when linking
  - make install target verbose, so the user know what's being installed
  - use CFLAGS when linking, too; makes things like -flto in CFLAGS work
  - add extra tab to MAN1 (cosmetic)
  
  PR:             ports/148607
  Submitted by:   Anonymous <swell.k at gmail.com>
  Approved by:    Quentin Stievenart (maintainer)
  
  Revision  Changes    Path
  1.2       +19 -4     ports/graphics/zathura/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Max Brazhnikov freebsd_committer freebsd_triage 2010-07-23 23:16:45 UTC
State Changed
From-To: open->closed

Committed. Thanks!