Bug 148802 - [PATCH] audio/audacity-devel: Fix build error and other cleanups
Summary: [PATCH] audio/audacity-devel: Fix build error and other cleanups
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Greg Larkin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-20 21:40 UTC by Greg Larkin
Modified: 2010-08-02 16:00 UTC (History)
1 user (show)

See Also:


Attachments
audacity-devel-1.3.12_3.patch (2.05 KB, patch)
2010-07-20 21:40 UTC, Greg Larkin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Larkin freebsd_committer freebsd_triage 2010-07-20 21:40:04 UTC
rnejdl@ringofsaturn.com reported in PR ports/145221 that audacity fails to
compile. This problem was caused by a conflict with the installed version
of devel/allegro.

audio/audacity-devel/Makefile has been updated to locate allegro.h within
its bundled portsmf directory, instead of searching the system include files
first. devel/allegro's allegro.h include file is very different than the one
provided by portsmf.

I also fixed various portlint warnings and errors related to GNU autotools.

Port maintainer (xxjack12xx@gmail.com) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-07-20 21:40:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->glarkin

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-07-20 21:40:20 UTC
Maintainer of audio/audacity-devel,

Please note that PR ports/148802 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/148802

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2010-07-20 21:40:23 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Mark Linimon 2010-08-01 17:43:18 UTC
----- Forwarded message from "Jack L." <xxjack12xx@gmail.com> -----

From: "Jack L." <xxjack12xx@gmail.com>
To: edwin@freebsd.org
Cc: glarkin@freebsd.org, freebsd-ports-bugs@freebsd.org
Subject: Re: ports/148802: [PATCH] audio/audacity-devel: Fix build error and
	other cleanups

[Resend as it didn't go to all the intended recipients]

Compiles fine with allegro installed. Patch looks good. I say go for it.

On Tue, Jul 20, 2010 at 1:40 PM,  <edwin@freebsd.org> wrote:
> Synopsis: [PATCH] audio/audacity-devel: Fix build error and other cleanups
>
> Responsible-Changed-From-To: freebsd-ports-bugs->glarkin
> Responsible-Changed-By: edwin
> Responsible-Changed-When: Tue Jul 20 20:40:18 UTC 2010
> Responsible-Changed-Why:
> Submitter has GNATS access (via the GNATS Auto Assign Tool)
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=148802
> _______________________________________________
> freebsd-ports-bugs@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
> To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"
>
_______________________________________________
freebsd-ports-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"


----- End forwarded message -----
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2010-08-01 17:43:27 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 6 dfilter service freebsd_committer freebsd_triage 2010-08-02 15:54:31 UTC
glarkin     2010-08-02 14:54:17 UTC

  FreeBSD ports repository

  Modified files:
    audio/audacity-devel Makefile 
  Log:
  - Fixed compiler error when devel/allegro is installed
  - Miscellaneous portlint cleanups
  - Bumped PORTREVISION
  
  PR:             ports/148802
  Reported by:    Rusty Nejdl <rnejdl at ringofsaturn dot com>
  Approved by:    "Jack L." <xxjack12xx at gmail dot com> (maintainer)
  
  Revision  Changes    Path
  1.47      +14 -8     ports/audio/audacity-devel/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Greg Larkin freebsd_committer freebsd_triage 2010-08-02 15:54:36 UTC
State Changed
From-To: open->closed

Committed, thank you!