Bug 148867 - [patch] net-p2p/dcd - set the correct signal for sig_stop
Summary: [patch] net-p2p/dcd - set the correct signal for sig_stop
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Andrej Zverev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-23 15:40 UTC by Daniel Gerzo
Modified: 2010-07-27 20:40 UTC (History)
0 users

See Also:

Attachments
dcd.sh.in.diff (251 bytes, patch)
2010-07-23 15:40 UTC, Daniel Gerzo 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Gerzo freebsd_committer freebsd_triage 2010-07-23 15:40:03 UTC 
in /etc/rc.subr, we have _run_rc_killcmd() function, which does this:
_cmd="kill -$1 $rc_pid".

When we set sig_stop to -KILL, the kill command receives wrong signal
(i.e. "--KILL") so it silently sends a wrong signal.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-07-23 15:41:39 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->az

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Daniel Gerzo freebsd_committer freebsd_triage 2010-07-27 20:34:42 UTC 
State Changed
From-To: open->closed

- commited upon az's request
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-07-27 20:34:43 UTC 
danger      2010-07-27 19:34:34 UTC

  FreeBSD ports repository (doc committer)

  Modified files:
    net-p2p/dcd          Makefile 
    net-p2p/dcd/files    dcd.sh.in 
  Log:
  - fix the handling of sig_stop signal in the rc.d script
  
  PR:             148867
  Submitted by:   danger
  Approved by:    az (maintainer) via private email
  
  Revision  Changes    Path
  1.13      +1 -0      ports/net-p2p/dcd/Makefile
  1.5       +1 -1      ports/net-p2p/dcd/files/dcd.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"