Bug 149135 - [patch] security/sudo: obey STRIP, makes WITH_DEBUG useful
Summary: [patch] security/sudo: obey STRIP, makes WITH_DEBUG useful
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-31 06:40 UTC by swell.k
Modified: 2010-08-22 13:40 UTC (History)
0 users

See Also:


Attachments
a.diff (677 bytes, patch)
2010-07-31 06:40 UTC, swell.k
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description swell.k 2010-07-31 06:40:03 UTC

    
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-07-31 06:40:53 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wxs

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Wesley Shields freebsd_committer freebsd_triage 2010-08-22 03:01:56 UTC
This patch has no effect on the latest port.

-- WXS
Comment 3 swell.k 2010-08-22 05:00:38 UTC
Now it's the other way around - not stripped by default.

--- a.diff begins here ---
Index: security/sudo/Makefile
===================================================================
RCS file: /a/.cvsup/ports/security/sudo/Makefile,v
retrieving revision 1.113
diff -u -p -r1.113 Makefile
--- security/sudo/Makefile	22 Aug 2010 01:58:33 -0000	1.113
+++ security/sudo/Makefile	22 Aug 2010 03:55:08 -0000
@@ -85,6 +85,8 @@ MAN8=		sudo.8 visudo.8 sudoreplay.8
 MLINKS=		sudo.8 sudoedit.8
 
 post-patch:
+	@${REINPLACE_CMD} '/install-binaries:/,/^$$/s/$$(INSTALL)/& ${STRIP}/' \
+		${WRKSRC}/Makefile.in
 .if defined(NOPORTDOCS)
 	@${REINPLACE_CMD} -e 's/$$(DESTDIR)$$(sudoersdir) $$(DESTDIR)$$(docdir)/$$(DESTDIR)$$(sudoersdir)/' \
 		${WRKSRC}/Makefile.in
--- a.diff ends here ---
Comment 4 dfilter service freebsd_committer freebsd_triage 2010-08-22 13:32:36 UTC
wxs         2010-08-22 12:32:26 UTC

  FreeBSD ports repository

  Modified files:
    security/sudo        Makefile 
  Log:
  Strip the binaries by default. No need to bump PORTREVISION for such a
  minor change.
  
  PR:             ports/149135
  Submitted by:   Anonymous <swell.k@gmail.com>
  
  Revision  Changes    Path
  1.114     +2 -0      ports/security/sudo/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Wesley Shields freebsd_committer freebsd_triage 2010-08-22 13:32:37 UTC
State Changed
From-To: open->closed

Committed. Thanks!