Bug 149290 - [patch] textproc/gnugrep: respect WITHOUT_NLS
Summary: [patch] textproc/gnugrep: respect WITHOUT_NLS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Gabor Kovesdan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-04 19:30 UTC by swell.k
Modified: 2010-08-15 02:00 UTC (History)
0 users

See Also:


Attachments
a.diff (3.68 KB, patch)
2010-08-04 19:30 UTC, swell.k
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description swell.k 2010-08-04 19:30:07 UTC
- move CONFLICTS and USE_XZ closer to the top (cosmetic)
- push PLIST_FILES to pkg-plist (cosmetic)
- mark whole post-patch target .SILENT (cosmetic)
- hide --disable-nls behind WITHOUT_NLS
- don't create/update charset.alias for WITHOUT_NLS
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-08-04 19:30:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gabor

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 swell.k 2010-08-04 20:00:22 UTC
Oops, -lintl in LDFLAGS is not needed. configure script already checks
gettext in libc/libintl.

And because HAVE_LIBINTL_H is not really used there is no need for

  CPPFLAGS=-I${LOCALBASE}/include

in CONFIGURE_ENV. Works fine without it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-08-15 01:51:42 UTC
gabor       2010-08-15 00:51:33 UTC

  FreeBSD ports repository

  Modified files:
    textproc/gnugrep     Makefile 
  Added files:
    textproc/gnugrep     pkg-plist 
  Log:
  - Add support for NLS with the conventional WITHOUT_NLS knob to disable it
  - Silence post-patch target
  - Bump PORTREVISION
  - Cosmetic changes
  
  PR:             ports/149290
  Submitted by:   swell.k@gmail.com
  
  Revision  Changes    Path
  1.6       +18 -10    ports/textproc/gnugrep/Makefile
  1.1       +47 -0     ports/textproc/gnugrep/pkg-plist (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Gabor Kovesdan freebsd_committer freebsd_triage 2010-08-15 01:51:50 UTC
State Changed
From-To: open->closed

Committed, thanks! I've changed .SILENT to @'s because this it the 
conventional way how se silence commands and I've also bumped 
PORTREVISION.