Bug 150150 - [PATCH] sysutils/freebsd-snapshot: confusing warning message
Summary: [PATCH] sysutils/freebsd-snapshot: confusing warning message
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-31 15:30 UTC by Janne Snabb
Modified: 2010-09-03 16:20 UTC (History)
1 user (show)

See Also:


Attachments
freebsd-snapshot-20091208.1.patch (1.14 KB, patch)
2010-08-31 15:30 UTC, Janne Snabb
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Janne Snabb 2010-08-31 15:30:04 UTC
When using "snapshot" command to "mount" or "visit" existing ufs
snapshots an useless and confusing warning message as follows is
always displayed:

WARNING: opening backing store: /usr/.snap/hourly.0 readonly

This warning message is emitted by mdconfig(8) when it is called
by the "snapshot" script.

This is irritating for example when freebsd-snapshot is being used
for making automated backups from cron(8) scripts because an un-needed
output is always generated even though there is no problem.

Port maintainer (gtodd@bellanet.org) as well as the upstream
(rse@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99

Fix: Add "-o readonly" to mdconfig(8) options, it prevents this warning
message from being displayed. This should not be a problem as
snapshots are by definition read-only.

The following patch is a bit funny because it patches an existing
patch file in the port.
How-To-Repeat: 
# snapshot visit /usr:hourly.0
WARNING: opening backing store: /usr/.snap/hourly.0 readonly
# exit
# snapshot mount /usr:hourly.0 /mnt
WARNING: opening backing store: /usr/.snap/hourly.0 readonly
#
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-08-31 15:30:13 UTC
Maintainer of sysutils/freebsd-snapshot,

Please note that PR ports/150150 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/150150

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-08-31 15:30:17 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Graham Todd 2010-09-02 15:19:06 UTC
On 08/31/10 10:30, Edwin Groothuis wrote:
> Maintainer of sysutils/freebsd-snapshot,
> 
> Please note that PR ports/150150 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/150150
> 

I approve this patch.

Thanks for reporting, patching and improving this utility.
Comment 4 Baptiste Daroussin freebsd_committer freebsd_triage 2010-09-03 16:05:13 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bapt

I'll take it.
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-09-03 16:11:12 UTC
bapt        2010-09-03 15:11:01 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/freebsd-snapshot Makefile 
    sysutils/freebsd-snapshot/files patch-snapshot 
  Log:
  - Remove useless and confusing warning message
  - Bump portrevision
  
  PR:             ports/150150
  Submitted by:   Janne Snabb <snabb _at_ epipe.com>
  Approved by:    Graham Todd <gtodd _at_ bellanet.org> (maintainer)
  
  Revision  Changes    Path
  1.13      +1 -0      ports/sysutils/freebsd-snapshot/Makefile
  1.6       +11 -2     ports/sysutils/freebsd-snapshot/files/patch-snapshot
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Baptiste Daroussin freebsd_committer freebsd_triage 2010-09-03 16:11:13 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!