Provide a script that user can easily bind ffmpegthumbnailer with nautilus Fix: Patch attached with submission follows:
Maintainer of multimedia/ffmpegthumbnailer, Please note that PR ports/150361 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/150361 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
State Changed From-To: feedback->open maintainer timeout (dierk@blaxxtarz.de ; 16 days)
State Changed From-To: open->feedback I have questions for the submitter.
Responsible Changed From-To: freebsd-ports-bugs->stephen I'll take it.
It seems to me that a problem with this patch is that the bind-nautilus.sh script is not available to anyone who installs this as a package. So: # pkg_add ffmpegthumbnailer-2.0.4_1.tbz For Gnome user: If you wish to bind this with nautilus, see files/bind-nautilus.sh The user installing this using a package doesn't have any idea where files/bind-nautilus.sh is. Shouldn't this script be stored somewhere under /usr/local? I must admit that I don't know where this sort of thing is conventionally stored.
how about put it in share/ (%%DATADIR%%) ?
I made some changes to your patch. First, I have put the script into %%DATADIR%% as you suggest. Second, I changed the typesetting of pkg-message. portlint doesn't like blank lines at the end of pkg-message. Thirdly, I added a comment to bind-nautilus.sh so that a casual user who comes across it will understand what it is about. Tell me what you think. I am a new committer, so after making the changes I will have to submit it to my mentors for approval.
that's good, thank you!
stephen 2011-07-05 21:46:07 UTC FreeBSD ports repository Modified files: multimedia/ffmpegthumbnailer Makefile pkg-plist Added files: multimedia/ffmpegthumbnailer/files bind-nautilus.sh pkg-message.in Log: - Add script to allow users to bind with nautilus. - Bump portrevision. PR: ports/150361 Submitted by: Kuan-Chung Chiu <buganini@gmail.com> Approved by: maho (mentor) Revision Changes Path 1.13 +7 -3 ports/multimedia/ffmpegthumbnailer/Makefile 1.1 +16 -0 ports/multimedia/ffmpegthumbnailer/files/bind-nautilus.sh (new) 1.1 +2 -0 ports/multimedia/ffmpegthumbnailer/files/pkg-message.in (new) 1.5 +2 -0 ports/multimedia/ffmpegthumbnailer/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thanks!