- update - remove -lutil cruft from before AC_CHECK_LIB() was added - either use openpty() or search manually (not sure)[1] [1] PTYS_ARE_PTMX ifdef patch was incorrect, anyway. According to configure.ac there can be only one of PTYS_ARE_XXX be defined at a time because the check uses `else if'.
Maintainer of devel/rlwrap, Please note that PR ports/150694 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/150694 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->pgollucci I will take it
State Changed From-To: feedback->open maintainer timeout (gamato@users.sf.net ; 14 days)
pgollucci 2010-10-06 03:40:46 UTC FreeBSD ports repository Modified files: devel/rlwrap Makefile distinfo pkg-plist devel/rlwrap/files patch-src::ptytty.c Log: - update to 0.37 - remove -lutil cruft from before AC_CHECK_LIB() was added - either use openpty() or search manually (not sure)[1] [1] PTYS_ARE_PTMX ifdef patch was incorrect, anyway. According to configure.ac there can be only one of PTYS_ARE_XXX be defined at a time because the check uses `else if'. PR: ports/150694 Submitted by: swell.k@gmail.com Approved by: maintainer timeout (gamato@users.sf.net ; 14 days) Revision Changes Path 1.33 +4 -2 ports/devel/rlwrap/Makefile 1.16 +3 -3 ports/devel/rlwrap/distinfo 1.5 +0 -9 ports/devel/rlwrap/files/patch-src::ptytty.c 1.6 +1 -0 ports/devel/rlwrap/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, Thanks!
Edwin Groothuis wrote: > Maintainer of devel/rlwrap, > > Please note that PR ports/150694 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/150694 > > Ok, I approve. Sorry for delay. Btw, this is a feedback from rlwrap maintainer on our (previous) port: Hi Martin The solution is trivial: the line CONFIGURE_ENV+= ptyttylib_cv_ptys=BSD LDFLAGS=-lutil in the port Makefile forces the configure script to skip autodetection of pty type, and to take the wrong decision. It may have been necessary long, long ago, but not anymore. Just remove it, and everything will work just fine. I will rename the $ptyttylib_cv_ptys value "BSD" to "PREHISTORIC" to remove the temptation for BSD people to set this varable... regards Hans
State Changed From-To: closed->open Maintainer approved
State Changed From-To: open->feedback Request Feedback: do I need to change something else here? A diff would be appreciated.
pgollucci@FreeBSD.org writes: > Request Feedback: do I need to change something else here? A diff would > be appreciated. I've made that diff with s/BSD/PREHISTORIC/ in mind. And maintainer approved the changes, too. I think it can be closed.
State Changed From-To: feedback->closed Committed, Thanks!