Bug 150854 - [patch] ftp/curl: respect -g[0-3] and -O[0-4] in CFLAGS
Summary: [patch] ftp/curl: respect -g[0-3] and -O[0-4] in CFLAGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Peter Pentchev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-22 09:40 UTC by swell.k
Modified: 2010-12-19 20:24 UTC (History)
0 users

See Also:


Attachments
a.diff (606 bytes, patch)
2010-09-22 09:40 UTC, swell.k
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description swell.k 2010-09-22 09:40:01 UTC
Don't override DEBUG_FLAGS either added via WITH_DEBUG or manually,
i.e. remove -g0 for WITHOUT_CURL_DEBUG and -g for WITH_CURL_DEBUG.

And erase -O2 from flags_opt_yes in case CFLAGS doesn't have -O2.

How-To-Repeat: $ export WITH_DEBUG= DEBUG_FLAGS=-g3
$ make -V CFLAGS
-pipe -g3
$ make
...
libtool: compile:  cc -DHAVE_CONFIG_H -I../include/curl -I../include -I../include -I../lib -I../lib -I/usr/local/include -I/usr/include/openssl -I/usr/local/include -pipe -g0 -O2 -Wno-system-headers -Werror -MT http.lo -MD -MP -MF .deps/http.Tpo -c http.c  -fPIC -DPIC -o http.o >/dev/null 2>&1

Neither -g0 nor -O2 is present in CFLAGS.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-09-22 09:40:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->roam

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Peter Pentchev freebsd_committer freebsd_triage 2010-09-26 03:52:37 UTC
State Changed
From-To: open->analyzed

Looking into this, thanks for your work on curl!
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-12-19 20:04:29 UTC
roam        2010-12-19 20:04:23 UTC

  FreeBSD ports repository

  Modified files:
    ftp/curl             Makefile distinfo pkg-plist 
    ftp/curl/files       patch-Makefile.in patch-configure 
                         patch-lib::url.c patch-src::main.c 
  Log:
  Update cURL to 7.21.3 and fix its librtmp detection.  In the process:
  - disable the -Werror build option by popular demand
  - do not override the user's debug and optimization settings
  
  PR:             150854 (the debug and optimization CFLAGS)
  Reported by:    Anonymous <swell.k@gmail.com>
  
  Revision  Changes    Path
  1.111     +4 -10     ports/ftp/curl/Makefile
  1.59      +2 -3      ports/ftp/curl/distinfo
  1.9       +3 -3      ports/ftp/curl/files/patch-Makefile.in
  1.14      +102 -9    ports/ftp/curl/files/patch-configure
  1.10      +2 -2      ports/ftp/curl/files/patch-lib::url.c
  1.12      +3 -3      ports/ftp/curl/files/patch-src::main.c
  1.30      +2 -0      ports/ftp/curl/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Peter Pentchev freebsd_committer freebsd_triage 2010-12-19 20:23:57 UTC
State Changed
From-To: analyzed->closed

I've committed a curl port update to 7.21.3, which includes 
a fix for this problem.  Thanks for bringing it to our attention!